From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: devel@driverdev.osuosl.org, wsa@the-dreams.de,
gregkh@linuxfoundation.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org,
Quytelda Kahja <quytelda@tamalin.org>
Subject: Re: [PATCH 3/5] staging: ks7010: Factor out repeated code into function 'ks_wlan_cap()'.
Date: Thu, 1 Mar 2018 14:15:00 +0300 [thread overview]
Message-ID: <20180301111500.lxge4yqfyi2najt6@mwanda> (raw)
In-Reply-To: <20180301063721.GD4059@eros>
On Thu, Mar 01, 2018 at 05:37:21PM +1100, Tobin C. Harding wrote:
> On Wed, Feb 28, 2018 at 09:19:09PM -0800, Quytelda Kahja wrote:
> > The code that generates a WLAN capability mask is repeated in five
> > functions. This change refactors that code into a new function, which is
> > called now in each of those functions.
>
> Perhaps in future something like:
>
> Code to generate the WLAN capability mask is duplicated five times
>
> Add helper function to generate WLAN capability mask, refactor code to
> use newly defined function.
>
I honestly don't see the difference between that and what Quytelda
wrote? I understood the original changelog just fine.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-03-01 11:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 5:19 [PATCH 1/5] staging: ks7010: Use constants from ieee80211_eid instead of literal ints Quytelda Kahja
2018-03-01 5:19 ` [PATCH 2/5] staging: ks7010: Replace SSID_MAX_SIZE with IEEE80211_MAX_SSID_LEN Quytelda Kahja
2018-03-01 5:19 ` [PATCH 3/5] staging: ks7010: Factor out repeated code into function 'ks_wlan_cap()' Quytelda Kahja
2018-03-01 6:37 ` Tobin C. Harding
2018-03-01 11:15 ` Dan Carpenter [this message]
2018-03-01 20:54 ` Tobin C. Harding
2018-03-02 1:28 ` Quytelda Kahja
2018-03-02 2:21 ` Tobin C. Harding
2018-03-02 9:07 ` Dan Carpenter
2018-03-02 9:05 ` Dan Carpenter
2018-03-04 22:57 ` Tobin C. Harding
2018-03-01 5:19 ` [PATCH 4/5] staging: ks7010: Replace local capability constants with kernel constants Quytelda Kahja
2018-03-01 5:19 ` [PATCH 5/5] staging: ks7010: Replace local frame type " Quytelda Kahja
2018-03-01 6:33 ` [PATCH 1/5] staging: ks7010: Use constants from ieee80211_eid instead of literal ints Tobin C. Harding
2018-03-01 6:34 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180301111500.lxge4yqfyi2najt6@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=quytelda@tamalin.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).