From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030525AbeCAMuj (ORCPT ); Thu, 1 Mar 2018 07:50:39 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:35868 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1030347AbeCAMug (ORCPT ); Thu, 1 Mar 2018 07:50:36 -0500 Date: Thu, 1 Mar 2018 13:50:31 +0100 From: Cornelia Huck To: Arvind Yadav Cc: jwi@linux.vnet.ibm.com, ubraun@linux.vnet.ibm.com, davem@davemloft.net, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v3] net: iucv: Free memory obtained by kzalloc Message-ID: <20180301135031.149076bf.cohuck@redhat.com> In-Reply-To: <1519903917-11575-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1519903917-11575-1-git-send-email-arvind.yadav.cs@gmail.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 1 Mar 2018 17:01:57 +0530 Arvind Yadav wrote: > Free memory by calling put_device(), if afiucv_iucv_init is not > successful. > > Signed-off-by: Arvind Yadav > --- > changes in v2: > Calling put_device() before kfree(). > changes in v3: > No need to call kfree(). So removed kfree(). > > net/iucv/af_iucv.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c > index 1e8cc7b..9e2643a 100644 > --- a/net/iucv/af_iucv.c > +++ b/net/iucv/af_iucv.c > @@ -2433,9 +2433,11 @@ static int afiucv_iucv_init(void) > af_iucv_dev->driver = &af_iucv_driver; > err = device_register(af_iucv_dev); > if (err) > - goto out_driver; > + goto out_iucv_dev; > return 0; > > +out_iucv_dev: > + put_device(af_iucv_dev); > out_driver: > driver_unregister(&af_iucv_driver); > out_iucv: Reviewed-by: Cornelia Huck