* [RFC 1/5] seq_file: introduce seq_open_data helper
@ 2018-03-01 23:37 Rasmus Villemoes
2018-03-01 23:37 ` [RFC 2/5] ia64/sn/hwperf: use seq_open_data Rasmus Villemoes
` (4 more replies)
0 siblings, 5 replies; 10+ messages in thread
From: Rasmus Villemoes @ 2018-03-01 23:37 UTC (permalink / raw)
To: Jonathan Corbet, Alexander Viro
Cc: Rasmus Villemoes, Tony Luck, linux-ia64, Michael Ellerman,
linuxppc-dev, linux-doc, linux-kernel, linux-fsdevel
There are quite a few callers of seq_open that could be simplified by
setting the ->private member via the seq_open call instead of fetching
file->private_data afterwards.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
I've just included a few examples of possible users of this helper,
there are many more similar cases. As a bonus, the first two fix
potential NULL derefs (if one believes that seq_open can actually
fail).
seq_open_private would have been a better name, but that one is
already taken...
Documentation/filesystems/seq_file.txt | 9 +++++----
fs/seq_file.c | 9 ++++++++-
include/linux/seq_file.h | 1 +
3 files changed, 14 insertions(+), 5 deletions(-)
diff --git a/Documentation/filesystems/seq_file.txt b/Documentation/filesystems/seq_file.txt
index 9de4303201e1..68571b8275d8 100644
--- a/Documentation/filesystems/seq_file.txt
+++ b/Documentation/filesystems/seq_file.txt
@@ -234,10 +234,11 @@ Here, the call to seq_open() takes the seq_operations structure we created
before, and gets set up to iterate through the virtual file.
On a successful open, seq_open() stores the struct seq_file pointer in
-file->private_data. If you have an application where the same iterator can
-be used for more than one file, you can store an arbitrary pointer in the
-private field of the seq_file structure; that value can then be retrieved
-by the iterator functions.
+file->private_data. If you have an application where the same iterator
+can be used for more than one file, you can store an arbitrary pointer
+in the private field of the seq_file structure; that value can then be
+retrieved by the iterator functions. Using the wrapper seq_open_data()
+allows you to set the initial value for that field.
There is also a wrapper function to seq_open() called seq_open_private(). It
kmallocs a zero filled block of memory and stores a pointer to it in the
diff --git a/fs/seq_file.c b/fs/seq_file.c
index eea09f6d8830..f2145cb6e23d 100644
--- a/fs/seq_file.c
+++ b/fs/seq_file.c
@@ -45,7 +45,7 @@ static void *seq_buf_alloc(unsigned long size)
* Note: seq_open() will allocate a struct seq_file and store its
* pointer in @file->private_data. This pointer should not be modified.
*/
-int seq_open(struct file *file, const struct seq_operations *op)
+int seq_open_data(struct file *file, const struct seq_operations *op, void *data)
{
struct seq_file *p;
@@ -59,6 +59,7 @@ int seq_open(struct file *file, const struct seq_operations *op)
mutex_init(&p->lock);
p->op = op;
+ p->private = data;
// No refcounting: the lifetime of 'p' is constrained
// to the lifetime of the file.
@@ -85,6 +86,12 @@ int seq_open(struct file *file, const struct seq_operations *op)
}
EXPORT_SYMBOL(seq_open);
+int seq_open(struct file *file, const struct seq_operations *op)
+{
+ return seq_open_data(file, op, NULL);
+}
+EXPORT_SYMBOL(seq_open_data);
+
static int traverse(struct seq_file *m, loff_t offset)
{
loff_t pos = 0, index;
diff --git a/include/linux/seq_file.h b/include/linux/seq_file.h
index ab437dd2e3b9..f5ff376fa62b 100644
--- a/include/linux/seq_file.h
+++ b/include/linux/seq_file.h
@@ -107,6 +107,7 @@ void seq_pad(struct seq_file *m, char c);
char *mangle_path(char *s, const char *p, const char *esc);
int seq_open(struct file *, const struct seq_operations *);
+int seq_open_data(struct file *, const struct seq_operations *, void *);
ssize_t seq_read(struct file *, char __user *, size_t, loff_t *);
loff_t seq_lseek(struct file *, loff_t, int);
int seq_release(struct inode *, struct file *);
--
2.15.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [RFC 2/5] ia64/sn/hwperf: use seq_open_data
2018-03-01 23:37 [RFC 1/5] seq_file: introduce seq_open_data helper Rasmus Villemoes
@ 2018-03-01 23:37 ` Rasmus Villemoes
2018-03-02 8:22 ` Rasmus Villemoes
2018-03-01 23:37 ` [RFC 3/5] powerpc/pseries: use seq_open_data in hcall_inst_seq_open Rasmus Villemoes
` (3 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Rasmus Villemoes @ 2018-03-01 23:37 UTC (permalink / raw)
To: Tony Luck, Fenghua Yu; +Cc: Rasmus Villemoes, linux-ia64, linux-kernel
This code should check the return value of seq_open(); if it failed,
file->private_data is NULL. But we can avoid the issue entirely and
simplify the code by letting seq_open_data() set the ->private member
to objbuf.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
arch/ia64/sn/kernel/sn2/sn_hwperf.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/ia64/sn/kernel/sn2/sn_hwperf.c b/arch/ia64/sn/kernel/sn2/sn_hwperf.c
index 55febd65911a..fba7f3ad99f4 100644
--- a/arch/ia64/sn/kernel/sn2/sn_hwperf.c
+++ b/arch/ia64/sn/kernel/sn2/sn_hwperf.c
@@ -941,14 +941,11 @@ static int sn_hwperf_init(void)
int sn_topology_open(struct inode *inode, struct file *file)
{
int e;
- struct seq_file *seq;
struct sn_hwperf_object_info *objbuf;
int nobj;
if ((e = sn_hwperf_enum_objects(&nobj, &objbuf)) == 0) {
- e = seq_open(file, &sn_topology_seq_ops);
- seq = file->private_data;
- seq->private = objbuf;
+ e = seq_open_data(file, &sn_topology_seq_ops, objbuf);
}
return e;
--
2.15.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [RFC 3/5] powerpc/pseries: use seq_open_data in hcall_inst_seq_open
2018-03-01 23:37 [RFC 1/5] seq_file: introduce seq_open_data helper Rasmus Villemoes
2018-03-01 23:37 ` [RFC 2/5] ia64/sn/hwperf: use seq_open_data Rasmus Villemoes
@ 2018-03-01 23:37 ` Rasmus Villemoes
2018-03-01 23:37 ` [RFC 4/5] fm10k: use seq_open_data() Rasmus Villemoes
` (2 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Rasmus Villemoes @ 2018-03-01 23:37 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman
Cc: Rasmus Villemoes, linuxppc-dev, linux-kernel
This code should check the return value of seq_open(); if it failed,
file->private_data is NULL. But we can avoid the issue entirely and
simplify the code by letting seq_open_data() set the ->private member.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
arch/powerpc/platforms/pseries/hvCall_inst.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/arch/powerpc/platforms/pseries/hvCall_inst.c b/arch/powerpc/platforms/pseries/hvCall_inst.c
index 89b7ce807e70..05990c9fe264 100644
--- a/arch/powerpc/platforms/pseries/hvCall_inst.c
+++ b/arch/powerpc/platforms/pseries/hvCall_inst.c
@@ -92,14 +92,7 @@ static const struct seq_operations hcall_inst_seq_ops = {
static int hcall_inst_seq_open(struct inode *inode, struct file *file)
{
- int rc;
- struct seq_file *seq;
-
- rc = seq_open(file, &hcall_inst_seq_ops);
- seq = file->private_data;
- seq->private = file_inode(file)->i_private;
-
- return rc;
+ return seq_open_data(file, &hcall_inst_seq_ops, file_inode(file)->i_private);
}
static const struct file_operations hcall_inst_seq_fops = {
--
2.15.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [RFC 4/5] fm10k: use seq_open_data()
2018-03-01 23:37 [RFC 1/5] seq_file: introduce seq_open_data helper Rasmus Villemoes
2018-03-01 23:37 ` [RFC 2/5] ia64/sn/hwperf: use seq_open_data Rasmus Villemoes
2018-03-01 23:37 ` [RFC 3/5] powerpc/pseries: use seq_open_data in hcall_inst_seq_open Rasmus Villemoes
@ 2018-03-01 23:37 ` Rasmus Villemoes
2018-03-01 23:37 ` [RFC 5/5] PCI: tegra: use seq_open_data Rasmus Villemoes
2018-03-01 23:44 ` [RFC 1/5] seq_file: introduce seq_open_data helper Andreas Dilger
4 siblings, 0 replies; 10+ messages in thread
From: Rasmus Villemoes @ 2018-03-01 23:37 UTC (permalink / raw)
To: Jeff Kirsher; +Cc: Rasmus Villemoes, intel-wired-lan, netdev, linux-kernel
Simplify the code slightly by having seq_open_data do the ->private assignment.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
drivers/net/ethernet/intel/fm10k/fm10k_debugfs.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_debugfs.c b/drivers/net/ethernet/intel/fm10k/fm10k_debugfs.c
index 14df09e2d964..acf034feb8fa 100644
--- a/drivers/net/ethernet/intel/fm10k/fm10k_debugfs.c
+++ b/drivers/net/ethernet/intel/fm10k/fm10k_debugfs.c
@@ -132,20 +132,13 @@ static int fm10k_dbg_desc_open(struct inode *inode, struct file *filep)
struct fm10k_ring *ring = inode->i_private;
struct fm10k_q_vector *q_vector = ring->q_vector;
const struct seq_operations *desc_seq_ops;
- int err;
if (ring < q_vector->rx.ring)
desc_seq_ops = &fm10k_dbg_tx_desc_seq_ops;
else
desc_seq_ops = &fm10k_dbg_rx_desc_seq_ops;
- err = seq_open(filep, desc_seq_ops);
- if (err)
- return err;
-
- ((struct seq_file *)filep->private_data)->private = ring;
-
- return 0;
+ return seq_open_data(filep, desc_seq_ops, ring);
}
static const struct file_operations fm10k_dbg_desc_fops = {
--
2.15.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [RFC 5/5] PCI: tegra: use seq_open_data
2018-03-01 23:37 [RFC 1/5] seq_file: introduce seq_open_data helper Rasmus Villemoes
` (2 preceding siblings ...)
2018-03-01 23:37 ` [RFC 4/5] fm10k: use seq_open_data() Rasmus Villemoes
@ 2018-03-01 23:37 ` Rasmus Villemoes
2018-03-02 10:42 ` Thierry Reding
2018-03-01 23:44 ` [RFC 1/5] seq_file: introduce seq_open_data helper Andreas Dilger
4 siblings, 1 reply; 10+ messages in thread
From: Rasmus Villemoes @ 2018-03-01 23:37 UTC (permalink / raw)
To: Thierry Reding, Lorenzo Pieralisi, Bjorn Helgaas, Jonathan Hunter
Cc: Rasmus Villemoes, linux-tegra, linux-pci, linux-kernel
Simplify the code slightly by having seq_open_data do the ->private
assignment.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
drivers/pci/host/pci-tegra.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c
index dd9b3bcc41c3..7921428786aa 100644
--- a/drivers/pci/host/pci-tegra.c
+++ b/drivers/pci/host/pci-tegra.c
@@ -2188,17 +2188,8 @@ static const struct seq_operations tegra_pcie_ports_seq_ops = {
static int tegra_pcie_ports_open(struct inode *inode, struct file *file)
{
struct tegra_pcie *pcie = inode->i_private;
- struct seq_file *s;
- int err;
-
- err = seq_open(file, &tegra_pcie_ports_seq_ops);
- if (err)
- return err;
-
- s = file->private_data;
- s->private = pcie;
- return 0;
+ return seq_open_data(file, &tegra_pcie_ports_seq_ops, pcie);
}
static const struct file_operations tegra_pcie_ports_ops = {
--
2.15.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [RFC 1/5] seq_file: introduce seq_open_data helper
2018-03-01 23:37 [RFC 1/5] seq_file: introduce seq_open_data helper Rasmus Villemoes
` (3 preceding siblings ...)
2018-03-01 23:37 ` [RFC 5/5] PCI: tegra: use seq_open_data Rasmus Villemoes
@ 2018-03-01 23:44 ` Andreas Dilger
4 siblings, 0 replies; 10+ messages in thread
From: Andreas Dilger @ 2018-03-01 23:44 UTC (permalink / raw)
To: Rasmus Villemoes
Cc: Jonathan Corbet, Alexander Viro, Tony Luck, linux-ia64,
Michael Ellerman, linuxppc-dev, linux-doc, linux-kernel,
linux-fsdevel
[-- Attachment #1: Type: text/plain, Size: 4152 bytes --]
On Mar 1, 2018, at 4:37 PM, Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:
>
> There are quite a few callers of seq_open that could be simplified by
> setting the ->private member via the seq_open call instead of fetching
> file->private_data afterwards.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
> I've just included a few examples of possible users of this helper,
> there are many more similar cases. As a bonus, the first two fix
> potential NULL derefs (if one believes that seq_open can actually
> fail).
>
> seq_open_private would have been a better name, but that one is
> already taken...
>
> Documentation/filesystems/seq_file.txt | 9 +++++----
> fs/seq_file.c | 9 ++++++++-
> include/linux/seq_file.h | 1 +
> 3 files changed, 14 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/filesystems/seq_file.txt b/Documentation/filesystems/seq_file.txt
> index 9de4303201e1..68571b8275d8 100644
> --- a/Documentation/filesystems/seq_file.txt
> +++ b/Documentation/filesystems/seq_file.txt
> @@ -234,10 +234,11 @@ Here, the call to seq_open() takes the seq_operations structure we created
> before, and gets set up to iterate through the virtual file.
>
> On a successful open, seq_open() stores the struct seq_file pointer in
> -file->private_data. If you have an application where the same iterator can
> -be used for more than one file, you can store an arbitrary pointer in the
> -private field of the seq_file structure; that value can then be retrieved
> -by the iterator functions.
> +file->private_data. If you have an application where the same iterator
> +can be used for more than one file, you can store an arbitrary pointer
> +in the private field of the seq_file structure; that value can then be
> +retrieved by the iterator functions. Using the wrapper seq_open_data()
> +allows you to set the initial value for that field.
>
> There is also a wrapper function to seq_open() called seq_open_private(). It
> kmallocs a zero filled block of memory and stores a pointer to it in the
> diff --git a/fs/seq_file.c b/fs/seq_file.c
> index eea09f6d8830..f2145cb6e23d 100644
> --- a/fs/seq_file.c
> +++ b/fs/seq_file.c
> @@ -45,7 +45,7 @@ static void *seq_buf_alloc(unsigned long size)
> * Note: seq_open() will allocate a struct seq_file and store its
> * pointer in @file->private_data. This pointer should not be modified.
> */
> -int seq_open(struct file *file, const struct seq_operations *op)
> +int seq_open_data(struct file *file, const struct seq_operations *op, void *data)
> {
> struct seq_file *p;
>
> @@ -59,6 +59,7 @@ int seq_open(struct file *file, const struct seq_operations *op)
>
> mutex_init(&p->lock);
> p->op = op;
> + p->private = data;
>
> // No refcounting: the lifetime of 'p' is constrained
> // to the lifetime of the file.
> @@ -85,6 +86,12 @@ int seq_open(struct file *file, const struct seq_operations *op)
> }
> EXPORT_SYMBOL(seq_open);
>
> +int seq_open(struct file *file, const struct seq_operations *op)
> +{
> + return seq_open_data(file, op, NULL);
> +}
> +EXPORT_SYMBOL(seq_open_data);
This is a bit confusing. You export "seq_open" after seq_open_data(),
and export "seq_open_data" here after seq_open(). Not strictly a bug,
but could become one in the future.
Cheers, Andreas
> +
> static int traverse(struct seq_file *m, loff_t offset)
> {
> loff_t pos = 0, index;
> diff --git a/include/linux/seq_file.h b/include/linux/seq_file.h
> index ab437dd2e3b9..f5ff376fa62b 100644
> --- a/include/linux/seq_file.h
> +++ b/include/linux/seq_file.h
> @@ -107,6 +107,7 @@ void seq_pad(struct seq_file *m, char c);
>
> char *mangle_path(char *s, const char *p, const char *esc);
> int seq_open(struct file *, const struct seq_operations *);
> +int seq_open_data(struct file *, const struct seq_operations *, void *);
> ssize_t seq_read(struct file *, char __user *, size_t, loff_t *);
> loff_t seq_lseek(struct file *, loff_t, int);
> int seq_release(struct inode *, struct file *);
> --
> 2.15.1
>
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 873 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [RFC 2/5] ia64/sn/hwperf: use seq_open_data
2018-03-01 23:37 ` [RFC 2/5] ia64/sn/hwperf: use seq_open_data Rasmus Villemoes
@ 2018-03-02 8:22 ` Rasmus Villemoes
0 siblings, 0 replies; 10+ messages in thread
From: Rasmus Villemoes @ 2018-03-02 8:22 UTC (permalink / raw)
To: Tony Luck, Fenghua Yu; +Cc: Rasmus Villemoes, linux-ia64, linux-kernel
On 2 March 2018 at 00:37, Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:
> This code should check the return value of seq_open(); if it failed,
> file->private_data is NULL. But we can avoid the issue entirely and
> simplify the code by letting seq_open_data() set the ->private member
> to objbuf.
>
> if ((e = sn_hwperf_enum_objects(&nobj, &objbuf)) == 0) {
> - e = seq_open(file, &sn_topology_seq_ops);
> - seq = file->private_data;
> - seq->private = objbuf;
> + e = seq_open_data(file, &sn_topology_seq_ops, objbuf);
> }
Well, this turns a NULL deref into a resource leak; we still need to
add a check of the return value and vfree(objbuf) on failure.
Rasmus
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [RFC 5/5] PCI: tegra: use seq_open_data
2018-03-01 23:37 ` [RFC 5/5] PCI: tegra: use seq_open_data Rasmus Villemoes
@ 2018-03-02 10:42 ` Thierry Reding
2018-03-07 12:41 ` Lorenzo Pieralisi
0 siblings, 1 reply; 10+ messages in thread
From: Thierry Reding @ 2018-03-02 10:42 UTC (permalink / raw)
To: Rasmus Villemoes
Cc: Lorenzo Pieralisi, Bjorn Helgaas, Jonathan Hunter, linux-tegra,
linux-pci, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 522 bytes --]
On Fri, Mar 02, 2018 at 12:37:24AM +0100, Rasmus Villemoes wrote:
> Simplify the code slightly by having seq_open_data do the ->private
> assignment.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
> drivers/pci/host/pci-tegra.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
I had to go hunt for patch 1/5 to be able to tell if this is indeed
equivalent. It is, so:
Reviewed-by: Thierry Reding <treding@nvidia.com>
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [RFC 5/5] PCI: tegra: use seq_open_data
2018-03-02 10:42 ` Thierry Reding
@ 2018-03-07 12:41 ` Lorenzo Pieralisi
2018-04-25 9:38 ` Lorenzo Pieralisi
0 siblings, 1 reply; 10+ messages in thread
From: Lorenzo Pieralisi @ 2018-03-07 12:41 UTC (permalink / raw)
To: Thierry Reding
Cc: Rasmus Villemoes, Bjorn Helgaas, Jonathan Hunter, linux-tegra,
linux-pci, linux-kernel
On Fri, Mar 02, 2018 at 11:42:07AM +0100, Thierry Reding wrote:
> On Fri, Mar 02, 2018 at 12:37:24AM +0100, Rasmus Villemoes wrote:
> > Simplify the code slightly by having seq_open_data do the ->private
> > assignment.
> >
> > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> > ---
> > drivers/pci/host/pci-tegra.c | 11 +----------
> > 1 file changed, 1 insertion(+), 10 deletions(-)
>
> I had to go hunt for patch 1/5 to be able to tell if this is indeed
> equivalent. It is, so:
>
> Reviewed-by: Thierry Reding <treding@nvidia.com>
> Acked-by: Thierry Reding <treding@nvidia.com>
I can't apply this patch standalone so I assume this will go via
some other tree; I will drop it from the PCI patch queue, if I
should not please do let me know.
Thanks,
Lorenzo
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [RFC 5/5] PCI: tegra: use seq_open_data
2018-03-07 12:41 ` Lorenzo Pieralisi
@ 2018-04-25 9:38 ` Lorenzo Pieralisi
0 siblings, 0 replies; 10+ messages in thread
From: Lorenzo Pieralisi @ 2018-04-25 9:38 UTC (permalink / raw)
To: Thierry Reding
Cc: Rasmus Villemoes, Bjorn Helgaas, Jonathan Hunter, linux-tegra,
linux-pci, linux-kernel
On Wed, Mar 07, 2018 at 12:41:05PM +0000, Lorenzo Pieralisi wrote:
> On Fri, Mar 02, 2018 at 11:42:07AM +0100, Thierry Reding wrote:
> > On Fri, Mar 02, 2018 at 12:37:24AM +0100, Rasmus Villemoes wrote:
> > > Simplify the code slightly by having seq_open_data do the ->private
> > > assignment.
> > >
> > > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> > > ---
> > > drivers/pci/host/pci-tegra.c | 11 +----------
> > > 1 file changed, 1 insertion(+), 10 deletions(-)
> >
> > I had to go hunt for patch 1/5 to be able to tell if this is indeed
> > equivalent. It is, so:
> >
> > Reviewed-by: Thierry Reding <treding@nvidia.com>
> > Acked-by: Thierry Reding <treding@nvidia.com>
>
> I can't apply this patch standalone so I assume this will go via
> some other tree; I will drop it from the PCI patch queue, if I
> should not please do let me know.
I would kindly ask you some feedback - where are we with this patch
series ? Please let me know if should consider it for the pci tree
as per my request above.
Thanks,
Lorenzo
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-04-25 9:38 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-01 23:37 [RFC 1/5] seq_file: introduce seq_open_data helper Rasmus Villemoes
2018-03-01 23:37 ` [RFC 2/5] ia64/sn/hwperf: use seq_open_data Rasmus Villemoes
2018-03-02 8:22 ` Rasmus Villemoes
2018-03-01 23:37 ` [RFC 3/5] powerpc/pseries: use seq_open_data in hcall_inst_seq_open Rasmus Villemoes
2018-03-01 23:37 ` [RFC 4/5] fm10k: use seq_open_data() Rasmus Villemoes
2018-03-01 23:37 ` [RFC 5/5] PCI: tegra: use seq_open_data Rasmus Villemoes
2018-03-02 10:42 ` Thierry Reding
2018-03-07 12:41 ` Lorenzo Pieralisi
2018-04-25 9:38 ` Lorenzo Pieralisi
2018-03-01 23:44 ` [RFC 1/5] seq_file: introduce seq_open_data helper Andreas Dilger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).