From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: [RFC 3/5] powerpc/pseries: use seq_open_data in hcall_inst_seq_open
Date: Fri, 2 Mar 2018 00:37:22 +0100 [thread overview]
Message-ID: <20180301233724.20440-3-linux@rasmusvillemoes.dk> (raw)
In-Reply-To: <20180301233724.20440-1-linux@rasmusvillemoes.dk>
This code should check the return value of seq_open(); if it failed,
file->private_data is NULL. But we can avoid the issue entirely and
simplify the code by letting seq_open_data() set the ->private member.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
arch/powerpc/platforms/pseries/hvCall_inst.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/arch/powerpc/platforms/pseries/hvCall_inst.c b/arch/powerpc/platforms/pseries/hvCall_inst.c
index 89b7ce807e70..05990c9fe264 100644
--- a/arch/powerpc/platforms/pseries/hvCall_inst.c
+++ b/arch/powerpc/platforms/pseries/hvCall_inst.c
@@ -92,14 +92,7 @@ static const struct seq_operations hcall_inst_seq_ops = {
static int hcall_inst_seq_open(struct inode *inode, struct file *file)
{
- int rc;
- struct seq_file *seq;
-
- rc = seq_open(file, &hcall_inst_seq_ops);
- seq = file->private_data;
- seq->private = file_inode(file)->i_private;
-
- return rc;
+ return seq_open_data(file, &hcall_inst_seq_ops, file_inode(file)->i_private);
}
static const struct file_operations hcall_inst_seq_fops = {
--
2.15.1
next prev parent reply other threads:[~2018-03-01 23:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 23:37 [RFC 1/5] seq_file: introduce seq_open_data helper Rasmus Villemoes
2018-03-01 23:37 ` [RFC 2/5] ia64/sn/hwperf: use seq_open_data Rasmus Villemoes
2018-03-02 8:22 ` Rasmus Villemoes
2018-03-01 23:37 ` Rasmus Villemoes [this message]
2018-03-01 23:37 ` [RFC 4/5] fm10k: use seq_open_data() Rasmus Villemoes
2018-03-01 23:37 ` [RFC 5/5] PCI: tegra: use seq_open_data Rasmus Villemoes
2018-03-02 10:42 ` Thierry Reding
2018-03-07 12:41 ` Lorenzo Pieralisi
2018-04-25 9:38 ` Lorenzo Pieralisi
2018-03-01 23:44 ` [RFC 1/5] seq_file: introduce seq_open_data helper Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180301233724.20440-3-linux@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).