From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AG47ELsNA4n1XnizPf/N3Sx1hKb/K9jDo9gdv2K9xU/jSCGtPMOQxiDbpilDunpv+M9ydkuq2rtZ ARC-Seal: i=1; a=rsa-sha256; t=1519981464; cv=none; d=google.com; s=arc-20160816; b=K1ztu5W3jTeHR/7y+v5XreD6BG3P+4A7P8PjAx/EjK8DPQkeqMhdzdQYWvuQZP4XD3 jVlEZA919oH260bWuMwSe6YnUTA3+4XgY5pRTJCT82STdm1R3Cdmsyin4BCH+EY1xnqw BEUs8E03lsFnNLsJ575d4G3nR1tGfb44HOHk/+IvUtQ3rnUjkU30fFVwoToO88tuPapt qfKAXQSdq9vVs03OCZwdhPgD2fcJIaKT37SKt6XK8cvgkmm1IJvmCh3ywoUlOFcuu/wI oSueqBmB+763hl7/AfYMPpcrBTfpj3IGXYdecLBQxo2COBo1ZYsKvkPZiyvR1w+bmEEg 5Wzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=LmSUN//iUYnLzVtFRbwOXLI3s0b3VYSjp+Fyswds4SA=; b=ho6f0gYf3UrNK7YYP0Oz6bWQ7huMgmXWWww7pWLIW+rwwvOwl3GqKv/LMyklGk6iD1 L9K8LEMQ0t9F1xpazAqbX8LWnZ7TWmUC2oppgDmGQnFg6v9DhtWvJJvoPa3cCHOdPgNT RY+j4LZzvMkEq/yJsfpxyJV3sac0YUkMe780XD4mmvEi6wXm+1ZViTJvP7ebaeDc2tkE ntAg3NG7g5kS/47Ma5iJfzNYQHVLt40/ZWlfzE1938mmqBRsNOwEHUOqO7bm0eewRnOF jBV0MD6Kzuhwdektwb2f3WCo1OOwJuuLKcY/wz0WGAoPB/SPVKf2qzlfHDFehavTxjrc YGdw== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 83.175.124.243 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 83.175.124.243 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Guenter Roeck , Thomas Gleixner , Dmitry Torokhov , Joe Perches , Andy Shevchenko , Mika Westerberg , Sasha Levin Subject: [PATCH 4.14 064/115] genirq: Guard handle_bad_irq log messages Date: Fri, 2 Mar 2018 09:51:07 +0100 Message-Id: <20180302084506.465824039@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180302084503.856536800@linuxfoundation.org> References: <20180302084503.856536800@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1593815642898421195?= X-GMAIL-MSGID: =?utf-8?q?1593816084157243516?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Guenter Roeck [ Upstream commit 11bca0a83f83f6093d816295668e74ef24595944 ] An interrupt storm on a bad interrupt will cause the kernel log to be clogged. [ 60.089234] ->handle_irq(): ffffffffbe2f803f, [ 60.090455] 0xffffffffbf2af380 [ 60.090510] handle_bad_irq+0x0/0x2e5 [ 60.090522] ->irq_data.chip(): ffffffffbf2af380, [ 60.090553] IRQ_NOPROBE set [ 60.090584] ->handle_irq(): ffffffffbe2f803f, [ 60.090590] handle_bad_irq+0x0/0x2e5 [ 60.090596] ->irq_data.chip(): ffffffffbf2af380, [ 60.090602] 0xffffffffbf2af380 [ 60.090608] ->action(): (null) [ 60.090779] handle_bad_irq+0x0/0x2e5 This was seen when running an upstream kernel on Acer Chromebook R11. The system was unstable as result. Guard the log message with __printk_ratelimit to reduce the impact. This won't prevent the interrupt storm from happening, but at least the system remains stable. Signed-off-by: Guenter Roeck Signed-off-by: Thomas Gleixner Cc: Dmitry Torokhov Cc: Joe Perches Cc: Andy Shevchenko Cc: Mika Westerberg Link: https://bugzilla.kernel.org/show_bug.cgi?id=197953 Link: https://lkml.kernel.org/r/1512234784-21038-1-git-send-email-linux@roeck-us.net Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- kernel/irq/debug.h | 5 +++++ 1 file changed, 5 insertions(+) --- a/kernel/irq/debug.h +++ b/kernel/irq/debug.h @@ -12,6 +12,11 @@ static inline void print_irq_desc(unsigned int irq, struct irq_desc *desc) { + static DEFINE_RATELIMIT_STATE(ratelimit, 5 * HZ, 5); + + if (!__ratelimit(&ratelimit)) + return; + printk("irq %d, desc: %p, depth: %d, count: %d, unhandled: %d\n", irq, desc, desc->depth, desc->irq_count, desc->irqs_unhandled); printk("->handle_irq(): %p, ", desc->handle_irq);