From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Giulio Benetti <giulio.benetti@micronovasrl.com>
Cc: David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org>,
linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] drm/sun4i: add lvds mode_valid function
Date: Fri, 2 Mar 2018 15:37:36 +0100 [thread overview]
Message-ID: <20180302143736.kkxx54og2ppcmpzh@flea.lan> (raw)
In-Reply-To: <ebe7cfe5-e731-10cf-17cd-fe79bee0fdc4@micronovasrl.com>
[-- Attachment #1: Type: text/plain, Size: 953 bytes --]
On Fri, Mar 02, 2018 at 12:42:14PM +0100, Giulio Benetti wrote:
> Hi,
>
> Il 01/03/2018 10:57, Maxime Ripard ha scritto:
> > On Wed, Feb 28, 2018 at 06:53:52PM +0100, Giulio Benetti wrote:
> > > static struct drm_connector_helper_funcs sun4i_lvds_con_helper_funcs = {
> > > .get_modes = sun4i_lvds_get_modes,
> > > + .mode_valid = sun4i_lvds_mode_valid,
> > > };
> >
> > This should be on the encoder, not the connector.
>
> I've seen it is bound to connector in rgb and to encoder in hdmi.
> Is it correct rgb mode_valid under connector funcs?
> Otherwise I send a patch also for that one.
This would need to be fixed as well. Bridges attach to encoder, not
connectors, so if you ever have a bridge connected to the RGB output
(like on the A13-Olinuxino), mode_valid isn't called at the moment.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-03-02 14:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 17:53 [PATCH 1/2] drm/sun4i: increase lvds dclk max divisor Giulio Benetti
2018-02-28 17:53 ` [PATCH 2/2] drm/sun4i: add lvds mode_valid function Giulio Benetti
2018-03-01 9:57 ` Maxime Ripard
2018-03-02 11:42 ` Giulio Benetti
2018-03-02 14:37 ` Maxime Ripard [this message]
2018-03-02 16:50 ` Giulio Benetti
2018-03-01 9:56 ` [PATCH 1/2] drm/sun4i: increase lvds dclk max divisor Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180302143736.kkxx54og2ppcmpzh@flea.lan \
--to=maxime.ripard@bootlin.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=giulio.benetti@micronovasrl.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).