archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <>
To: "Tobin C. Harding" <>
Cc: Joe Perches <>, Andy Whitcroft <>,
Subject: Re: [PATCH v4 0/4] checkpatch: warn for use of %px
Date: Fri, 2 Mar 2018 15:46:04 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, 27 Feb 2018 14:04:04 +1100 "Tobin C. Harding" <> wrote:

> Hi Andrew,
> This is a resurrection of a patch set from last December.  There was
> some confusion (on my behalf) as to how patches to checkpatch got into
> the mainline.  Are you willing (and able) to take patches to
> Patch 1 through 3 are cleanup/refactoring patches.
> Patch 3 makes checkpatch emit a warning for usage of specifier %px.
> You may remember that the initial idea for this was from yourself, v1
> requested permission to use 'Suggested-by' tag.  I didn't get comment on
> that so v2 removed the tag.  (I'm not totally across when one should add
> the 'Suggested-by' tag.)
> v3 was an Epic fail, not testing final patch series before submission.
> Joe, I removed your 'Acked-by' tag because the patch you originally
> acked is different after rebasing.  I kept the Co-Developed-by tag
> because the code you wrote is still there I just had to massage it a bit
> since the check for deprecated %p[Ff] has been added since we did v2.

I prefer not to include tags which aren't listed in
Documentation/process/submitting-patches.rst, but I now see that some
bright spark added Co-Developed-by: to
Documentation/process/5.Posting.rst, so the two files are a)
duplicative and b) out of sync.

Co-Developed-by is a little more specific than signed-off-by, but not
usefully so, I suggest...

      parent reply	other threads:[~2018-03-02 23:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-27  3:04 [PATCH v4 0/4] checkpatch: warn for use of %px Tobin C. Harding
2018-02-27  3:04 ` [PATCH v4 1/4] checkpatch: add sub routine get_stat_real() Tobin C. Harding
2018-02-27  3:04 ` [PATCH v4 2/4] checkpatch: remove unused variable declarations Tobin C. Harding
2018-02-27  3:04 ` [PATCH v4 3/4] checkpatch: add sub routine get_stat_here() Tobin C. Harding
2018-02-27  3:04 ` [PATCH v4 4/4] checkpatch: warn for use of %px Tobin C. Harding
2018-03-02 23:46 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).