From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: "Sandy Huang" <hjc@rock-chips.com>, "Heiko Stübner" <heiko@sntech.de>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
linux-rockchip@lists.infradead.org,
Archit Taneja <architt@codeaurora.org>,
linux-kernel@vger.kernel.org,
Russell King <rmk+kernel@armlinux.org.uk>,
Neil Armstrong <narmstrong@baylibre.com>,
dri-devel@lists.freedesktop.org,
Jose Abreu <Jose.Abreu@synopsys.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jernej Skrabec <jernej.skrabec@siol.net>,
linux-arm-kernel@lists.infradead.org,
David Airlie <airlied@linux.ie>,
Jeffy Chen <jeffy.chen@rock-chips.com>,
kernel@collabora.com,
Enric Balletbo i Serra <enric.balletbo@collabora.com>
Subject: [PATCH v9 3/5] drm/rockchip: inno_hdmi: reorder clk_disable_unprepare call in unbind
Date: Fri, 2 Mar 2018 18:57:55 +0100 [thread overview]
Message-ID: <20180302175757.28192-4-enric.balletbo@collabora.com> (raw)
In-Reply-To: <20180302175757.28192-1-enric.balletbo@collabora.com>
From: Jeffy Chen <jeffy.chen@rock-chips.com>
In bind the clk_prepare_enable of the HDMI pclk is called before adding the
i2c_adapter. So it should be the other way around in unbind, first remove
the i2c_adapter and then call the clk_disable_unprepare.
Fixes: 412d4ae6b7a5 ("drm/rockchip: hdmi: add Innosilicon HDMI support")
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
Signed-off-by: Thierry Escande <thierry.escande@collabora.com>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
Changes in v9:
- Added new patch to reorder clk_disable_unprepare call in inno_hdmi
unbind()
drivers/gpu/drm/rockchip/inno_hdmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c
index a5c661930250..88d0774c97bd 100644
--- a/drivers/gpu/drm/rockchip/inno_hdmi.c
+++ b/drivers/gpu/drm/rockchip/inno_hdmi.c
@@ -906,8 +906,8 @@ static void inno_hdmi_unbind(struct device *dev, struct device *master,
hdmi->connector.funcs->destroy(&hdmi->connector);
hdmi->encoder.funcs->destroy(&hdmi->encoder);
- clk_disable_unprepare(hdmi->pclk);
i2c_put_adapter(hdmi->ddc);
+ clk_disable_unprepare(hdmi->pclk);
}
static const struct component_ops inno_hdmi_ops = {
--
2.16.1
next prev parent reply other threads:[~2018-03-02 17:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 17:57 [PATCH v9 0/5] rockchip: kevin: Enable edp display Enric Balletbo i Serra
2018-03-02 17:57 ` [PATCH v9 1/5] drm/rockchip: dw-mipi-dsi: Fix connector and encoder cleanup Enric Balletbo i Serra
2018-03-08 16:38 ` Heiko Stübner
2018-03-02 17:57 ` [PATCH v9 2/5] drm/rockchip: inno_hdmi: Fix error handling path Enric Balletbo i Serra
2018-03-08 16:38 ` Heiko Stübner
2018-03-02 17:57 ` Enric Balletbo i Serra [this message]
2018-03-08 16:38 ` [PATCH v9 3/5] drm/rockchip: inno_hdmi: reorder clk_disable_unprepare call in unbind Heiko Stübner
2018-03-02 17:57 ` [PATCH v9 4/5] drm/rockchip: dw_hdmi: Move HDMI vpll clock enable to bind() Enric Balletbo i Serra
2018-03-08 16:38 ` Heiko Stübner
2018-03-02 17:57 ` [PATCH v9 5/5] drm/bridge/synopsys: dw-hdmi: Add missing bridge detach Enric Balletbo i Serra
2018-03-02 21:49 ` Laurent Pinchart
2018-03-03 0:20 ` JeffyChen
2018-03-05 7:01 ` JeffyChen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180302175757.28192-4-enric.balletbo@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=Jose.Abreu@synopsys.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=hverkuil@xs4all.nl \
--cc=jeffy.chen@rock-chips.com \
--cc=jernej.skrabec@siol.net \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=narmstrong@baylibre.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).