* [PATCH] kernel/sched/cpudeadline.c: Fixed coding style error and warnings.
@ 2018-03-02 18:20 Mario Leinweber
2018-03-09 8:31 ` [tip:sched/core] sched/deadline: Clean up various coding style details tip-bot for Mario Leinweber
0 siblings, 1 reply; 2+ messages in thread
From: Mario Leinweber @ 2018-03-02 18:20 UTC (permalink / raw)
To: mingo; +Cc: peterz, linux-kernel, Mario Leinweber
- Fixed style error: Missing space before the open parenthesis
- Fixed style warnings: 2x Missing blank line after declaration
One warning left: else after return
(I don't feel comfortable fixing that without side effects)
Signed-off-by: Mario Leinweber <marioleinweber@web.de>
---
kernel/sched/cpudeadline.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/kernel/sched/cpudeadline.c b/kernel/sched/cpudeadline.c
index 8d9562d890d3..6a9defebbb54 100644
--- a/kernel/sched/cpudeadline.c
+++ b/kernel/sched/cpudeadline.c
@@ -42,8 +42,9 @@ static void cpudl_heapify_down(struct cpudl *cp, int idx)
return;
/* adapted from lib/prio_heap.c */
- while(1) {
+ while (1) {
u64 largest_dl;
+
l = left_child(idx);
r = right_child(idx);
largest = idx;
@@ -131,6 +132,7 @@ int cpudl_find(struct cpudl *cp, struct task_struct *p,
return 1;
} else {
int best_cpu = cpudl_maximum(cp);
+
WARN_ON(best_cpu != -1 && !cpu_present(best_cpu));
if (cpumask_test_cpu(best_cpu, &p->cpus_allowed) &&
@@ -205,6 +207,7 @@ void cpudl_set(struct cpudl *cp, int cpu, u64 dl)
old_idx = cp->elements[cpu].idx;
if (old_idx == IDX_INVALID) {
int new_idx = cp->size++;
+
cp->elements[new_idx].dl = dl;
cp->elements[new_idx].cpu = cpu;
cp->elements[cpu].idx = new_idx;
--
2.14.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:sched/core] sched/deadline: Clean up various coding style details
2018-03-02 18:20 [PATCH] kernel/sched/cpudeadline.c: Fixed coding style error and warnings Mario Leinweber
@ 2018-03-09 8:31 ` tip-bot for Mario Leinweber
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Mario Leinweber @ 2018-03-09 8:31 UTC (permalink / raw)
To: linux-tip-commits
Cc: peterz, mingo, linux-kernel, marioleinweber, hpa, efault, torvalds, tglx
Commit-ID: c2e513821d5df5e772287f6d0c23fd17b7c2bb1a
Gitweb: https://git.kernel.org/tip/c2e513821d5df5e772287f6d0c23fd17b7c2bb1a
Author: Mario Leinweber <marioleinweber@web.de>
AuthorDate: Fri, 2 Mar 2018 13:20:07 -0500
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Sat, 3 Mar 2018 15:50:20 +0100
sched/deadline: Clean up various coding style details
- Fixed style error: Missing space before the open parenthesis
- Fixed style warnings: 2x Missing blank line after declaration
One warning left: else after return
(I don't feel comfortable fixing that without side effects)
Signed-off-by: Mario Leinweber <marioleinweber@web.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Link: http://lkml.kernel.org/r/20180302182007.28691-1-marioleinweber@web.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/sched/cpudeadline.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/kernel/sched/cpudeadline.c b/kernel/sched/cpudeadline.c
index 8d9562d890d3..6a9defebbb54 100644
--- a/kernel/sched/cpudeadline.c
+++ b/kernel/sched/cpudeadline.c
@@ -42,8 +42,9 @@ static void cpudl_heapify_down(struct cpudl *cp, int idx)
return;
/* adapted from lib/prio_heap.c */
- while(1) {
+ while (1) {
u64 largest_dl;
+
l = left_child(idx);
r = right_child(idx);
largest = idx;
@@ -131,6 +132,7 @@ int cpudl_find(struct cpudl *cp, struct task_struct *p,
return 1;
} else {
int best_cpu = cpudl_maximum(cp);
+
WARN_ON(best_cpu != -1 && !cpu_present(best_cpu));
if (cpumask_test_cpu(best_cpu, &p->cpus_allowed) &&
@@ -205,6 +207,7 @@ void cpudl_set(struct cpudl *cp, int cpu, u64 dl)
old_idx = cp->elements[cpu].idx;
if (old_idx == IDX_INVALID) {
int new_idx = cp->size++;
+
cp->elements[new_idx].dl = dl;
cp->elements[new_idx].cpu = cpu;
cp->elements[cpu].idx = new_idx;
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-09 8:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-02 18:20 [PATCH] kernel/sched/cpudeadline.c: Fixed coding style error and warnings Mario Leinweber
2018-03-09 8:31 ` [tip:sched/core] sched/deadline: Clean up various coding style details tip-bot for Mario Leinweber
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).