From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934077AbeCBXHl (ORCPT ); Fri, 2 Mar 2018 18:07:41 -0500 Received: from verein.lst.de ([213.95.11.211]:38414 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932885AbeCBXHk (ORCPT ); Fri, 2 Mar 2018 18:07:40 -0500 Date: Sat, 3 Mar 2018 00:07:38 +0100 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , Christoph Hellwig , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, Laurence Oberman , Christoph Hellwig Subject: Re: [PATCH 2/5] genirq/affinity: move actual irq vector spread into one helper Message-ID: <20180302230738.GB31468@lst.de> References: <20180206121742.29336-1-ming.lei@redhat.com> <20180206121742.29336-3-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180206121742.29336-3-ming.lei@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 06, 2018 at 08:17:39PM +0800, Ming Lei wrote: > No functional change, just prepare for converting to 2-stage > irq vector spread. > > Cc: Thomas Gleixner > Cc: Christoph Hellwig > Signed-off-by: Ming Lei > --- > kernel/irq/affinity.c | 99 +++++++++++++++++++++++++++++---------------------- > 1 file changed, 56 insertions(+), 43 deletions(-) > > diff --git a/kernel/irq/affinity.c b/kernel/irq/affinity.c > index 4b1c4763212d..6af3f6727f63 100644 > --- a/kernel/irq/affinity.c > +++ b/kernel/irq/affinity.c > @@ -79,7 +79,7 @@ static void build_node_to_cpumask(cpumask_var_t *masks) > cpumask_set_cpu(cpu, masks[cpu_to_node(cpu)]); > } > > -static int get_nodes_in_cpumask(cpumask_var_t *node_to_cpumask, > +static int get_nodes_in_cpumask(const cpumask_var_t *node_to_cpumask, > const struct cpumask *mask, nodemask_t *nodemsk) Maybe you can split all your constifications into a separate prep patch? > +int irq_build_affinity_masks(int nvecs, const struct irq_affinity *affd, > + const cpumask_var_t *node_to_cpumask, > + const struct cpumask *cpu_mask, > + struct cpumask *nmsk, > + struct cpumask *masks) static? Otherwise looks fine: Reviewed-by: Christoph Hellwig