linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: devel@driverdev.osuosl.org, Lars-Peter Clausen <lars@metafoo.de>,
	linux-iio@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Hartmut Knaack <knaack.h@gmx.de>,
	daniel.baluta@nxp.com
Subject: Re: [PATCH v3] staging:iio:meter: Add name to function definition arguments
Date: Fri, 2 Mar 2018 20:38:47 -0300	[thread overview]
Message-ID: <20180302233847.xwvs6qnpzhyqd6oq@smtp.gmail.com> (raw)
In-Reply-To: <20180224134229.297acded@archlinux>

On 02/24, Jonathan Cameron wrote:
> On Wed, 21 Feb 2018 16:54:35 -0300
> Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> wrote:
> 
> > This patch fixes the checkpatch.pl warning:
> > 
> > drivers/staging/iio/meter/ade7854.h:157: WARNING: function definition
> > argument 'struct device *' should also have an identifier name...
> > 
> > This commit adds arguments names to the signature declared in the
> > ade7854_state struct. For consistency reason, It also renames all
> > arguments in function definitions.
> > 
> > Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
> 
> I would have slightly preferred this as two patches - one doing the
> renames and one introducing them where they were missing.
> 
> Applied to the togreg branch of iio.git and pushed out as testing
> for the autobuilders to play with it.

Hi Jonathan,

I looked at 'togreg' and 'testing' branch, and I did not find the patch.
Is it in another branch?

Thanks.

 
> Thanks,
> 
> Jonathan
> 
> > ---
> > Changes in v2:
> >   - Make the commit message clearer.
> >   - Use the same arguments name across signatures and definitions.
> > Changes in v3:
> >   - Fix name in the email header.
> > 
> >  drivers/staging/iio/meter/ade7754.c     |  6 +++---
> >  drivers/staging/iio/meter/ade7854-i2c.c | 28 ++++++++++++++--------------
> >  drivers/staging/iio/meter/ade7854-spi.c | 28 ++++++++++++++--------------
> >  drivers/staging/iio/meter/ade7854.h     | 28 ++++++++++++++--------------
> >  4 files changed, 45 insertions(+), 45 deletions(-)
> > 
> > diff --git a/drivers/staging/iio/meter/ade7754.c b/drivers/staging/iio/meter/ade7754.c
> > index 3a1e342d75fb..9aa067736715 100644
> > --- a/drivers/staging/iio/meter/ade7754.c
> > +++ b/drivers/staging/iio/meter/ade7754.c
> > @@ -132,7 +132,7 @@ static int ade7754_spi_write_reg_8(struct device *dev, u8 reg_address, u8 val)
> >  }
> >  
> >  static int ade7754_spi_write_reg_16(struct device *dev,
> > -				    u8 reg_address, u16 value)
> > +				    u8 reg_address, u16 val)
> >  {
> >  	int ret;
> >  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> > @@ -140,8 +140,8 @@ static int ade7754_spi_write_reg_16(struct device *dev,
> >  
> >  	mutex_lock(&st->buf_lock);
> >  	st->tx[0] = ADE7754_WRITE_REG(reg_address);
> > -	st->tx[1] = (value >> 8) & 0xFF;
> > -	st->tx[2] = value & 0xFF;
> > +	st->tx[1] = (val >> 8) & 0xFF;
> > +	st->tx[2] = val & 0xFF;
> >  	ret = spi_write(st->us, st->tx, 3);
> >  	mutex_unlock(&st->buf_lock);
> >  
> > diff --git a/drivers/staging/iio/meter/ade7854-i2c.c b/drivers/staging/iio/meter/ade7854-i2c.c
> > index 8106f8cceeab..317e4f0d8176 100644
> > --- a/drivers/staging/iio/meter/ade7854-i2c.c
> > +++ b/drivers/staging/iio/meter/ade7854-i2c.c
> > @@ -17,7 +17,7 @@
> >  
> >  static int ade7854_i2c_write_reg_8(struct device *dev,
> >  				   u16 reg_address,
> > -				   u8 value)
> > +				   u8 val)
> >  {
> >  	int ret;
> >  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> > @@ -26,7 +26,7 @@ static int ade7854_i2c_write_reg_8(struct device *dev,
> >  	mutex_lock(&st->buf_lock);
> >  	st->tx[0] = (reg_address >> 8) & 0xFF;
> >  	st->tx[1] = reg_address & 0xFF;
> > -	st->tx[2] = value;
> > +	st->tx[2] = val;
> >  
> >  	ret = i2c_master_send(st->i2c, st->tx, 3);
> >  	mutex_unlock(&st->buf_lock);
> > @@ -36,7 +36,7 @@ static int ade7854_i2c_write_reg_8(struct device *dev,
> >  
> >  static int ade7854_i2c_write_reg_16(struct device *dev,
> >  				    u16 reg_address,
> > -				    u16 value)
> > +				    u16 val)
> >  {
> >  	int ret;
> >  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> > @@ -45,8 +45,8 @@ static int ade7854_i2c_write_reg_16(struct device *dev,
> >  	mutex_lock(&st->buf_lock);
> >  	st->tx[0] = (reg_address >> 8) & 0xFF;
> >  	st->tx[1] = reg_address & 0xFF;
> > -	st->tx[2] = (value >> 8) & 0xFF;
> > -	st->tx[3] = value & 0xFF;
> > +	st->tx[2] = (val >> 8) & 0xFF;
> > +	st->tx[3] = val & 0xFF;
> >  
> >  	ret = i2c_master_send(st->i2c, st->tx, 4);
> >  	mutex_unlock(&st->buf_lock);
> > @@ -56,7 +56,7 @@ static int ade7854_i2c_write_reg_16(struct device *dev,
> >  
> >  static int ade7854_i2c_write_reg_24(struct device *dev,
> >  				    u16 reg_address,
> > -				    u32 value)
> > +				    u32 val)
> >  {
> >  	int ret;
> >  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> > @@ -65,9 +65,9 @@ static int ade7854_i2c_write_reg_24(struct device *dev,
> >  	mutex_lock(&st->buf_lock);
> >  	st->tx[0] = (reg_address >> 8) & 0xFF;
> >  	st->tx[1] = reg_address & 0xFF;
> > -	st->tx[2] = (value >> 16) & 0xFF;
> > -	st->tx[3] = (value >> 8) & 0xFF;
> > -	st->tx[4] = value & 0xFF;
> > +	st->tx[2] = (val >> 16) & 0xFF;
> > +	st->tx[3] = (val >> 8) & 0xFF;
> > +	st->tx[4] = val & 0xFF;
> >  
> >  	ret = i2c_master_send(st->i2c, st->tx, 5);
> >  	mutex_unlock(&st->buf_lock);
> > @@ -77,7 +77,7 @@ static int ade7854_i2c_write_reg_24(struct device *dev,
> >  
> >  static int ade7854_i2c_write_reg_32(struct device *dev,
> >  				    u16 reg_address,
> > -				    u32 value)
> > +				    u32 val)
> >  {
> >  	int ret;
> >  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> > @@ -86,10 +86,10 @@ static int ade7854_i2c_write_reg_32(struct device *dev,
> >  	mutex_lock(&st->buf_lock);
> >  	st->tx[0] = (reg_address >> 8) & 0xFF;
> >  	st->tx[1] = reg_address & 0xFF;
> > -	st->tx[2] = (value >> 24) & 0xFF;
> > -	st->tx[3] = (value >> 16) & 0xFF;
> > -	st->tx[4] = (value >> 8) & 0xFF;
> > -	st->tx[5] = value & 0xFF;
> > +	st->tx[2] = (val >> 24) & 0xFF;
> > +	st->tx[3] = (val >> 16) & 0xFF;
> > +	st->tx[4] = (val >> 8) & 0xFF;
> > +	st->tx[5] = val & 0xFF;
> >  
> >  	ret = i2c_master_send(st->i2c, st->tx, 6);
> >  	mutex_unlock(&st->buf_lock);
> > diff --git a/drivers/staging/iio/meter/ade7854-spi.c b/drivers/staging/iio/meter/ade7854-spi.c
> > index 63e200ffd1f2..72eddfec21f7 100644
> > --- a/drivers/staging/iio/meter/ade7854-spi.c
> > +++ b/drivers/staging/iio/meter/ade7854-spi.c
> > @@ -17,7 +17,7 @@
> >  
> >  static int ade7854_spi_write_reg_8(struct device *dev,
> >  		u16 reg_address,
> > -		u8 value)
> > +		u8 val)
> >  {
> >  	int ret;
> >  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> > @@ -32,7 +32,7 @@ static int ade7854_spi_write_reg_8(struct device *dev,
> >  	st->tx[0] = ADE7854_WRITE_REG;
> >  	st->tx[1] = (reg_address >> 8) & 0xFF;
> >  	st->tx[2] = reg_address & 0xFF;
> > -	st->tx[3] = value & 0xFF;
> > +	st->tx[3] = val & 0xFF;
> >  
> >  	ret = spi_sync_transfer(st->spi, &xfer, 1);
> >  	mutex_unlock(&st->buf_lock);
> > @@ -42,7 +42,7 @@ static int ade7854_spi_write_reg_8(struct device *dev,
> >  
> >  static int ade7854_spi_write_reg_16(struct device *dev,
> >  		u16 reg_address,
> > -		u16 value)
> > +		u16 val)
> >  {
> >  	int ret;
> >  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> > @@ -57,8 +57,8 @@ static int ade7854_spi_write_reg_16(struct device *dev,
> >  	st->tx[0] = ADE7854_WRITE_REG;
> >  	st->tx[1] = (reg_address >> 8) & 0xFF;
> >  	st->tx[2] = reg_address & 0xFF;
> > -	st->tx[3] = (value >> 8) & 0xFF;
> > -	st->tx[4] = value & 0xFF;
> > +	st->tx[3] = (val >> 8) & 0xFF;
> > +	st->tx[4] = val & 0xFF;
> >  
> >  	ret = spi_sync_transfer(st->spi, &xfer, 1);
> >  	mutex_unlock(&st->buf_lock);
> > @@ -68,7 +68,7 @@ static int ade7854_spi_write_reg_16(struct device *dev,
> >  
> >  static int ade7854_spi_write_reg_24(struct device *dev,
> >  		u16 reg_address,
> > -		u32 value)
> > +		u32 val)
> >  {
> >  	int ret;
> >  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> > @@ -83,9 +83,9 @@ static int ade7854_spi_write_reg_24(struct device *dev,
> >  	st->tx[0] = ADE7854_WRITE_REG;
> >  	st->tx[1] = (reg_address >> 8) & 0xFF;
> >  	st->tx[2] = reg_address & 0xFF;
> > -	st->tx[3] = (value >> 16) & 0xFF;
> > -	st->tx[4] = (value >> 8) & 0xFF;
> > -	st->tx[5] = value & 0xFF;
> > +	st->tx[3] = (val >> 16) & 0xFF;
> > +	st->tx[4] = (val >> 8) & 0xFF;
> > +	st->tx[5] = val & 0xFF;
> >  
> >  	ret = spi_sync_transfer(st->spi, &xfer, 1);
> >  	mutex_unlock(&st->buf_lock);
> > @@ -95,7 +95,7 @@ static int ade7854_spi_write_reg_24(struct device *dev,
> >  
> >  static int ade7854_spi_write_reg_32(struct device *dev,
> >  		u16 reg_address,
> > -		u32 value)
> > +		u32 val)
> >  {
> >  	int ret;
> >  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> > @@ -110,10 +110,10 @@ static int ade7854_spi_write_reg_32(struct device *dev,
> >  	st->tx[0] = ADE7854_WRITE_REG;
> >  	st->tx[1] = (reg_address >> 8) & 0xFF;
> >  	st->tx[2] = reg_address & 0xFF;
> > -	st->tx[3] = (value >> 24) & 0xFF;
> > -	st->tx[4] = (value >> 16) & 0xFF;
> > -	st->tx[5] = (value >> 8) & 0xFF;
> > -	st->tx[6] = value & 0xFF;
> > +	st->tx[3] = (val >> 24) & 0xFF;
> > +	st->tx[4] = (val >> 16) & 0xFF;
> > +	st->tx[5] = (val >> 8) & 0xFF;
> > +	st->tx[6] = val & 0xFF;
> >  
> >  	ret = spi_sync_transfer(st->spi, &xfer, 1);
> >  	mutex_unlock(&st->buf_lock);
> > diff --git a/drivers/staging/iio/meter/ade7854.h b/drivers/staging/iio/meter/ade7854.h
> > index c27247a7891a..a82d38224cbd 100644
> > --- a/drivers/staging/iio/meter/ade7854.h
> > +++ b/drivers/staging/iio/meter/ade7854.h
> > @@ -152,20 +152,20 @@
> >   * @rx:			receive buffer
> >   **/
> >  struct ade7854_state {
> > -	struct spi_device	*spi;
> > -	struct i2c_client	*i2c;
> > -	int			(*read_reg_8)(struct device *, u16, u8 *);
> > -	int			(*read_reg_16)(struct device *, u16, u16 *);
> > -	int			(*read_reg_24)(struct device *, u16, u32 *);
> > -	int			(*read_reg_32)(struct device *, u16, u32 *);
> > -	int			(*write_reg_8)(struct device *, u16, u8);
> > -	int			(*write_reg_16)(struct device *, u16, u16);
> > -	int			(*write_reg_24)(struct device *, u16, u32);
> > -	int			(*write_reg_32)(struct device *, u16, u32);
> > -	int			irq;
> > -	struct mutex		buf_lock;
> > -	u8			tx[ADE7854_MAX_TX] ____cacheline_aligned;
> > -	u8			rx[ADE7854_MAX_RX];
> > +	struct spi_device *spi;
> > +	struct i2c_client *i2c;
> > +	int (*read_reg_8)(struct device *dev, u16 reg_address, u8 *val);
> > +	int (*read_reg_16)(struct device *dev, u16 reg_address, u16 *val);
> > +	int (*read_reg_24)(struct device *dev, u16 reg_address, u32 *val);
> > +	int (*read_reg_32)(struct device *dev, u16 reg_address, u32 *val);
> > +	int (*write_reg_8)(struct device *dev, u16 reg_address, u8 val);
> > +	int (*write_reg_16)(struct device *dev, u16 reg_address, u16 val);
> > +	int (*write_reg_24)(struct device *dev, u16 reg_address, u32 val);
> > +	int (*write_reg_32)(struct device *dev, u16 reg_address, u32 val);
> > +	int irq;
> > +	struct mutex buf_lock;
> > +	u8 tx[ADE7854_MAX_TX] ____cacheline_aligned;
> > +	u8 rx[ADE7854_MAX_RX];
> >  
> >  };
> >  
> 
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  parent reply	other threads:[~2018-03-02 23:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-21 19:54 [PATCH v3] staging:iio:meter: Add name to function definition arguments Rodrigo Siqueira
2018-02-24 13:42 ` Jonathan Cameron
2018-02-24 13:52   ` Rodrigo Siqueira
2018-03-02 23:38   ` Rodrigo Siqueira [this message]
2018-03-03 15:06     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180302233847.xwvs6qnpzhyqd6oq@smtp.gmail.com \
    --to=rodrigosiqueiramelo@gmail.com \
    --cc=daniel.baluta@nxp.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).