From: Wolfram Sang <wsa@the-dreams.de>
To: Peter Rosin <peda@axentia.se>
Cc: Adrian Fiergolski <adrian.fiergolski@cern.ch>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] i2c: mux: pca954x: verify the device id of the pca984x chips
Date: Mon, 5 Mar 2018 17:29:26 +0100 [thread overview]
Message-ID: <20180305162926.qp5iy3uzojhwoz4m@ninjato> (raw)
In-Reply-To: <eb97edc2-3a16-2931-2f19-a80a5ab4d88b@axentia.se>
[-- Attachment #1: Type: text/plain, Size: 570 bytes --]
On Mon, Mar 05, 2018 at 04:55:56PM +0100, Peter Rosin wrote:
> On 2018-03-05 16:53, Wolfram Sang wrote:
> >
> >> @@ -97,59 +98,83 @@ static const struct chip_desc chips[] = {
> >> .nchans = 2,
> >> .enable = 0x4,
> >> .muxtype = pca954x_ismux,
> >> + .id = { .manufacturer_id = I2C_DEVICE_ID_NONE },
> >
> > Can't we just leave this empty and add a NULL pointer check below when
> > testing for the device id?
>
> Nope, it's not a pointer. I didn't think it should be, but maybe it
> should?
Nope, you are right. Thanks for the heads up!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-03-05 16:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 11:36 [RFC PATCH 0/2] check I2C device id for pca984x chips Peter Rosin
2018-01-22 11:36 ` [RFC PATCH 1/2] i2c: add i2c_get_device_id() to get the standard i2c device id Peter Rosin
2018-03-04 21:47 ` Peter Rosin
2018-03-05 15:51 ` Wolfram Sang
2018-03-05 16:06 ` Peter Rosin
2018-03-05 16:27 ` Wolfram Sang
2018-01-22 11:36 ` [RFC PATCH 2/2] i2c: mux: pca954x: verify the device id of the pca984x chips Peter Rosin
2018-03-05 15:53 ` Wolfram Sang
2018-03-05 15:55 ` Peter Rosin
2018-03-05 16:29 ` Wolfram Sang [this message]
2018-01-26 16:33 ` [RFC PATCH 0/2] check I2C device id for " Adrian Fiergolski
2018-01-27 8:37 ` Peter Rosin
2018-01-29 17:38 ` Adrian Fiergolski
2018-02-01 14:41 ` Peter Rosin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180305162926.qp5iy3uzojhwoz4m@ninjato \
--to=wsa@the-dreams.de \
--cc=adrian.fiergolski@cern.ch \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).