From: kbuild test robot <lkp@intel.com>
To: Florent Flament <contact@florentflament.com>
Cc: kbuild-all@01.org, andy.shevchenko@gmail.com, jikos@kernel.org,
benjamin.tissoires@redhat.com, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org,
Florent Flament <contact@florentflament.com>
Subject: Re: [PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard
Date: Mon, 5 Mar 2018 23:20:14 +0800 [thread overview]
Message-ID: <201803052207.4oLBFRZp%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180304221425.28611-2-contact@florentflament.com>
Hi Florent,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on hid/for-next]
[also build test WARNING on v4.16-rc4 next-20180305]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Florent-Flament/Logitech-K290-Add-driver-for-the-Logitech-K290-USB-keyboard/20180305-153311
base: https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-next
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> drivers/hid/hid-logitech-k290.c:54:46: sparse: Using plain integer as NULL pointer
vim +54 drivers/hid/hid-logitech-k290.c
45
46 static void k290_set_function(struct usb_device *dev, uint16_t function_mode)
47 {
48 int ret;
49
50 ret = usb_control_msg(dev, usb_sndctrlpipe(dev, 0),
51 K290_SET_FUNCTION_CMD,
52 USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
53 K290_SET_FUNCTION_VAL,
> 54 function_mode, 0, 0, USB_CTRL_SET_TIMEOUT);
55
56 if (ret < 0)
57 dev_err(&dev->dev,
58 "Failed to setup K290 function key, error %d\n", ret);
59 }
60
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
next prev parent reply other threads:[~2018-03-05 15:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-04 17:00 [PATCH] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard Florent Flament
2018-03-04 22:14 ` [PATCH v2 0/1] " Florent Flament
2018-03-04 22:14 ` [PATCH v2 1/1] HID: " Florent Flament
2018-03-05 9:31 ` Nestor Lopez Casado
2018-03-05 17:26 ` Benjamin Tissoires
2018-03-05 23:31 ` Florent Flament
2018-03-06 23:11 ` Florent Flament
2018-03-05 23:25 ` Florent Flament
2018-03-05 15:20 ` kbuild test robot [this message]
2018-03-05 21:11 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201803052207.4oLBFRZp%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=contact@florentflament.com \
--cc=jikos@kernel.org \
--cc=kbuild-all@01.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).