* [PATCH] RDMA/bnxt_re/qplib_sp: Use true and false for boolean values
@ 2018-03-05 23:36 Gustavo A. R. Silva
2018-03-06 5:56 ` Selvin Xavier
2018-03-06 23:36 ` Jason Gunthorpe
0 siblings, 2 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2018-03-05 23:36 UTC (permalink / raw)
To: Selvin Xavier, Devesh Sharma, Somnath Kotur,
Sriharsha Basavapatna, Doug Ledford, Jason Gunthorpe
Cc: linux-rdma, linux-kernel, Gustavo A. R. Silva
Assign true or false to boolean variables instead of an integer value.
This issue was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/infiniband/hw/bnxt_re/qplib_sp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/bnxt_re/qplib_sp.c b/drivers/infiniband/hw/bnxt_re/qplib_sp.c
index ee98e5e..2f3f32ea 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_sp.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_sp.c
@@ -154,7 +154,7 @@ int bnxt_qplib_get_dev_attr(struct bnxt_qplib_rcfw *rcfw,
attr->tqm_alloc_reqs[i * 4 + 3] = *(++tqm_alloc);
}
- attr->is_atomic = 0;
+ attr->is_atomic = false;
bail:
bnxt_qplib_rcfw_free_sbuf(rcfw, sbuf);
return rc;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] RDMA/bnxt_re/qplib_sp: Use true and false for boolean values
2018-03-05 23:36 [PATCH] RDMA/bnxt_re/qplib_sp: Use true and false for boolean values Gustavo A. R. Silva
@ 2018-03-06 5:56 ` Selvin Xavier
2018-03-06 23:36 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Selvin Xavier @ 2018-03-06 5:56 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Devesh Sharma, Somnath Kotur, Sriharsha Basavapatna,
Doug Ledford, Jason Gunthorpe, linux-rdma, linux-kernel,
Gustavo A. R. Silva
On Tue, Mar 6, 2018 at 5:06 AM, Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
> Assign true or false to boolean variables instead of an integer value.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Thanks.
Acked-by: Selvin Xavier <selvin.xavier@broadcom.com>
> ---
> drivers/infiniband/hw/bnxt_re/qplib_sp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/bnxt_re/qplib_sp.c b/drivers/infiniband/hw/bnxt_re/qplib_sp.c
> index ee98e5e..2f3f32ea 100644
> --- a/drivers/infiniband/hw/bnxt_re/qplib_sp.c
> +++ b/drivers/infiniband/hw/bnxt_re/qplib_sp.c
> @@ -154,7 +154,7 @@ int bnxt_qplib_get_dev_attr(struct bnxt_qplib_rcfw *rcfw,
> attr->tqm_alloc_reqs[i * 4 + 3] = *(++tqm_alloc);
> }
>
> - attr->is_atomic = 0;
> + attr->is_atomic = false;
> bail:
> bnxt_qplib_rcfw_free_sbuf(rcfw, sbuf);
> return rc;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RDMA/bnxt_re/qplib_sp: Use true and false for boolean values
2018-03-05 23:36 [PATCH] RDMA/bnxt_re/qplib_sp: Use true and false for boolean values Gustavo A. R. Silva
2018-03-06 5:56 ` Selvin Xavier
@ 2018-03-06 23:36 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2018-03-06 23:36 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Selvin Xavier, Devesh Sharma, Somnath Kotur,
Sriharsha Basavapatna, Doug Ledford, linux-rdma, linux-kernel,
Gustavo A. R. Silva
On Mon, Mar 05, 2018 at 05:36:47PM -0600, Gustavo A. R. Silva wrote:
> Assign true or false to boolean variables instead of an integer value.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Acked-by: Selvin Xavier <selvin.xavier@broadcom.com>
> ---
> drivers/infiniband/hw/bnxt_re/qplib_sp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-06 23:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-05 23:36 [PATCH] RDMA/bnxt_re/qplib_sp: Use true and false for boolean values Gustavo A. R. Silva
2018-03-06 5:56 ` Selvin Xavier
2018-03-06 23:36 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).