linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
	torvalds@linux-foundation.org, luto@amacapital.net,
	tglx@linutronix.de, viro@zeniv.linux.org.uk, ak@linux.intel.com,
	x86@kernel.org
Subject: Re: [PATCH] kernel/sys_ni: sort cond_syscall() entries
Date: Wed, 7 Mar 2018 09:26:12 +0100	[thread overview]
Message-ID: <20180307082612.tveaovxhhtvyu5dj@gmail.com> (raw)
In-Reply-To: <20180306185301.GA31061@light.dominikbrodowski.net>


* Dominik Brodowski <linux@dominikbrodowski.net> wrote:

> Shuffle the cond_syscall() entries in kernel/sys_ni.c around so that they
> are kept in the same order as in include/uapi/asm-generic/unistd.h. For
> better structuring, add the same comments as in that file, but keep a few
> additional comments and extend the commentary where it seems useful.
> 
> Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
> 
> diff --git a/kernel/sys_ni.c b/kernel/sys_ni.c
> index b5189762d275..44c65e4d2528 100644
> --- a/kernel/sys_ni.c
> +++ b/kernel/sys_ni.c
> @@ -17,245 +17,403 @@ asmlinkage long sys_ni_syscall(void)
>  	return -ENOSYS;
>  }
>  
> -cond_syscall(sys_quotactl);
> -cond_syscall(sys32_quotactl);
> -cond_syscall(sys_acct);
> +/*
> + * This list is kept in the same order as include/uapi/asm-generic/unistd.h.
> + * Architecture specific entries go below, then follow deprecated or obsolote
> + * system calls.

That's both a typo and wrong: 'follow' in this context means the exact opposite 
ordering.

I think this is more accurate:

    * Architecture specific entries go below, followed by deprecated or obsolete
    * system calls.

Thanks,

	Ingo

      parent reply	other threads:[~2018-03-07  8:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06 18:53 [PATCH] kernel/sys_ni: sort cond_syscall() entries Dominik Brodowski
2018-03-06 20:02 ` Randy Dunlap
2018-03-07  8:26 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180307082612.tveaovxhhtvyu5dj@gmail.com \
    --to=mingo@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=luto@amacapital.net \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).