From: Christoph Hellwig <hch@lst.de>
To: Jianchao Wang <jianchao.w.wang@oracle.com>
Cc: keith.busch@intel.com, axboe@fb.com, hch@lst.de,
sagi@grimberg.me, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 1/5] nvme: do atomically bit operations on nvme_request.flags
Date: Thu, 8 Mar 2018 08:57:36 +0100 [thread overview]
Message-ID: <20180308075736.GB16084@lst.de> (raw)
In-Reply-To: <1520489971-31174-2-git-send-email-jianchao.w.wang@oracle.com>
On Thu, Mar 08, 2018 at 02:19:27PM +0800, Jianchao Wang wrote:
> Do atomically bit operations on nvme_request.flags instead of
> regular read/write, then we could add other flags and set/clear
> them safely.
>
> Signed-off-by: Jianchao Wang <jianchao.w.wang@oracle.com>
Looks good, assuming an actual need for this shows up in the next
patches :)
Reviewed-by: Christoph Hellwig <hch@lst.de>
> diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
> index e80fd74..02097e8 100644
> --- a/drivers/nvme/host/nvme.h
> +++ b/drivers/nvme/host/nvme.h
> @@ -93,8 +93,8 @@ struct nvme_request {
> struct nvme_command *cmd;
> union nvme_result result;
> u8 retries;
> - u8 flags;
> u16 status;
> + unsigned long flags;
Please align the field name like the others, though.
next prev parent reply other threads:[~2018-03-08 7:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 6:19 PATCH V4 0/5 nvme-pci: fixes on nvme_timeout and nvme_dev_disable Jianchao Wang
2018-03-08 6:19 ` [PATCH V4 1/5] nvme: do atomically bit operations on nvme_request.flags Jianchao Wang
2018-03-08 7:57 ` Christoph Hellwig [this message]
2018-03-08 14:32 ` jianchao.wang
2018-03-08 6:19 ` [PATCH V4 2/5] nvme: add helper interface to flush in-flight requests Jianchao Wang
2018-03-08 13:11 ` Ming Lei
2018-03-08 14:44 ` jianchao.wang
2018-03-08 18:21 ` Sagi Grimberg
2018-03-09 1:59 ` jianchao.wang
2018-03-08 6:19 ` [PATCH V4 3/5] nvme-pci: avoid nvme_dev_disable to be invoked in nvme_timeout Jianchao Wang
2018-03-09 2:01 ` jianchao.wang
2018-03-13 13:29 ` jianchao.wang
2018-03-08 6:19 ` [PATCH V4 4/5] nvme-pci: discard wait timeout when delete cq/sq Jianchao Wang
2018-03-08 6:19 ` [PATCH V4 5/5] nvme-pci: add the timeout case for DELETEING state Jianchao Wang
2018-04-17 15:17 ` PATCH V4 0/5 nvme-pci: fixes on nvme_timeout and nvme_dev_disable Ming Lei
2018-04-18 14:24 ` jianchao.wang
2018-04-18 15:40 ` Ming Lei
2018-04-19 1:51 ` jianchao.wang
2018-04-19 2:27 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180308075736.GB16084@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=jianchao.w.wang@oracle.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).