From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
David Ahern <dsahern@gmail.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 9/9] perf c2c report: Add cacheline address count column
Date: Fri, 9 Mar 2018 14:34:41 -0300 [thread overview]
Message-ID: <20180309173441.GG8347@kernel.org> (raw)
In-Reply-To: <20180309162828.GA16890@krava>
Em Fri, Mar 09, 2018 at 05:28:28PM +0100, Jiri Olsa escreveu:
> On Fri, Mar 09, 2018 at 11:56:43AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Mar 09, 2018 at 11:14:42AM +0100, Jiri Olsa escreveu:
> > > Adding the 'PA cnt' column grouped under data cacheline address.
> > >
> > > It shows how many times the physical addresses changed for the
> > > hist entry. It does not show the number of different physical
> > > addresses for entry, because we don't store those. We only track
> > > the number of times we got different address than we currently
> > > hold, which is not expensive and gives similar info.
> > >
> > > $ perf c2c report --stdio
> > >
> > > # ----------- Cacheline ---------- Total Tot ----- LLC Load Hitm -----
> > > # Index Address Node PA cnt records Hitm Total Lcl Rmt
> > > # ..... .................. .... ...... ....... ....... ....... ....... .......
> > > #
> >
> >
> > I'm adding this to the docs, ack?
>
> nope.. those fields are c2c report only.. hardcoded
>
> I'm preparing a change to share c2c fields with the
> general report.. should come with other perf mem
> changes later
Ok, dropping that then
> jirka
>
> >
> > diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt
> > index cba16d8a970e..f4a280428e28 100644
> > --- a/tools/perf/Documentation/perf-report.txt
> > +++ b/tools/perf/Documentation/perf-report.txt
> > @@ -127,7 +127,7 @@ OPTIONS
> >
> > If the --mem-mode option is used, the following sort keys are also available
> > (incompatible with --branch-stack):
> > - symbol_daddr, dso_daddr, locked, tlb, mem, snoop, dcacheline.
> > + symbol_daddr, dso_daddr, locked, tlb, mem, snoop, dcacheline, dcacheline_count.
> >
> > - symbol_daddr: name of data symbol being executed on at the time of sample
> > - dso_daddr: name of library or module containing the data being executed
> > @@ -137,6 +137,7 @@ OPTIONS
> > - mem: type of memory access for the data at the time of the sample
> > - snoop: type of snoop (if any) for the data at the time of the sample
> > - dcacheline: the cacheline the data address is on at the time of the sample
> > + - dcacheline_count: the number of physical addresses sampled for this dcacheline
> > - phys_daddr: physical address of data being executed on at the time of sample
> >
> > And the default sort keys are changed to local_weight, mem, sym, dso,
next prev parent reply other threads:[~2018-03-09 17:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 10:14 [PATCHv2 0/9] perf tools: Assorted fixes Jiri Olsa
2018-03-09 10:14 ` [PATCH 1/9] perf tools: Free memory nodes data Jiri Olsa
2018-03-20 6:16 ` [tip:perf/core] perf env: " tip-bot for Jiri Olsa
2018-03-09 10:14 ` [PATCH 2/9] perf tools: Add mem2node object Jiri Olsa
2018-03-20 6:16 ` [tip:perf/core] " tip-bot for Jiri Olsa
2018-03-09 10:14 ` [PATCH 3/9] perf tests: Add mem2node object test Jiri Olsa
2018-03-20 6:17 ` [tip:perf/core] " tip-bot for Jiri Olsa
2018-03-09 10:14 ` [PATCH 4/9] perf c2c record: Record physical addresses in samples Jiri Olsa
2018-03-20 6:17 ` [tip:perf/core] " tip-bot for Jiri Olsa
2018-03-09 10:14 ` [PATCH 5/9] perf c2c report: Make calc_width work with struct c2c_hist_entry Jiri Olsa
2018-03-20 6:18 ` [tip:perf/core] " tip-bot for Jiri Olsa
2018-03-09 10:14 ` [PATCH 6/9] perf c2c report: Call calc_width only for displayed entries Jiri Olsa
2018-03-20 6:18 ` [tip:perf/core] perf c2c report: Call calc_width() " tip-bot for Jiri Olsa
2018-03-09 10:14 ` [PATCH 7/9] perf c2c report: Display node for cacheline address Jiri Olsa
2018-03-20 6:19 ` [tip:perf/core] " tip-bot for Jiri Olsa
2018-03-09 10:14 ` [PATCH 8/9] perf c2c report: Add span header over cacheline data Jiri Olsa
2018-03-20 6:19 ` [tip:perf/core] " tip-bot for Jiri Olsa
2018-03-09 10:14 ` [PATCH 9/9] perf c2c report: Add cacheline address count column Jiri Olsa
2018-03-09 14:56 ` Arnaldo Carvalho de Melo
2018-03-09 16:28 ` Jiri Olsa
2018-03-09 17:34 ` Arnaldo Carvalho de Melo [this message]
2018-03-20 6:20 ` [tip:perf/core] " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180309173441.GG8347@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=alexander.shishkin@linux.intel.com \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).