From: "Michał Kępień" <kernel@kempniu.pl>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Darren Hart <dvhart@infradead.org>,
Jonathan Woithe <jwoithe@just42.net>,
Andy Shevchenko <andy@infradead.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/7] platform/x86: fujitsu-laptop: Define constants for FUNC operations
Date: Sat, 10 Mar 2018 21:10:33 +0100 [thread overview]
Message-ID: <20180310201033.GA1173@kmp-mobile.hq.kempniu.pl> (raw)
In-Reply-To: <CAHp75VeOO8tBYWuVbm+2pFB0QeCsW7EoGhzPUY_7q+4bYKb4PQ@mail.gmail.com>
> > #define OP_GET_CAPS 0x0
> > #define OP_GET_EVENTS 0x1
> > #define OP_SET 0x1
> > #define OP_GET 0x2
> > #define OP_GET_EXT 0x4
> > #define OP_SET_EXT 0x5
>
> This one looks pretty much okay (logical pairs IIUC).
Sadly, no, these are not logical pairs. But maybe this is a reasonable
compromise anyway:
- OP_GET_CAPS seems to be consistent between different functions; it
is an operation which returns a bitfield describing given model's
"capabilities" in a certain area (LEDs, buttons, etc.),
- some functions expose only OP_GET_CAPS, OP_SET, and OP_GET,
- some functions expose only OP_GET_CAPS and OP_GET_EVENTS,
- some function expose OP_GET_CAPS, OP_GET_EVENTS, OP_GET_EXT and
OP_SET_EXT (but not OP_SET or OP_GET, probably because 0x1 is
already "taken" by OP_GET_EVENTS).
So, given the above, does this layout look reasonable to you (at least
somewhat) or would you rather see these constants shuffled around in
some other way?
--
Best regards,
Michał Kępień
next prev parent reply other threads:[~2018-03-10 20:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 21:15 [PATCH 0/7] fujitsu-laptop: Consistent naming of constants Michał Kępień
2018-02-27 21:15 ` [PATCH 1/7] platform/x86: fujitsu-laptop: Define constants for FUNC operations Michał Kępień
2018-02-28 16:08 ` Andy Shevchenko
2018-03-04 5:08 ` Jonathan Woithe
2018-03-04 19:44 ` Michał Kępień
2018-03-04 22:49 ` Jonathan Woithe
2018-03-05 23:16 ` Darren Hart
2018-03-06 9:37 ` Andy Shevchenko
2018-03-06 20:59 ` Michał Kępień
2018-03-07 12:34 ` Andy Shevchenko
2018-03-10 20:10 ` Michał Kępień [this message]
2018-03-12 9:27 ` Andy Shevchenko
2018-02-27 21:15 ` [PATCH 2/7] platform/x86: fujitsu-laptop: Define constants for FUNC features Michał Kępień
2018-02-27 21:15 ` [PATCH 3/7] platform/x86: fujitsu-laptop: Define constants for FUNC feature states Michał Kępień
2018-02-27 21:15 ` [PATCH 4/7] platform/x86: fujitsu-laptop: Rename constants defining hotkey codes Michał Kępień
2018-02-27 21:15 ` [PATCH 5/7] platform/x86: fujitsu-laptop: Tweak how constants are commented and laid out Michał Kępień
2018-02-27 21:15 ` [PATCH 6/7] platform/x86: fujitsu-laptop: More accurately represent the hotkey ring buffer managed by firmware Michał Kępień
2018-02-28 16:13 ` Andy Shevchenko
2018-03-04 19:57 ` Michał Kępień
2018-02-27 21:15 ` [PATCH 7/7] platform/x86: fujitsu-laptop: Introduce fext_*() helper functions Michał Kępień
2018-03-04 5:37 ` [PATCH 0/7] fujitsu-laptop: Consistent naming of constants Jonathan Woithe
2018-03-21 23:25 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180310201033.GA1173@kmp-mobile.hq.kempniu.pl \
--to=kernel@kempniu.pl \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=jwoithe@just42.net \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).