From: Baruch Siach <baruch@tkos.co.il>
To: Jacob Chen <jacob-chen@iotwrt.com>
Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, mchehab@kernel.org,
linux-media@vger.kernel.org, sakari.ailus@linux.intel.com,
hans.verkuil@cisco.com, tfiga@chromium.org,
zhengsq@rock-chips.com, laurent.pinchart@ideasonboard.com,
zyc@rock-chips.com, eddie.cai.linux@gmail.com,
jeffy.chen@rock-chips.com, devicetree@vger.kernel.org,
heiko@sntech.de, Jacob Chen <jacob2.chen@rock-chips.com>,
Jacob Chen <cc@rock-chips.com>,
Allon Huang <allon.huang@rock-chips.com>
Subject: Re: [PATCH v6 09/17] media: rkisp1: add rockchip isp1 core driver
Date: Sun, 11 Mar 2018 08:58:05 +0200 [thread overview]
Message-ID: <20180311065805.ezrjm4wn5mnorvgg@sapphire.tkos.co.il> (raw)
In-Reply-To: <20180308094807.9443-10-jacob-chen@iotwrt.com>
Hi Jacob,
On Thu, Mar 08, 2018 at 05:47:59PM +0800, Jacob Chen wrote:
> +config VIDEO_ROCKCHIP_ISP1
> + tristate "Rockchip Image Signal Processing v1 Unit driver"
> + depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
> + depends on ARCH_ROCKCHIP || COMPILE_TEST
> + select VIDEOBUF2_DMA_CONTIG
> + select V4L2_FWNODE
> + default n
> + ---help---
> + Support for ISP1 on the rockchip SoC.
I added 'select VIDEOBUF2_VMALLOC' here to fix link failure:
drivers/media/platform/rockchip/isp1/isp_stats.o: In function `rkisp1_register_stats_vdev':
isp_stats.c:(.text+0x80c): undefined reference to `vb2_vmalloc_memops'
isp_stats.c:(.text+0x814): undefined reference to `vb2_vmalloc_memops'
drivers/media/platform/rockchip/isp1/isp_params.o: In function `rkisp1_register_params_vdev':
isp_params.c:(.text+0x29b4): undefined reference to `vb2_vmalloc_memops'
isp_params.c:(.text+0x29bc): undefined reference to `vb2_vmalloc_memops'
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2018-03-11 6:58 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 9:47 [PATCH v6 00/17] Rockchip ISP1 Driver Jacob Chen
2018-03-08 9:47 ` [PATCH v6 01/17] media: videodev2.h, v4l2-ioctl: add rkisp1 meta buffer format Jacob Chen
2019-04-26 20:34 ` Nicolas Dufresne
2018-03-08 9:47 ` [PATCH v6 02/17] media: doc: add document for " Jacob Chen
2018-03-09 13:37 ` Hans Verkuil
2018-03-08 9:47 ` [PATCH v6 03/17] media: rkisp1: Add user space ABI definitions Jacob Chen
2018-03-09 13:34 ` Hans Verkuil
2018-04-24 4:28 ` Tomasz Figa
2018-03-08 9:47 ` [PATCH v6 04/17] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver Jacob Chen
2018-05-16 5:20 ` Laurent Pinchart
2018-05-16 14:39 ` Jacob Chen
2018-05-16 14:53 ` Jacob Chen
2018-05-16 15:15 ` Tomasz Figa
2019-03-10 17:49 ` Laurent Pinchart
2019-03-11 9:37 ` Tomasz Figa
2018-03-08 9:47 ` [PATCH v6 05/17] media: rkisp1: add Rockchip ISP1 subdev driver Jacob Chen
2018-03-09 13:57 ` Hans Verkuil
2018-05-03 9:09 ` Baruch Siach
2018-05-07 6:13 ` Tomasz Figa
2018-05-07 6:38 ` Baruch Siach
2018-05-07 6:41 ` Tomasz Figa
2018-05-24 11:30 ` Baruch Siach
2018-05-25 4:35 ` Tomasz Figa
2018-03-08 9:47 ` [PATCH v6 06/17] media: rkisp1: add ISP1 statistics driver Jacob Chen
2018-03-09 13:59 ` Hans Verkuil
2018-03-08 9:47 ` [PATCH v6 07/17] media: rkisp1: add ISP1 params driver Jacob Chen
2018-03-09 14:03 ` Hans Verkuil
2018-03-08 9:47 ` [PATCH v6 08/17] media: rkisp1: add capture device driver Jacob Chen
2018-03-09 14:07 ` Hans Verkuil
2018-04-17 8:44 ` Tomasz Figa
2018-03-08 9:47 ` [PATCH v6 09/17] media: rkisp1: add rockchip isp1 core driver Jacob Chen
2018-03-11 6:58 ` Baruch Siach [this message]
2018-05-16 8:08 ` Tomasz Figa
2018-03-08 9:48 ` [PATCH v6 10/17] dt-bindings: Document the Rockchip ISP1 bindings Jacob Chen
2018-03-08 9:48 ` [PATCH v6 11/17] dt-bindings: Document the Rockchip MIPI RX D-PHY bindings Jacob Chen
2018-03-08 9:48 ` [PATCH v6 12/17] ARM: dts: rockchip: add isp node for rk3288 Jacob Chen
2018-03-08 9:48 ` [PATCH v6 13/17] ARM: dts: rockchip: add rx0 mipi-phy " Jacob Chen
2018-03-08 9:48 ` [PATCH v6 14/17] ARM: dts: rockchip: Add dts mipi-dphy TXRX1 node " Jacob Chen
2018-03-08 9:48 ` [PATCH v6 15/17] arm64: dts: rockchip: add isp0 node for rk3399 Jacob Chen
2018-03-12 3:49 ` [PATCH v6-1,15/17] " Shunqian Zheng
2018-03-08 9:48 ` [PATCH v6 16/17] arm64: dts: rockchip: add rx0 mipi-phy " Jacob Chen
2018-03-08 9:48 ` [PATCH v6 17/17] MAINTAINERS: add entry for Rockchip ISP1 driver Jacob Chen
2018-03-08 10:29 ` [PATCH v6 00/17] Rockchip ISP1 Driver Tomasz Figa
2018-03-08 12:02 ` Baruch Siach
2018-03-09 0:53 ` Jacob Chen
2018-03-09 4:09 ` Baruch Siach
2018-03-09 5:05 ` Jacob Chen
2018-03-09 5:54 ` Baruch Siach
2018-03-09 14:12 ` Hans Verkuil
2018-03-12 3:37 ` [v6-1,15/17] arm64: dts: rockchip: add isp0 node for rk3399 Shunqian Zheng
2018-03-12 3:51 ` Shunqian Zheng
2018-09-03 13:07 ` [PATCH v6 00/17] Rockchip ISP1 Driver Hans Verkuil
2018-09-03 13:50 ` Tomasz Figa
2018-09-03 14:15 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180311065805.ezrjm4wn5mnorvgg@sapphire.tkos.co.il \
--to=baruch@tkos.co.il \
--cc=allon.huang@rock-chips.com \
--cc=cc@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=eddie.cai.linux@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=heiko@sntech.de \
--cc=jacob-chen@iotwrt.com \
--cc=jacob2.chen@rock-chips.com \
--cc=jeffy.chen@rock-chips.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
--cc=zhengsq@rock-chips.com \
--cc=zyc@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).