From: Dominik Brodowski <linux@dominikbrodowski.net>
To: Mario.Limonciello@dell.com, Darren Hart <dvhart@infradead.org>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Dell Inc. XPS 13 9343/0TM99H fails to boot v4.16-rc5
Date: Tue, 13 Mar 2018 07:43:34 +0100 [thread overview]
Message-ID: <20180313064334.GA1743@light.dominikbrodowski.net> (raw)
In-Reply-To: <20180313063213.GA20710@localhost.localdomain> <f78e97a8f037461ca7f5a60cb351e1af@ausx13mpc120.AMER.DELL.COM>
On Tue, Mar 13, 2018 at 06:12:04AM +0000, Mario.Limonciello@dell.com wrote:
> As long as they're ready before dell-laptop's initialization which uses
> late_initcall that should be fine.
>
> Am I correct to presume you're going to propose a patch you can test and
> confirm your hypothesis rather than Darren reverting my patch to bring
> them together?
Thanks for the input; a draft patch (which works fine on my system) is
attached below.
On Mon, Mar 12, 2018 at 11:32:13PM -0700, Darren Hart wrote:
> There is one other caveat, which you'll find documented in
> dell-laptop.c, namely that dell-laptop needs to init after dell-rbtn
> (I'm starting to appreciate the monolithic thinkpad-acpi driver).
>
> We need things to init in this order (items on the same line have no
> dependency):
>
> 1. DCDBAS, ACPI_WMI
> 2. DELL_SMBIOS, DELL_RBTN
> 3. DELL_LAPTOP, DELL_WMI
>
> Currently:
> subsys_initcall: ACPI_WMI, DELL_SMBIOS
> module_init: DCDBAS, DELL_WMI
> late_initcall: DELL_LAPTOP
>
> From a quick naive glance, it appears as though we might be able to
> address this as follows:
>
> subsys_initcall: DCDBAS, ACPI_WMI
> module_init: DELL_SMBIOS, DELL_RBTN
> late_initcall: DELL_LAPTOP, DELL_WMI
Hmmm. I do not yet understand why you propose to
a) advance the DCDBAS initialization to subsys_initcall, as only DELL_LAPTOP
(running as a late_initcall) requires it to be up and running, and
b) delay DELL_WMI to late_initcall, as it can safely be initialized as long
as ACPI_WMI is ready.
What do I miss?
Attached patch *seems* to work fine on my system.
Thanks,
Dominik
----
From: Dominik Brodowski <linux@dominikbrodowski.net>
Date: Tue, 13 Mar 2018 07:27:41 +0100
Subject: [PATCH] platform/x86: dell-smbios: wait for WMI initialization
If DELL_SMBIOS_WMI is enabled, the combined dell-smbios driver
needs to wait for ACPI_WMI to be initialized, which occurs at the
subsys_initcall() level. As the dell-smbios driver only needs to
be up and running by the time the dell-laptop module is initialized,
which occurs at the late_initcall() level, it is sufficient to
initialize the dell-smbios driver at the default device_initcall()
level.
Fixes: 25d47027e100 ("platform/x86: dell-smbios: Link all dell-smbios-* modules together")
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
diff --git a/drivers/platform/x86/dell-smbios-base.c b/drivers/platform/x86/dell-smbios-base.c
index 5bcf8a18f785..2485c80a9fdd 100644
--- a/drivers/platform/x86/dell-smbios-base.c
+++ b/drivers/platform/x86/dell-smbios-base.c
@@ -637,7 +637,7 @@ static void __exit dell_smbios_exit(void)
mutex_unlock(&smbios_mutex);
}
-subsys_initcall(dell_smbios_init);
+module_init(dell_smbios_init);
module_exit(dell_smbios_exit);
MODULE_AUTHOR("Matthew Garrett <mjg@redhat.com>");
next prev parent reply other threads:[~2018-03-13 6:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 18:53 Dell Inc. XPS 13 9343/0TM99H fails to boot v4.16-rc5 Dominik Brodowski
2018-03-12 20:23 ` Darren Hart
2018-03-12 22:07 ` Dominik Brodowski
2018-03-12 22:17 ` Linus Torvalds
2018-03-12 23:33 ` Darren Hart
2018-03-14 3:34 ` Darren Hart
2018-03-14 17:23 ` Linus Torvalds
2018-03-14 18:27 ` Darren Hart
2018-03-12 22:42 ` Mario.Limonciello
2018-03-13 5:51 ` Dominik Brodowski
2018-03-13 6:12 ` Mario.Limonciello
2018-03-13 6:43 ` Dominik Brodowski [this message]
2018-03-13 7:07 ` Mario.Limonciello
2018-03-13 21:42 ` Darren Hart
2018-03-14 1:28 ` Mario.Limonciello
2018-03-14 6:25 ` Dominik Brodowski
2018-03-13 6:32 ` Darren Hart
2018-03-12 20:36 [PATCH v2] platform/x86: dell-smbios: Resolve dependency error on ACPI_WMI Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313064334.GA1743@light.dominikbrodowski.net \
--to=linux@dominikbrodowski.net \
--cc=Mario.Limonciello@dell.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).