linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, eric.dumazet@gmail.com,
	xiyou.wangcong@gmail.com, fw@strlen.de
Subject: Re: [PATCH] proc: reject "." and ".." as filenames
Date: Tue, 13 Mar 2018 10:20:29 +0300	[thread overview]
Message-ID: <20180313072029.GA3176@avx2> (raw)
In-Reply-To: <20180312160018.5d4cb6917c84b2805ff32d1d@linux-foundation.org>

On Mon, Mar 12, 2018 at 04:00:18PM -0700, Andrew Morton wrote:
> -	if (qstr.len == 1 && fn[0] == '.') {
> -		WARN(1, "name '.'\n");
> +	if (WARN(qstr.len == 1 && fn[0] == '.', "name '.'\n"))
>  		return NULL;
> -	}

Oh, I hate this style of WARN.
For one thing it overlaps with comma operator.

      reply	other threads:[~2018-03-13  7:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-10  0:12 [PATCH] proc: reject "." and ".." as filenames Alexey Dobriyan
2018-03-10  0:19 ` Florian Westphal
2018-03-11 21:30 ` Pavel Machek
2018-03-11 21:35   ` Alexey Dobriyan
2018-03-11 21:41     ` Pavel Machek
2018-03-12 23:00 ` Andrew Morton
2018-03-13  7:20   ` Alexey Dobriyan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180313072029.GA3176@avx2 \
    --to=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=eric.dumazet@gmail.com \
    --cc=fw@strlen.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).