From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752692AbeCMToh (ORCPT ); Tue, 13 Mar 2018 15:44:37 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:47340 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751731AbeCMTof (ORCPT ); Tue, 13 Mar 2018 15:44:35 -0400 Date: Tue, 13 Mar 2018 12:44:34 -0700 From: Andrew Morton To: Stephen Rothwell Cc: Linux-Next Mailing List , Linux Kernel Mailing List , Kees Cook Subject: Re: linux-next: build failure after merge of the akpm-current tree Message-Id: <20180313124434.6f91b499b16080e766ab070f@linux-foundation.org> In-Reply-To: <20180313205119.6ca3c1aa@canb.auug.org.au> References: <20180313205119.6ca3c1aa@canb.auug.org.au> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Mar 2018 20:51:19 +1100 Stephen Rothwell wrote: > Hi Andrew, > > After merging the akpm-current tree, today's linux-next build (lots of > configuations) failed like this: > > (from the i386 defconfig build) > > In file included from include/linux/memcontrol.h:29:0, > from include/linux/swap.h:9, > from include/linux/suspend.h:5, > from arch/x86/kernel/asm-offsets.c:13: > include/linux/mm.h: In function 'get_mm_hiwater_rss': > include/linux/mm.h:1569:9: error: first argument to '__builtin_choose_expr' not a constant > include/linux/mm.h: In function 'get_mm_hiwater_vm': > include/linux/mm.h:1574:9: error: first argument to '__builtin_choose_expr' not a constant > > and many more ... > > Caused by commit > > c7c133f3d5ff ("kernel.h: skip single-eval logic on literals in min()/max()") > (and perhaps the folloups) > > Just a few of my builds actaully worked (including those I do > during the day). For complete logs see > http://kisskb.ellerman.id.au/kisskb/head/13556/ . > > I guess it could be compiler version specific. The failing ones are > done with gcc 4.6.3. My successful ones with gcc 7.3.1. Yes, this is being a pain in the butt. I guess we should drop the patches for now.