From: Thierry Reding <treding@nvidia.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
Mikko Perttunen <mperttunen@nvidia.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mailbox: tegra: relax TEGRA_HSP_MBOX Kconfig dependencies
Date: Tue, 13 Mar 2018 14:36:58 +0100 [thread overview]
Message-ID: <20180313133654.GA5374@ulmo> (raw)
In-Reply-To: <20180313121154.2715591-1-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]
On Tue, Mar 13, 2018 at 01:11:43PM +0100, Arnd Bergmann wrote:
> With the addition of the ARCH_TEGRA_194_SOC driver, we get a new Kconfig warning:
>
> warning: (ARCH_TEGRA_186_SOC && ARCH_TEGRA_194_SOC) selects TEGRA_HSP_MBOX which has unmet direct dependencies (MAILBOX && ARCH_TEGRA_186_SOC)
>
> It looks like the dependency is a bit too strict here, allowing the driver to
> be built for any Tegra chip avoids the problem.
>
> Fixes: 6f9ed07fde03 ("soc/tegra: Add Tegra194 SoC configuration option")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/mailbox/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
The HSP does not exist on any chip prior to Tegra186, which is what the
dependency reflects. However, I agree that there is little point for an
exact list of per-chip dependencies. We don't really support non-multi-
platform kernels anymore, or at least they don't get any testing, so
relaxing the dependency is fine with me.
Acked-by: Thierry Reding <treding@nvidia.com>
Thanks for fixing this,
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-03-13 13:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 12:11 [PATCH] mailbox: tegra: relax TEGRA_HSP_MBOX Kconfig dependencies Arnd Bergmann
2018-03-13 13:36 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313133654.GA5374@ulmo \
--to=treding@nvidia.com \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mperttunen@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).