From: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org, Graff Yang <graff.yang@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
linux-iio@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Hartmut Knaack <knaack.h@gmx.de>,
daniel.baluta@nxp.com, Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH 3/3] staging:iio:ad2s1210: Add write_raw to handle frequency
Date: Tue, 13 Mar 2018 11:33:24 -0300 [thread overview]
Message-ID: <20180313143324.vlusixa522rqaeoy@smtp.gmail.com> (raw)
In-Reply-To: <20180313135957.jfgxmq7gtcfgwdhe@mwanda>
On 03/13, Dan Carpenter wrote:
> On Tue, Mar 13, 2018 at 10:06:29AM -0300, Rodrigo Siqueira wrote:
> > On 03/13, Dan Carpenter wrote:
> >
> > > Ah... I see why you did the ERROR_MESSAGE define, to get around the 80
> > > character limit. Don't do that. Just go over 80 characters if you need
> > > to.
> > >
> > >
> > > > + "fclkin");
> > > > + ret = -EINVAL;
> > > > + goto error_ret;
> > >
> > > Direct returns are better. Less chance of bugs statistically.
> >
> > I totally get your point here, and I will fix it. However, just for
> > curiosity, why goto in this situation has more chance to generate bugs
> > statically?
> >
>
> This is a do-nothing goto. I normally consider do-nothing gotos and
> do-everything gotos basically cousins but in this case it's probably
> unfair since it already has other labels.
>
> Do-everything gotos are the most error prone way of doing error
> handling. I've reviewed a lot of static checker warnings and it really
> is true. I can't give you like a percent figure but do-everything error
> handling is a lot buggier than normal kernel style.
>
> This style of error handling is supposed to prevent returning without
> unlocking bugs. I once looked through the git log and counted missing
> unlock bugs and my conclusion was that it basically doesn't work for
> preventing bugs. The kind of people who just add random returns will do
> it regardless of the error handling style. There was even one driver
> that indented locked code like this:
>
> lock(); {
> blah blah blah;
> } unlock();
>
> When the driver was first submitted, it already had a missing unlock
> bug. I don't think style helps slow people down who are in a hurry.
>
> The other thing about do-nothing gotos is that you introduce the
> possibility of "forgot to set the error code" bugs which wasn't there
> before.
>
> regards,
> dan carpenter
>
>
>
>
>
>
>
>
> So actually "error_ret" seems like a pretty reasonable name for a
> do-nothing goto. I no
>
> I've looked at a lot of error handling and this kind of error handling
> is more error prone. The single exit path thing is supposed to prevent
> bugs like not dropping the lock on exit and I've looked through the logs
> and counted bugs to see if it works and I don't think it does. The
> people who forget to unlock will forget to unlock regardless of the
> error handling style.
>
Thanks for the great explanation :)
>
>
>
> > I will send a v2 with your recommendantions.
> > Thanks for the review and feedbacks :)
> >
> > > regards,
> > > dan carpenter
> > >
> > _______________________________________________
> > devel mailing list
> > devel@linuxdriverproject.org
> > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2018-03-13 14:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 18:21 [PATCH 0/3] staging:iio:ad2s1210: Rework read/write operation for fclkin and fexin Rodrigo Siqueira
2018-03-12 18:21 ` [PATCH 1/3] staging:iio:ad2s1210: Add channel for fclkin and fexcit Rodrigo Siqueira
2018-03-12 18:21 ` [PATCH 2/3] staging:iio:ad2s1210: Add frequency handler in read_raw Rodrigo Siqueira
2018-03-12 18:21 ` [PATCH 3/3] staging:iio:ad2s1210: Add write_raw to handle frequency Rodrigo Siqueira
2018-03-13 9:02 ` Dan Carpenter
2018-03-13 13:06 ` Rodrigo Siqueira
2018-03-13 13:59 ` Dan Carpenter
2018-03-13 14:33 ` Rodrigo Siqueira [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313143324.vlusixa522rqaeoy@smtp.gmail.com \
--to=rodrigosiqueiramelo@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=dan.carpenter@oracle.com \
--cc=daniel.baluta@nxp.com \
--cc=devel@driverdev.osuosl.org \
--cc=graff.yang@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).