From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Serge Semin <fancer.lancer@gmail.com>,
Guenter Roeck <linux@roeck-us.net>,
Kate Stewart <kstewart@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Alan Stern <stern@rowland.harvard.edu>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] usb: misc: supports Apple Carplay driver
Date: Wed, 14 Mar 2018 07:16:12 +0100 [thread overview]
Message-ID: <20180314061612.GA17263@kroah.com> (raw)
In-Reply-To: <1521007356-12306-2-git-send-email-chunfeng.yun@mediatek.com>
On Wed, Mar 14, 2018 at 02:02:36PM +0800, Chunfeng Yun wrote:
> The driver is used to support Apple carplay feature by a debugfs
> interface which can force the driver to send a USB Vendor Request
> of "Apple Device to Host Mode Switch" to switch Apple Device
> into host mode.
While I am all for crazy debugfs interfaces, I would _strongly_ suggest
not doing that here for the main API to the device. I know Android is
trying to prevent any new devices from even enabling debugfs, and as the
file system requires root permissions by default, you are forcing any
user of your new api to run as root, which is not a good idea either.
Given that all you are doing here is a single usb control message, why
does this even need to be a kernel driver at all? Can't you do the same
thing from userspace with a simple libusb/usbfs program? Or even a
simple script?
thanks,
greg k-h
next prev parent reply other threads:[~2018-03-14 7:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 6:02 [PATCH] Add Apple Carplay driver Chunfeng Yun
2018-03-14 6:02 ` [PATCH] usb: misc: supports " Chunfeng Yun
2018-03-14 6:16 ` Greg Kroah-Hartman [this message]
2018-03-14 8:20 ` Chunfeng Yun
2018-03-14 6:53 ` [PATCH] Add " Matthew Dharm
2018-03-14 8:18 ` Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180314061612.GA17263@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chunfeng.yun@mediatek.com \
--cc=fancer.lancer@gmail.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=stern@rowland.harvard.edu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).