From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752011AbeCNJHL (ORCPT ); Wed, 14 Mar 2018 05:07:11 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:50125 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751835AbeCNJHD (ORCPT ); Wed, 14 Mar 2018 05:07:03 -0400 X-Originating-IP: 2.224.242.101 Date: Wed, 14 Mar 2018 10:06:51 +0100 From: jacopo mondi To: Andrzej Hajda Cc: Jacopo Mondi , architt@codeaurora.org, Laurent.pinchart@ideasonboard.com, airlied@linux.ie, horms@verge.net.au, magnus.damm@gmail.com, geert@linux-m68k.org, niklas.soderlund@ragnatech.se, sergei.shtylyov@cogentembedded.com, robh+dt@kernel.org, mark.rutland@arm.com, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/3] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder Message-ID: <20180314090651.GA16424@w540> References: <1520951425-13843-1-git-send-email-jacopo+renesas@jmondi.org> <1520951425-13843-2-git-send-email-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="X1bOJ3K7DJ5YkBrT" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --X1bOJ3K7DJ5YkBrT Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Hi Andrzej, sorry for the mess :( On Wed, Mar 14, 2018 at 09:15:42AM +0100, Andrzej Hajda wrote: > On 13.03.2018 15:30, Jacopo Mondi wrote: > > Document Thine THC63LVD1024 LVDS decoder device tree bindings. > > > > Signed-off-by: Jacopo Mondi > > --- > > .../bindings/display/bridge/thine,thc63lvd1024.txt | 63 ++++++++++++++++++++++ > > 1 file changed, 63 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > > new file mode 100644 > > index 0000000..5b5afcd > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > > @@ -0,0 +1,63 @@ > > +Thine Electronics THC63LVD1024 LVDS decoder > > +------------------------------------------- > > + > > +The THC63LVD1024 is a dual link LVDS receiver designed to convert LVDS streams > > +to parallel data outputs. The chip supports single/dual input/output modes, > > +handling up to two two input LVDS stream and up to two digital CMOS/TTL outputs. > > + > > +Required properties: > > +- compatible: Shall be "thine,thc63lvd1024", > > + > > +Optional properties: > > +- vcc-supply: Power supply for TTL output and digital circuitry > > +- cvcc-supply: Power supply for TTL CLOCKOUT signal > > +- lvcc-supply: Power supply for LVDS inputs > > +- pvcc-supply: Power supply for PLL circuitry > > I wonder if it wouldn't be better to make them required (at least VCC) - > it is closer to reality. In cases like our Eagle board, where VCC is directly connected to the powering rail and not through a controllable regulator, I feel like making this mandatory requires more effort (not much, I agree, just a "fixed-regulator" more) with no additional benefits. But I understand your point, and I'm open to whatever fits better with the already existing DRM bridges bindings > > > +- pwnd-gpios: Power down GPIO signal. Active low. > > As I said before, specs[1] says about "/PDWN" pin. Is it your typo, or > different docs? I didn't notice the typo in first review, and I thought you were referring to the initial '/' which I found weird to be part of the gpio name... Then I now realized I badly typed in "pwnd" in place of "pwdn", which is not even correct because it has to be "pdwn"... Sorry about this mess, I will fix in v4 > Moreover there are already bindings for THC63LVDM83D with the same > dichotomy [2]. Seems like this is 'wrong' as well.. The chip manual says the pin is named "pdwn" here too.. > > Out of curiosity I have googled for "pwnd pin" and it looks like some > vendors use this form. > For me both forms are quite misleading: power down signal, active low, > why they couldn't call it just 'enable, active high'. > It's not much the actual physical active level that bugs me, but the fact that the GPIO name defines if it has to be set to "active" or "inactive" logical state in enable/disable routines that I don't like.. > [1]: http://www.thine.co.jp/files/topics/179_ext_12_0.pdf > [2]: > https://elixir.bootlin.com/linux/v4.16-rc5/source/Documentation/devicetree/bindings/display/bridge/thine,thc63lvdm83d.txt > > > +- oe-gpios: Output enable GPIO signal. Active high. > > + > > +The THC63LVD1024 video port connections are modeled according > > +to OF graph bindings specified by Documentation/devicetree/bindings/graph.txt > > + > > +Required video port nodes: > > +- Port@0: First LVDS input port > > +- Port@2: First digital CMOS/TTL parallel output > > + > > +Optional video port nodes: > > +- Port@1: Second LVDS input port > > +- Port@3: Second digital CMOS/TTL parallel output > > + > > +Example: > > +-------- > > + > > + thc63lvd1024: lvds-decoder { > > + compatible = "thine,thc63lvd1024"; > > + > > + vcc-supply = <®_lvds_vcc>; > > + lvcc-supply = <®_lvds_lvcc>; > > + > > + pwdn-gpio = <&gpio4 15 GPIO_ACTIVE_LOW>; > And here another variation :), should be pdwn-gpios. Next time it will be "pndw".. Is there a prize if I do insert all permutations of the same name in a single bindings document? :) Will fix this shortly. Thanks j --X1bOJ3K7DJ5YkBrT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJaqOYqAAoJEHI0Bo8WoVY8GP4QAKDluTlTAksCMNmVXBO81W3g bBog7F/RM5yEi4OFBqtutwxB8v48kNQufDC/Twm/JPo1hf1H6vSvEwTr+52PK/Nd nnLpd5eJ0kvklDPQ1vAKt45hvYl6zm933VmxBmncBrUgHnjUqcbhovMUh7+NGDHB KIJgqAbeTpSdkVwg5j7vHXrVBpW5i2kmIXKYPwIfhcqh3eDbXbwauTSSjx9N3PSk x5FVke3zQLDYKpsLDLlYJIhKPGDCN/xA/tB6Uu7wdccwTYg/9auwvU+et5JIe8U6 NIURFNOWuRToSZc3MmG6j1NNaAN04TTGtWvr4H1UAeYpBq+gdOp7h1de3pzDlsvF nsnrYzwYIYpzT0zuOziw7V3bd9cEH7wbPyTSYrddZeow7yOnMSs1A1T5Fuennmie /3dG+z/2gbDe6m+NIgHifHjN9dUfoqwXr0WcqpsKHIKutrfN8ghRstj+Jy+PlGBl BN/NvpRT3RhfFF/5h+Ni8hdXmEWTzOliPdRRMBszOqjWviQ9Qet2MJM8OPt1ndZl 9sIlkUW3wKf20XikQ2BL/48XRzHW7ExY8q4YzsqRNyykLRjmAc3+0aZlR6Ydq8ii AM9ZCVVF/Zo8I0w5Zw9wXWWFdj3oBhI7PEdBlZBpjq9HKOZcfk2I6wAPJjdPRfSR a9OCv9YCR+2cnk/1y3OH =Mghv -----END PGP SIGNATURE----- --X1bOJ3K7DJ5YkBrT--