linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: Andreas Noever <andreas.noever@gmail.com>,
	Michael Jamet <michael.jamet@intel.com>,
	Yehezkel Bernat <yehezkel.bernat@intel.com>,
	Jordan Glover <Golden_Miller83@protonmail.ch>,
	Kai-Heng Feng <kai.heng.feng@canonical.com>
Subject: Re: [PATCH] thunderbolt: Prevent crash when ICM firmware is not running
Date: Wed, 14 Mar 2018 13:28:24 +0200	[thread overview]
Message-ID: <20180314112824.GZ2703@lahna.fi.intel.com> (raw)
In-Reply-To: <20180309104434.64412-1-mika.westerberg@linux.intel.com>

On Fri, Mar 09, 2018 at 01:44:34PM +0300, Mika Westerberg wrote:
> On Lenovo ThinkPad Yoga 370 (and possibly some other Lenovo models as
> well) the Thunderbolt host controller sometimes comes up in such way
> that the ICM firmware is not running properly. This is most likely an
> issue in BIOS/firmware but as side-effect driver crashes the kernel due
> to NULL pointer dereference:
> 
>   BUG: unable to handle kernel NULL pointer dereference at 0000000000000980
>   IP: pci_write_config_dword+0x5/0x20
>   Call Trace:
>    pcie2cio_write+0x3b/0x70 [thunderbolt]
>    icm_driver_ready+0x168/0x260 [thunderbolt]
>    ? tb_ctl_start+0x50/0x70 [thunderbolt]
>    tb_domain_add+0x73/0xf0 [thunderbolt]
>    nhi_probe+0x182/0x300 [thunderbolt]
>    local_pci_probe+0x42/0xa0
>    ? pci_match_device+0xd9/0x100
>    pci_device_probe+0x146/0x1b0
>    driver_probe_device+0x315/0x480
>    ...
> 
> Instead of crashing update the driver to bail out gracefully if we
> encounter such situation.
> 
> Fixes: f67cf491175a ("thunderbolt: Add support for Internal Connection Manager (ICM)")
> Reported-by: Jordan Glover <Golden_Miller83@protonmail.ch>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Cc: stable@vger.kernel.org

Applied to thunderbolt.git/next.

      reply	other threads:[~2018-03-14 11:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-09 10:44 [PATCH] thunderbolt: Prevent crash when ICM firmware is not running Mika Westerberg
2018-03-14 11:28 ` Mika Westerberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180314112824.GZ2703@lahna.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=Golden_Miller83@protonmail.ch \
    --cc=andreas.noever@gmail.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.jamet@intel.com \
    --cc=yehezkel.bernat@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).