From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751769AbeCONfd (ORCPT ); Thu, 15 Mar 2018 09:35:33 -0400 Received: from verein.lst.de ([213.95.11.211]:41171 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751357AbeCONfc (ORCPT ); Thu, 15 Mar 2018 09:35:32 -0400 Date: Thu, 15 Mar 2018 14:35:30 +0100 From: Christoph Hellwig To: Thomas Gleixner Cc: Christoph Hellwig , x86@kernel.org, Konrad Rzeszutek Wilk , Tom Lendacky , David Woodhouse , Muli Ben-Yehuda , Jon Mason , Joerg Roedel , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/14] x86: use generic swiotlb_ops Message-ID: <20180315133530.GA17956@lst.de> References: <20180314175213.20256-1-hch@lst.de> <20180314175213.20256-5-hch@lst.de> <20180315115426.GB16210@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 15, 2018 at 01:52:14PM +0100, Thomas Gleixner wrote: > Yeah, I know that the standard defines it, but that doesn't mean it makes > sense. At least not to me. It makes sense in that it logically is a boolean but we only want to allocate 1 bit for it, unlike the normal ABI allocations of at least a byte. Either way, tell me what you want it changed to, and I'll do it.