From: Matthew Wilcox <willy@infradead.org>
To: Joe Perches <joe@perches.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
David Howells <dhowells@redhat.com>,
Arnd Bergmann <arnd@arndb.de>,
Linux-Arch <linux-arch@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-doc@vger.kernel.org, linux-block@vger.kernel.org,
linux-ide@vger.kernel.org, linux-input@vger.kernel.org,
netdev <netdev@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
Linux PWM List <linux-pwm@vger.kernel.org>,
linux-rtc@vger.kernel.org, linux-spi <linux-spi@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
Linux Watchdog Mailing List <linux-watchdog@vger.kernel.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>
Subject: Re: rfc: remove print_vma_addr ? (was Re: [PATCH 00/16] remove eight obsolete architectures)
Date: Thu, 15 Mar 2018 10:08:30 -0700 [thread overview]
Message-ID: <20180315170830.GA17574@bombadil.infradead.org> (raw)
In-Reply-To: <1521133006.22221.35.camel@perches.com>
On Thu, Mar 15, 2018 at 09:56:46AM -0700, Joe Perches wrote:
> I have a patchset that creates a vsprintf extension for
> print_vma_addr and removes all the uses similar to the
> print_symbol() removal.
>
> This now avoids any possible printk interleaving.
>
> Unfortunately, without some #ifdef in vsprintf, which
> I would like to avoid, it increases the nommu kernel
> size by ~500 bytes.
>
> Anyone think this is acceptable?
>
> Here's the overall patch, but I have it as a series
> ---
> Documentation/core-api/printk-formats.rst | 9 +++++
> arch/arm64/kernel/traps.c | 13 +++----
> arch/mips/mm/fault.c | 16 ++++-----
> arch/parisc/mm/fault.c | 15 ++++----
> arch/riscv/kernel/traps.c | 11 +++---
> arch/s390/mm/fault.c | 7 ++--
> arch/sparc/mm/fault_32.c | 8 ++---
> arch/sparc/mm/fault_64.c | 8 ++---
> arch/tile/kernel/signal.c | 9 ++---
> arch/um/kernel/trap.c | 13 +++----
> arch/x86/kernel/signal.c | 10 ++----
> arch/x86/kernel/traps.c | 18 ++++------
> arch/x86/mm/fault.c | 12 +++----
> include/linux/mm.h | 1 -
> lib/vsprintf.c | 58 ++++++++++++++++++++++++++-----
> mm/memory.c | 33 ------------------
> 16 files changed, 112 insertions(+), 129 deletions(-)
This doesn't feel like a huge win since it's only called ~once per
architecture. I'd be more excited if it made the printing of the whole
thing standardised; eg we have a print_fault() function in mm/memory.c
which takes a suitable set of arguments.
next prev parent reply other threads:[~2018-03-15 17:08 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 14:34 [PATCH 00/16] remove eight obsolete architectures Arnd Bergmann
2018-03-14 14:36 ` [PATCH 01/16] mn10300: Remove the architecture Arnd Bergmann
2018-03-14 14:36 ` [PATCH 02/16] arch: remove frv port Arnd Bergmann
2018-03-14 14:36 ` [PATCH 03/16] arch: remove m32r port Arnd Bergmann
2018-03-14 14:36 ` [PATCH 04/16] arch: remove score port Arnd Bergmann
2018-03-14 14:36 ` [PATCH 05/16] arch: remove blackfin port Arnd Bergmann
2018-03-14 16:51 ` [PATCH] scripts/checkstack.pl: remove blackfin support Tobias Klauser
2018-03-14 17:04 ` Arnd Bergmann
2018-03-15 22:24 ` [PATCH 05/16] arch: remove blackfin port Bryan Wu
2018-03-14 14:36 ` [PATCH 06/16] arch: remove tile port Arnd Bergmann
2018-03-16 1:23 ` Chris Metcalf
2018-03-16 8:12 ` Arnd Bergmann
2018-03-14 14:36 ` [PATCH 07/16] CRIS: Drop support for the CRIS port Arnd Bergmann
2018-03-14 14:39 ` [PATCH 10/16] mm: remove obsolete alloc_remap() Arnd Bergmann
2018-03-14 14:50 ` Pavel Tatashin
2018-03-14 14:56 ` Arnd Bergmann
2018-03-14 14:59 ` Pavel Tatashin
2018-03-14 14:43 ` [PATCH 11/16] treewide: simplify Kconfig dependencies for removed archs Arnd Bergmann
2018-03-14 14:43 ` [PATCH 12/16] asm-generic: siginfo: remove obsolete #ifdefs Arnd Bergmann
2018-03-14 16:38 ` Eric W. Biederman
2018-03-14 20:31 ` Dominik Brodowski
2018-03-14 20:40 ` Arnd Bergmann
2018-03-14 20:45 ` Dominik Brodowski
2018-03-15 10:06 ` Eric W. Biederman
2018-03-15 10:48 ` Arnd Bergmann
2018-03-15 11:37 ` Eric W. Biederman
2018-03-15 12:50 ` Arnd Bergmann
2018-03-15 18:07 ` Eric W. Biederman
2018-03-15 12:54 ` [PATCH 11/16] treewide: simplify Kconfig dependencies for removed archs Kalle Valo
2018-03-19 23:06 ` Alexandre Belloni
2018-03-14 14:51 ` [PATCH 13/16] Documentation: arch-support: remove obsolete architectures Arnd Bergmann
2018-03-14 14:52 ` [PATCH 15/16] recordmcount.pl: drop blackin and tile support Arnd Bergmann
2018-03-15 20:42 ` Steven Rostedt
2018-03-14 14:53 ` [PATCH 16/16] ktest: remove obsolete architectures Arnd Bergmann
2018-03-15 20:46 ` Steven Rostedt
2018-03-14 20:38 ` [PATCH 14/16] asm-generic: clean up asm/unistd.h Arnd Bergmann
2018-03-15 9:42 ` [PATCH 00/16] remove eight obsolete architectures David Howells
2018-03-15 9:48 ` Geert Uytterhoeven
2018-03-15 16:56 ` rfc: remove print_vma_addr ? (was Re: [PATCH 00/16] remove eight obsolete architectures) Joe Perches
2018-03-15 17:08 ` Matthew Wilcox [this message]
2018-03-15 17:13 ` Joe Perches
2018-03-15 9:56 ` [PATCH 00/16] remove eight obsolete architectures Arnd Bergmann
2018-03-16 4:50 ` afzal mohammed
2018-03-15 9:59 ` Hannes Reinecke
2018-03-15 10:42 ` Arnd Bergmann
2018-03-15 14:17 ` Christoph Hellwig
2018-03-20 17:11 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180315170830.GA17574@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=arnd@arndb.de \
--cc=dhowells@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=joe@perches.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).