From: Viresh Kumar <viresh.kumar@linaro.org>
To: Rajendra Nayak <rnayak@codeaurora.org>
Cc: sboyd@kernel.org, andy.gross@linaro.org, ulf.hansson@linaro.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH 6/7] mmc: sdhci-msm: Adapt the driver to use OPPs to set clocks/performance state
Date: Fri, 16 Mar 2018 10:11:32 +0530 [thread overview]
Message-ID: <20180316044132.GS15832@vireshk-i7> (raw)
In-Reply-To: <20180316040824.21472-7-rnayak@codeaurora.org>
On 16-03-18, 09:38, Rajendra Nayak wrote:
> @@ -1540,6 +1571,9 @@ static int sdhci_msm_probe(struct platform_device *pdev)
> pm_runtime_disable(&pdev->dev);
> pm_runtime_set_suspended(&pdev->dev);
> pm_runtime_put_noidle(&pdev->dev);
> + dev_pm_opp_of_remove_table(&pdev->dev);
You can't do this if there is no OPP table. Probably you should just
make it part of the below if block.
> + if (msm_host->opp_table)
> + dev_pm_opp_put_clkname(msm_host->opp_table);
> clk_disable:
> clk_bulk_disable_unprepare(ARRAY_SIZE(msm_host->bulk_clks),
> msm_host->bulk_clks);
> @@ -1564,6 +1598,9 @@ static int sdhci_msm_remove(struct platform_device *pdev)
> pm_runtime_get_sync(&pdev->dev);
> pm_runtime_disable(&pdev->dev);
> pm_runtime_put_noidle(&pdev->dev);
> + dev_pm_opp_of_remove_table(&pdev->dev);
And this too.
> + if (msm_host->opp_table)
> + dev_pm_opp_put_clkname(msm_host->opp_table);
>
> clk_bulk_disable_unprepare(ARRAY_SIZE(msm_host->bulk_clks),
> msm_host->bulk_clks);
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
next prev parent reply other threads:[~2018-03-16 4:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 4:08 [PATCH 0/7] Add powerdomain driver for corners on msm8996 Rajendra Nayak
2018-03-16 4:08 ` [PATCH 1/7] PM / OPP: Add dev_pm_opp_get_of_node() Rajendra Nayak
2018-04-07 13:00 ` Stephen Boyd
2018-04-09 3:22 ` Viresh Kumar
2018-04-09 15:17 ` Jordan Crouse
2018-03-16 4:08 ` [PATCH 2/7] soc: qcom: rpmpd: Add a powerdomain driver to model corners Rajendra Nayak
2018-03-18 12:52 ` Rob Herring
2018-03-16 4:08 ` [PATCH 3/7] dt-bindings: opp: Introduce qcom-opp bindings Rajendra Nayak
2018-03-16 4:33 ` Viresh Kumar
2018-03-26 22:22 ` Rob Herring
2018-04-07 13:05 ` Stephen Boyd
2018-03-16 4:08 ` [PATCH 4/7] soc: qcom: rpmpd: Add support for get/set performance state Rajendra Nayak
2018-03-16 4:35 ` Viresh Kumar
2018-03-16 5:52 ` Rajendra Nayak
2018-03-16 4:08 ` [PATCH 5/7] arm64: dts: msm8996: Add rpmpd device node Rajendra Nayak
2018-03-16 4:38 ` Viresh Kumar
2018-04-09 16:03 ` Stephen Boyd
2018-04-10 3:40 ` Viresh Kumar
2018-04-10 4:19 ` Rajendra Nayak
2018-03-16 4:08 ` [PATCH 6/7] mmc: sdhci-msm: Adapt the driver to use OPPs to set clocks/performance state Rajendra Nayak
2018-03-16 4:41 ` Viresh Kumar [this message]
2018-03-16 4:08 ` [PATCH 7/7] soc: qcom: rpmpd: Add a max vote on all corners at init Rajendra Nayak
2018-03-16 4:41 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180316044132.GS15832@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=andy.gross@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=rnayak@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).