From: "Du, Changbin" <changbin.du@intel.com>
To: changbin.du@intel.com
Cc: acme@kernel.org, jolsa@redhat.com, peterz@infradead.org,
mingo@redhat.com, namhyung@kernel.org,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf trace: remove redundant ')'
Date: Fri, 16 Mar 2018 15:51:09 +0800 [thread overview]
Message-ID: <20180316075108.xwenvklz3a6scodh@intel.com> (raw)
In-Reply-To: <1520937601-24952-1-git-send-email-changbin.du@intel.com>
Hi Arnaldo, How about this simple one? Thanks.
On Tue, Mar 13, 2018 at 06:40:01PM +0800, changbin.du@intel.com wrote:
> From: Changbin Du <changbin.du@intel.com>
>
> There is a redundant ')' at the tail of each event. So remove it.
> $ sudo perf trace --no-syscalls -e 'kmem:*' -a
> 899.342 kmem:kfree:(vfs_writev+0xb9) call_site=ffffffff9c453979 ptr=(nil))
> 899.344 kmem:kfree:(___sys_recvmsg+0x188) call_site=ffffffff9c9b8b88 ptr=(nil))
>
> Signed-off-by: Changbin Du <changbin.du@intel.com>
> ---
> tools/perf/builtin-trace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index e7f1b18..7273f5f 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -1959,7 +1959,7 @@ static int trace__event_handler(struct trace *trace, struct perf_evsel *evsel,
> trace->output);
> }
>
> - fprintf(trace->output, ")\n");
> + fprintf(trace->output, "\n");
>
> if (callchain_ret > 0)
> trace__fprintf_callchain(trace, sample);
> --
> 2.7.4
>
--
Thanks,
Changbin Du
next prev parent reply other threads:[~2018-03-16 8:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 10:40 [PATCH] perf trace: remove redundant ')' changbin.du
2018-03-16 7:51 ` Du, Changbin [this message]
2018-03-16 12:50 ` Arnaldo Carvalho de Melo
2018-03-28 7:26 ` Du, Changbin
2018-04-03 19:19 ` Arnaldo Carvalho de Melo
2018-04-04 2:31 ` Du, Changbin
2018-04-04 5:36 ` [tip:perf/urgent] perf trace: Remove " tip-bot for Changbin Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180316075108.xwenvklz3a6scodh@intel.com \
--to=changbin.du@intel.com \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).