From: Tony Lindgren <tony@atomide.com>
To: Maciej Purski <m.purski@samsung.com>
Cc: Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Fabio Estevam <festevam@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Doug Anderson <dianders@chromium.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v6 0/5] Add coupled regulators mechanism
Date: Fri, 16 Mar 2018 10:21:21 -0700 [thread overview]
Message-ID: <20180316172121.GT5799@atomide.com> (raw)
In-Reply-To: <c6f43013-3d2e-afbc-9be8-2e07f58fda98@samsung.com>
* Maciej Purski <m.purski@samsung.com> [180312 12:24]:
> On 03/09/2018 04:58 PM, Tony Lindgren wrote:
> > * Mark Brown <broonie@kernel.org> [180309 12:43]:
> > > On Fri, Mar 09, 2018 at 01:22:02PM +0100, Maciej Purski wrote:
> > >
> > > > I would like to kindly ask Fabio Estevam and Tony Lindgren to test the patch
> > > > series on their boards.
> >
> > I gave it a quick try and this set still causes at least mmc0
> > to fail for me.
>
> Thanks. Here's a small patch, which adds some debugs. Maybe they will reveal,
> where the problem is.
Sorry for the delay, now back from ELC. I tried applying this on
top of Linux next + your six patches but it fails to apply. Do
I need something else too?
Regards,
Tony
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index f1f11cf..0e80ba5 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -2280,7 +2280,6 @@ int regulator_enable(struct regulator *regulator)
> {
> struct regulator_dev *rdev = regulator->rdev;
> int ret = 0;
> - int ret2;
>
> if (rdev->coupling_desc.n_resolved != rdev->coupling_desc.n_coupled) {
> rdev_err(rdev, "not all coupled regulators registered\n");
> @@ -2298,15 +2297,9 @@ int regulator_enable(struct regulator *regulator)
>
> regulator_lock_dependent(rdev);
> ret = _regulator_enable(rdev);
> - ret2 = regulator_balance_voltage(rdev, PM_SUSPEND_ON);
> + regulator_balance_voltage(rdev, PM_SUSPEND_ON);
> regulator_unlock_dependent(rdev);
>
> - if (ret2 != 0) {
> - rdev_err(rdev,
> - "balancing failed when trying to enable regulator: %d",
> - ret2);
> - }
> -
> if (ret != 0 && rdev->supply)
> regulator_disable(rdev->supply);
>
> @@ -3149,7 +3142,7 @@ static int regulator_set_voltage_rdev(struct regulator_dev *rdev, int min_uV,
> ret = regulator_set_voltage_unlocked(rdev->supply,
> best_supply_uV, INT_MAX, state);
> if (ret)
> - dev_err(&rdev->dev, "Failed to decrease supply voltage: %d\n",
> + dev_warn(&rdev->dev, "Failed to decrease supply voltage: %d\n",
> ret);
> /* No need to fail here */
> ret = 0;
> @@ -3332,11 +3325,8 @@ static int regulator_balance_voltage(struct regulator_dev *rdev,
> ret = regulator_set_voltage_rdev(best_rdev, best_uV,
> best_uV, state);
>
> - if (ret < 0) {
> - rdev_err(rdev,
> - "Failed to set voltage with error: %d", ret);
> + if (ret < 0)
> goto out;
> - }
> }
>
> out:
>
>
prev parent reply other threads:[~2018-03-16 17:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180309122231eucas1p1b8e0a85a73b31aa07eac08f809face6e@eucas1p1.samsung.com>
2018-03-09 12:22 ` [PATCH v6 0/5] Add coupled regulators mechanism Maciej Purski
[not found] ` <CGME20180309122232eucas1p25be5fce6159682ef27cf7aec8c81e539@eucas1p2.samsung.com>
2018-03-09 12:22 ` [PATCH v6 1/6] regulator: core: Make locks re-entrant Maciej Purski
[not found] ` <CGME20180309122233eucas1p14d57674d3e9539db144c401593679c08@eucas1p1.samsung.com>
2018-03-09 12:22 ` [PATCH v6 2/6] regulator: bindings: Add properties for coupled regulators Maciej Purski
2018-03-09 23:01 ` Rob Herring
2018-05-17 16:41 ` Applied "regulator: bindings: Add properties for coupled regulators" to the regulator tree Mark Brown
[not found] ` <CGME20180309122233eucas1p2c64ed26c56a0c5f4ef1c268ae381743f@eucas1p2.samsung.com>
2018-03-09 12:22 ` [PATCH v6 3/6] regulator: core: Parse coupled regulators properties Maciej Purski
[not found] ` <CGME20180309122234eucas1p1a5c9e939848191de36a9daa06e785ae7@eucas1p1.samsung.com>
2018-03-09 12:22 ` [PATCH v6 4/6] regulator: core: Resolve coupled regulators Maciej Purski
[not found] ` <CGME20180309122234eucas1p1cc52e61f0930c4e0d4ec64784b601626@eucas1p1.samsung.com>
2018-03-09 12:22 ` [PATCH v6 5/6] regulator: core: Add voltage balancing mechanism Maciej Purski
[not found] ` <CGME20180309122235eucas1p1342d196d86555bd469cde651fa011999@eucas1p1.samsung.com>
2018-03-09 12:22 ` [PATCH v6 6/6] regulator: core: Change voltage setting path Maciej Purski
2018-03-09 12:42 ` [PATCH v6 0/5] Add coupled regulators mechanism Mark Brown
2018-03-09 12:50 ` Maciej Purski
2018-03-09 12:56 ` Mark Brown
2018-03-12 11:08 ` Maciej Purski
2018-03-09 15:58 ` Tony Lindgren
2018-03-12 12:22 ` Maciej Purski
2018-03-16 17:21 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180316172121.GT5799@atomide.com \
--to=tony@atomide.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.purski@samsung.com \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).