From: Masami Hiramatsu <mhiramat@kernel.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: rostedt <rostedt@goodmis.org>,
Francis Deslauriers <francis.deslauriers@efficios.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 2/2] kprobe: fix: Add ftrace_ops_assist_func to kprobe blacklist
Date: Sat, 17 Mar 2018 09:13:34 +0900 [thread overview]
Message-ID: <20180317091334.55f1fc325c26deaa4d4a4d19@kernel.org> (raw)
In-Reply-To: <1577244734.11604.1521222781948.JavaMail.zimbra@efficios.com>
On Fri, 16 Mar 2018 13:53:01 -0400 (EDT)
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
> ----- On Mar 16, 2018, at 12:48 PM, rostedt rostedt@goodmis.org wrote:
>
> > On Fri, 16 Mar 2018 12:41:34 -0400
> > Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> >> Yes, kprobes are dangerous. I'm not saying it shouldn't be fixed, I'm
> >> saying that I don't have time to fix it now, but would be happy to
> >> accept patches if someone else does so.
> >
> > And looking at what I replied before for the original patch. It would
> > probably be a good idea to blacklist directories. Like we do with
> > function tracing. We probably should black list both kernel/tracing and
> > kernel/events from being probed.
> >
> > Did this come up at plumbers? You were there too, I don't remember
> > discussing it there.
>
> I don't remember this coming up last Plumbers nor KS neither, given
> that we were focused on other topics.
>
> Would the general approach you envision be based on emitting all code
> generated by compilation of all objects under kernel/tracing and
> kernel/events into a specific "nokprobes" text section of the kernel ?
> Perhaps we could create a specific linker scripts for those directories,
> or do you have in mind a neater way to do this ?
.kprobes.text section still exists. As I pointed in previous mail, I don't
think we have to put all those code into that section. But if you want,
it is acceptable to have a kconfig which push most of those ftrace related
code into .kprobes.text section.
Thank,
>
> Thanks,
>
> Mathieu
>
> >
> > -- Steve
>
> --
> Mathieu Desnoyers
> EfficiOS Inc.
> http://www.efficios.com
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2018-03-17 0:13 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-14 14:58 [PATCH 0/2] kprobe: Fix: add symbols to kprobe blacklist Francis Deslauriers
2017-07-14 14:58 ` [PATCH 1/2] kprobe: fix: Add _ASM_NOKPROBE to x86 apic interrupt macro Francis Deslauriers
2017-07-14 14:58 ` [PATCH 2/2] kprobe: fix: Add ftrace_ops_assist_func to kprobe blacklist Francis Deslauriers
2017-07-14 18:29 ` Steven Rostedt
2018-03-16 15:18 ` Francis Deslauriers
2018-03-16 15:25 ` Steven Rostedt
2018-03-16 16:28 ` Mathieu Desnoyers
2018-03-16 16:41 ` Steven Rostedt
2018-03-16 16:48 ` Steven Rostedt
2018-03-16 17:53 ` Mathieu Desnoyers
2018-03-16 19:02 ` Steven Rostedt
2018-03-17 0:13 ` Masami Hiramatsu [this message]
2018-03-17 1:22 ` Masami Hiramatsu
2018-03-17 3:01 ` Steven Rostedt
2018-03-17 7:57 ` Masami Hiramatsu
2018-07-03 22:30 ` Steven Rostedt
2018-07-11 19:34 ` Francis Deslauriers
2018-07-11 19:56 ` Steven Rostedt
2018-07-12 0:40 ` Francis Deslauriers
2018-07-12 13:59 ` Masami Hiramatsu
2018-07-12 13:46 ` Masami Hiramatsu
2018-03-17 0:08 ` Masami Hiramatsu
2018-07-12 17:54 ` [PATCH 0/2] tracing: kprobes: Prohibit probing on notrace functions Francis Deslauriers
2018-07-12 17:54 ` [PATCH 1/2] " Francis Deslauriers
2018-07-12 21:49 ` Steven Rostedt
2018-07-13 2:53 ` Masami Hiramatsu
2018-07-13 12:18 ` Steven Rostedt
2018-07-26 0:41 ` Masami Hiramatsu
2018-07-26 1:13 ` Steven Rostedt
2018-07-12 17:54 ` [PATCH 2/2] selftest/ftrace: Move kprobe selftest function to separate compile unit Francis Deslauriers
2017-07-14 18:27 ` [PATCH 0/2] kprobe: Fix: add symbols to kprobe blacklist Steven Rostedt
2017-07-16 15:59 ` Masami Hiramatsu
2017-07-16 14:37 ` Masami Hiramatsu
2017-07-16 15:46 ` Masami Hiramatsu
2017-07-17 18:46 ` Francis Deslauriers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180317091334.55f1fc325c26deaa4d4a4d19@kernel.org \
--to=mhiramat@kernel.org \
--cc=francis.deslauriers@efficios.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).