From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754611AbeCRMxC (ORCPT ); Sun, 18 Mar 2018 08:53:02 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:41343 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754590AbeCRMws (ORCPT ); Sun, 18 Mar 2018 08:52:48 -0400 X-Google-Smtp-Source: AG47ELuqE9hbFiuPjab0K+yWyFzFMpLZHbxcR6cltr2Or3fMgLo6bC8vBbvlo2uwD0YOPzg7iA8J4A== Date: Sun, 18 Mar 2018 07:52:45 -0500 From: Rob Herring To: Archit Taneja Cc: Alexandru M Stan , David Airlie , Mark Rutland , Andrzej Hajda , Laurent Pinchart , Sean Paul , devicetree@vger.kernel.org, Enric Balletbo i Serra , Heiko Stuebner , briannorris@chromium.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, dianders@chromium.org, linux-rockchip@lists.infradead.org, marcheu@chromium.org, hoegsberg@chromium.org, Thierry Escande , Jeffy Chen Subject: Re: [PATCH 1/2] dt-bindings: analogix-dp: Add backlight-pwm-passthru Message-ID: <20180318125245.ndnplplmtsy3hmu7@rob-hp-laptop> References: <20180316025659.217423-1-amstan@chromium.org> <20180316025659.217423-2-amstan@chromium.org> <124034c6-a0af-0142-0d04-7d8bbc19bb82@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <124034c6-a0af-0142-0d04-7d8bbc19bb82@codeaurora.org> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 16, 2018 at 02:56:09PM +0530, Archit Taneja wrote: > > > On Friday 16 March 2018 08:26 AM, Alexandru M Stan wrote: > > Documentation for the optional backlight-pwm-passthru property. > > Tells the EDP panel to folow the input pwm frequency instead > > s/folow/follow > > It would be nice if we could add the details you mentioned in > patch #0 in either this or the next patch. > > > of generating its own. > > This is one of those bindings which is more a knob than a HW property, > but I can't think of any easy way to figure this out in SW. So, I guess > it's okay to have. > > One thing I was wondering about was whether this prop should belong to > the eDP controller or the eDP panel. I don't have any strong opinion > about it, though. Seems to me, it should be the panel. It's a setting in the panel, right? Is this generic to DP panels or something specific to a certain panel? The naming (vendor prefix or not) and doc location should match whatever the answer to that is. > > Reviewed-by: Archit Taneja > > Thanks, > Archit > > > > > > Signed-off-by: Alexandru M Stan > > --- > > > > Documentation/devicetree/bindings/display/bridge/analogix_dp.txt | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt b/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt > > index 0c7473dd0e51..3c15242f6ce3 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt > > +++ b/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt > > @@ -23,6 +23,10 @@ Required properties for dp-controller: > > from general PHY binding: Should be "dp". > > Optional properties for dp-controller: > > + -backlight-pwm-passthru: > > + Directly pass the PWM frequency applied to the BL_PWM_DIM > > + pin to the backlight current source. Done via > > + EDP_BACKLIGHT_MODE_SET_REGISTER on DPCD. > > -force-hpd: > > Indicate driver need force hpd when hpd detect failed, this > > is used for some eDP screen which don't have hpd signal. > >