From: Jason Gunthorpe <jgg@ziepe.ca>
To: Honggang LI <honli@redhat.com>
Cc: dledford@redhat.com, linux-rdma@vger.kernel.org,
noaos@mellanox.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] IB/core: Set speed string to SDR for invalid active rates
Date: Mon, 19 Mar 2018 11:53:12 -0600 [thread overview]
Message-ID: <20180319175312.GE1225@ziepe.ca> (raw)
In-Reply-To: <20180315090214.21706-2-honli@redhat.com>
On Thu, Mar 15, 2018 at 05:02:13PM +0800, Honggang LI wrote:
> From: Honggang Li <honli@redhat.com>
>
> commit f1b65df5a232 ("IB/mlx5: Add support for active_width and
> active_speed in RoCE"). Before this patch applied, the mlx5_ib
> driver set default active_width and active_speed to IB_WIDTH_4X
> and IB_SPEED_QDR.
>
> Now, the active_width and active_speed are zeros if the RoCE port
> is in DOWN state. The speed string should be set to " SDR" instead of
> a blank string when active_speed is zero.
>
> Signed-off-by: Honggang Li <honli@redhat.com>
> drivers/infiniband/core/sysfs.c | 1 +
> 1 file changed, 1 insertion(+)
Applied to for-next, thanks
Jason
next prev parent reply other threads:[~2018-03-19 17:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 9:02 [PATCH 0/2] IB/core: Set invalid active widths to 1X when port is not active Honggang LI
2018-03-15 9:02 ` [PATCH 1/2] IB/core: Set speed string to SDR for invalid active rates Honggang LI
2018-03-19 17:53 ` Jason Gunthorpe [this message]
2018-03-15 9:02 ` [PATCH 2/2] IB/core: Set width to 1X for invalid active widths when port is down Honggang LI
2018-03-15 12:01 ` Hal Rosenstock
2018-03-15 12:27 ` Honggang LI
2018-03-15 12:32 ` Hal Rosenstock
2018-03-15 12:43 ` Honggang LI
2018-03-15 12:47 ` Hal Rosenstock
2018-03-16 2:38 ` Honggang LI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180319175312.GE1225@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dledford@redhat.com \
--cc=honli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=noaos@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).