From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-716958-1521529025-2-16809450421743017996 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='CN', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-api-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1521529024; b=kIbPVxsUYR/Z5+SrFfqhgG//wnz3sRsZ5/p+nw1TINHzsCc CeTWC1deXFocj0W5OG8/SuxdCMcWPlpLyvYQr2iuVIhTdzkOul0oSUwrTMCvQQ6b gKHUYs5ypByOxEoknP27wMYAAMfjQtHOK7sARn7dcH+oJNHdKY/6ZDGbJrXewjwV jvuAhmeKIPRxb2/HLdVP4cYm+UCxctyCfEGtoKwaCwPVil2SH29wi9RycDnuXC+I 8YZVfEPjJSsSNRqULHOcUuN3Sg3eX4qPhnEH7C/5juTkEosPu0z8/w8nYK4zcQv9 wPiM0wboRxSqklyzwIuCRm8PUvK1AS9JGMp0gOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to:sender :list-id; s=arctest; t=1521529024; bh=nTJ1PH4GCFsKQLDqsRWv/aDU8v ZsLGYT+a/I3HA6n2E=; b=D/4ouD2tmr7QLeIC2H28aV4kTT4fBnoSa1/iKl/51j HLLNi3NKvXhLitIcEgEwcaPsZ4qJfR3PrZuJwBbepLTBBQoOgKVc95FXTOPHYrT4 uYywiZphMbqrN1djRw8eZSETyNffYOIKX0cgtUZdQQnNmXxJHgWIZK/9xZFYiG6l 7oSm4T1OcBjMfwy8StG9CjXU4XICQQqznem6lBlWk1kSHNRxYhyh6dw46dzXI4cc iaCCJhsEgVilbmZgU7einH0pgKZnvoucppKspzKwmIrB1JILhEYcyYUxbw8T2KQm KwpIR+pg7/9GWddUBIJy6C6cOsRIijV4p4s0AMx42vAw== ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=intel.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-api-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=intel.com header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=intel.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-api-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=intel.com header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751186AbeCTG5B (ORCPT ); Tue, 20 Mar 2018 02:57:01 -0400 Received: from mga14.intel.com ([192.55.52.115]:45496 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750888AbeCTG5A (ORCPT ); Tue, 20 Mar 2018 02:57:00 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,334,1517904000"; d="scan'208";a="26388302" Date: Tue, 20 Mar 2018 14:46:59 +0800 From: Wu Hao To: Alan Tull Cc: Moritz Fischer , linux-fpga@vger.kernel.org, linux-kernel , linux-api@vger.kernel.org, "Kang, Luwei" , "Zhang, Yi Z" , Tim Whisonant , Enno Luebbers , Shiva Rao , Christopher Rauer , Xiao Guangrong Subject: Re: [PATCH v4 12/24] fpga: dfl: fme: add FPGA_GET_API_VERSION/CHECK_EXTENSION ioctls support Message-ID: <20180320064659.GA31239@hao-dev> References: <1518513893-4719-1-git-send-email-hao.wu@intel.com> <1518513893-4719-13-git-send-email-hao.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-api-owner@vger.kernel.org X-Mailing-List: linux-api@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Mon, Mar 19, 2018 at 01:29:52PM -0500, Alan Tull wrote: > On Tue, Feb 13, 2018 at 3:24 AM, Wu Hao wrote: > > Hi Hao, > > Looking at fpga-dfl.h again, there's a lot of things that start with > FPGA_. Don't you think this is too general? There are other FPGA_ > things in the kernel. Not just the things added by this patch, but > the whole file. Hi Alan Thanks for the comments, I got your point here. FPGA_ things should be reserved for more generic things for FPGA. I will search and replace the FPGA_xxx things used here and in other files. > > > FPGA_GET_API_VERSION and FPGA_CHECK_EXTENSION ioctls are common ones which > > Maybe DFL_FPGA_GET_API_VERSION? Yes, DFL_FPGA_GET_API_VERSION looks good. > > > need to be supported by all feature devices drivers including FME and AFU. > > Userspace application can use these ioctl interfaces to get the API info > > and check if specific extension is supported or not in current driver. > > > > This patch implements above 2 ioctls in FPGA Management Engine (FME) > > driver. > > > > Signed-off-by: Tim Whisonant > > Signed-off-by: Enno Luebbers > > Signed-off-by: Shiva Rao > > Signed-off-by: Christopher Rauer > > Signed-off-by: Xiao Guangrong > > Signed-off-by: Wu Hao > > Acked-by: Alan Tull > > Acked-by: Moritz Fischer > > --- > > v2: switched to GPLv2 license. > > v3: rename intel-fpga.h to fpga-dfl.h and rebased. > > v4: fix SPDX license issue. > > add Acked-by from Alan and Moritz. > > --- > > Documentation/ioctl/ioctl-number.txt | 1 + > > drivers/fpga/dfl-fme-main.c | 12 +++++++++ > > include/uapi/linux/fpga-dfl.h | 48 ++++++++++++++++++++++++++++++++++++ > > 3 files changed, 61 insertions(+) > > create mode 100644 include/uapi/linux/fpga-dfl.h > > > > diff --git a/Documentation/ioctl/ioctl-number.txt b/Documentation/ioctl/ioctl-number.txt > > index 6501389..f1e7baa 100644 > > --- a/Documentation/ioctl/ioctl-number.txt > > +++ b/Documentation/ioctl/ioctl-number.txt > > @@ -324,6 +324,7 @@ Code Seq#(hex) Include File Comments > > 0xB3 00 linux/mmc/ioctl.h > > 0xB4 00-0F linux/gpio.h > > 0xB5 00-0F uapi/linux/rpmsg.h > > +0xB6 all linux/fpga-dfl.h > > 0xC0 00-0F linux/usb/iowarrior.h > > 0xCA 00-0F uapi/misc/cxl.h > > 0xCA 10-2F uapi/misc/ocxl.h > > diff --git a/drivers/fpga/dfl-fme-main.c b/drivers/fpga/dfl-fme-main.c > > index 056ae24..1a9929c 100644 > > --- a/drivers/fpga/dfl-fme-main.c > > +++ b/drivers/fpga/dfl-fme-main.c > > @@ -16,6 +16,7 @@ > > > > #include > > #include > > +#include > > > > #include "dfl.h" > > > > @@ -114,6 +115,13 @@ static struct feature_driver fme_feature_drvs[] = { > > }, > > }; > > > > +static long fme_ioctl_check_extension(struct feature_platform_data *pdata, > > + unsigned long arg) > > +{ > > + /* No extension support for now */ > > + return 0; > > +} > > + > > static int fme_open(struct inode *inode, struct file *filp) > > { > > struct platform_device *fdev = fpga_inode_to_feature_dev(inode); > > @@ -154,6 +162,10 @@ static long fme_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) > > dev_dbg(&pdev->dev, "%s cmd 0x%x\n", __func__, cmd); > > > > switch (cmd) { > > + case FPGA_GET_API_VERSION: > > + return FPGA_API_VERSION; > > + case FPGA_CHECK_EXTENSION: > > + return fme_ioctl_check_extension(pdata, arg); > > default: > > /* > > * Let sub-feature's ioctl function to handle the cmd > > diff --git a/include/uapi/linux/fpga-dfl.h b/include/uapi/linux/fpga-dfl.h > > new file mode 100644 > > index 0000000..9321ee9 > > --- /dev/null > > +++ b/include/uapi/linux/fpga-dfl.h > > @@ -0,0 +1,48 @@ > > +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ > > +/* > > + * Header File for FPGA DFL User API > > + * > > + * Copyright (C) 2017 Intel Corporation, Inc. > > + * > > + * Authors: > > + * Kang Luwei > > + * Zhang Yi > > + * Wu Hao > > + * Xiao Guangrong > > + */ > > + > > +#ifndef _UAPI_LINUX_FPGA_DFL_H > > +#define _UAPI_LINUX_FPGA_DFL_H > > + > > +#define FPGA_API_VERSION 0 > > There will be other FPGA API's. Maybe DFL_FPGA_... or FME_FPGA_... I will pick DFL_FPGA_... here and below places. :) > > > + > > +/* > > + * The IOCTL interface for DFL based FPGA is designed for extensibility by > > + * embedding the structure length (argsz) and flags into structures passed > > + * between kernel and userspace. This design referenced the VFIO IOCTL > > + * interface (include/uapi/linux/vfio.h). > > + */ > > + > > +#define FPGA_MAGIC 0xB6 > > Same here. > > > + > > +#define FPGA_BASE 0 > > And here. > > > + > > +/** > > + * FPGA_GET_API_VERSION - _IO(FPGA_MAGIC, FPGA_BASE + 0) > > + * > > + * Report the version of the driver API. > > + * Return: Driver API Version. > > + */ > > + > > +#define FPGA_GET_API_VERSION _IO(FPGA_MAGIC, FPGA_BASE + 0) > > + > > +/** > > + * FPGA_CHECK_EXTENSION - _IO(FPGA_MAGIC, FPGA_BASE + 1) > > + * > > + * Check whether an extension is supported. > > + * Return: 0 if not supported, otherwise the extension is supported. > > + */ > > + > > +#define FPGA_CHECK_EXTENSION _IO(FPGA_MAGIC, FPGA_BASE + 1) > > Basically all the FPGA_* stuff here is specific to this particular DFL > FPGA API and should have a better name. Will update them in the next version, thanks again for the comments. Hao > > Alan > > > + > > +#endif /* _UAPI_LINUX_FPGA_DFL_H */ > > -- > > 2.7.4 > >