From: Daniel Kurtz <djkurtz@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matthias Kaehlcke <mka@chromium.org>,
Guenter Roeck <groeck@chromium.org>
Cc: adurbin@chromium.org, linux-kernel@vger.kernel.org,
Daniel Kurtz <djkurtz@chromium.org>
Subject: [PATCH v2 0/2] Fix __earlycon_table stride... again
Date: Tue, 20 Mar 2018 11:57:10 -0600 [thread overview]
Message-ID: <20180320175712.201572-1-djkurtz@chromium.org> (raw)
The __earlycon_table lives in a special "__earlycon_table" section. The
contents of this table are added using some macros that deposit individual
struct earlycon_id entries into this section. The linker then defines a symbol
__earlycon_table that is supposed to contain the addresss of the first of these
entries. The code in earlycon.c and fdt.c then tries to access the memory
pointed to by __earlycon_table as an array of struct earlycon_id entries.
Unfortunately, the compiler doesn't always place the entries such that they
are an array. Let's fix that.
Patch 1 of the series is a fix that should hopefully fix a kbuild error that
seems to be triggered by Patch 2.
Daniel Kurtz (2):
serial: sh-sci: Remove __initdata attribute for struct 'port_cfg'
earlycon: Use a pointer table to fix __earlycon_table stride
drivers/of/fdt.c | 7 +++++--
drivers/tty/serial/earlycon.c | 6 ++++--
drivers/tty/serial/sh-sci.c | 2 +-
include/asm-generic/vmlinux.lds.h | 2 +-
include/linux/serial_core.h | 21 ++++++++++++++-------
5 files changed, 25 insertions(+), 13 deletions(-)
--
2.16.2.804.g6dcf76e118-goog
next reply other threads:[~2018-03-20 17:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 17:57 Daniel Kurtz [this message]
2018-03-20 17:57 ` [PATCH v2 1/2] serial: sh-sci: Remove __initdata attribute for struct 'port_cfg' Daniel Kurtz
2018-03-20 17:57 ` [PATCH v2 2/2] earlycon: Use a pointer table to fix __earlycon_table stride Daniel Kurtz
2018-03-20 18:19 ` Guenter Roeck
2018-03-23 2:54 ` kbuild test robot
2018-03-23 13:34 ` [PATCH v2 0/2] Fix __earlycon_table stride... again Greg Kroah-Hartman
2018-03-24 4:49 ` Daniel Kurtz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180320175712.201572-1-djkurtz@chromium.org \
--to=djkurtz@chromium.org \
--cc=adurbin@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).