linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: NIIBE Yutaka <gniibe@fsij.org>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org, gniibe@fsij.org
Subject: Re: [PATCH 3/4] signal/x86: Move nosig handling at the end of exit_to_usermode_loop.
Date: Wed, 21 Mar 2018 09:39:20 +0800	[thread overview]
Message-ID: <201803210929.40dSEA4q%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180320023857.1885-4-gniibe@fsij.org>

[-- Attachment #1: Type: text/plain, Size: 3540 bytes --]

Hi NIIBE,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v4.16-rc4]
[also build test ERROR on next-20180320]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/NIIBE-Yutaka/Unblocked-by-fake_signal_wake_up-then-real-signal/20180321-051147
config: um-x86_64_defconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=um SUBARCH=x86_64

All errors (new ones prefixed by >>):

   In file included from arch/um/kernel/irq.c:17:0:
>> arch/um/include/shared/kern_util.h:26:13: error: conflicting types for 'do_signal'
    extern void do_signal(struct pt_regs *regs);
                ^~~~~~~~~
   In file included from include/uapi/linux/signal.h:5:0,
                    from include/linux/signal_types.h:10,
                    from include/linux/sched.h:27,
                    from include/linux/kernel_stat.h:10,
                    from arch/um/kernel/irq.c:11:
   arch/x86/include/asm/signal.h:38:12: note: previous declaration of 'do_signal' was here
    extern int do_signal(struct pt_regs *regs);
               ^~~~~~~~~
--
   In file included from arch/um/kernel/signal.c:13:0:
>> arch/um/include/shared/kern_util.h:26:13: error: conflicting types for 'do_signal'
    extern void do_signal(struct pt_regs *regs);
                ^~~~~~~~~
   In file included from include/uapi/linux/signal.h:5:0,
                    from include/linux/signal_types.h:10,
                    from include/linux/sched.h:27,
                    from include/linux/ptrace.h:6,
                    from arch/um/kernel/signal.c:7:
   arch/x86/include/asm/signal.h:38:12: note: previous declaration of 'do_signal' was here
    extern int do_signal(struct pt_regs *regs);
               ^~~~~~~~~
>> arch/um/kernel/signal.c:67:6: error: conflicting types for 'do_signal'
    void do_signal(struct pt_regs *regs)
         ^~~~~~~~~
   In file included from include/uapi/linux/signal.h:5:0,
                    from include/linux/signal_types.h:10,
                    from include/linux/sched.h:27,
                    from include/linux/ptrace.h:6,
                    from arch/um/kernel/signal.c:7:
   arch/x86/include/asm/signal.h:38:12: note: previous declaration of 'do_signal' was here
    extern int do_signal(struct pt_regs *regs);
               ^~~~~~~~~

vim +/do_signal +26 arch/um/include/shared/kern_util.h

edea13858 arch/um/include/kern_util.h        Jeff Dike     2008-02-04  24  
ccaee5f85 arch/um/include/shared/kern_util.h Ingo Molnar   2015-07-03  25  struct pt_regs;
ccaee5f85 arch/um/include/shared/kern_util.h Ingo Molnar   2015-07-03 @26  extern void do_signal(struct pt_regs *regs);
edea13858 arch/um/include/kern_util.h        Jeff Dike     2008-02-04  27  extern void interrupt_end(void);
d3c1cfcdb arch/um/include/shared/kern_util.h Martin Pärtel 2012-08-02  28  extern void relay_signal(int sig, struct siginfo *si, struct uml_pt_regs *regs);
edea13858 arch/um/include/kern_util.h        Jeff Dike     2008-02-04  29  

:::::: The code at line 26 was first introduced by commit
:::::: ccaee5f851470dec6894a6835b6fadffc2bb7514 um: Fix do_signal() prototype

:::::: TO: Ingo Molnar <mingo@kernel.org>
:::::: CC: Ingo Molnar <mingo@kernel.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 8114 bytes --]

  reply	other threads:[~2018-03-21  1:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-20  2:38 [PATCH 0/4] Unblocked by fake_signal_wake_up then real signal NIIBE Yutaka
2018-03-20  2:38 ` [PATCH 1/4] signal/x86: Factor out nosig handling NIIBE Yutaka
2018-03-20  2:38 ` [PATCH 2/4] signal/x86: do_signal: syscall restart should be done only once NIIBE Yutaka
2018-03-20  2:38 ` [PATCH 3/4] signal/x86: Move nosig handling at the end of exit_to_usermode_loop NIIBE Yutaka
2018-03-21  1:39   ` kbuild test robot [this message]
2018-03-20  2:38 ` [PATCH 4/4] signal/x86: Move restore_saved_sigmask() NIIBE Yutaka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201803210929.40dSEA4q%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=gniibe@fsij.org \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).