Hi Richard,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.16-rc6 next-20180322]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Richard-Fitzgerald/mfd-madera-Add-register-definitions-for-Cirrus-Logic-Madera-codecs/20180314-211822
config: i386-randconfig-x010-03221515 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

>> drivers/pinctrl/cirrus/pinctrl-madera-core.c:561:20: error: 'pinconf_generic_dt_node_to_map_all' undeclared here (not in a function); did you mean 'pinconf_generic_params'?
     .dt_node_to_map = pinconf_generic_dt_node_to_map_all,
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                       pinconf_generic_params

vim +561 drivers/pinctrl/cirrus/pinctrl-madera-core.c

   555	
   556	
   557	static const struct pinctrl_ops madera_pin_group_ops = {
   558		.get_groups_count = madera_get_groups_count,
   559		.get_group_name = madera_get_group_name,
   560		.get_group_pins = madera_get_group_pins,
 > 561		.dt_node_to_map = pinconf_generic_dt_node_to_map_all,
   562		.dt_free_map = pinctrl_utils_free_map,
   563	#if IS_ENABLED(CONFIG_DEBUG_FS)
   564		.pin_dbg_show = madera_pin_dbg_show,
   565	#endif
   566	};
   567	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation