From: Benson Leung <bleung@google.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, Benson Leung <bleung@chromium.org>,
Nick Dyer <nick@shmanahar.org>, Olof Johansson <olof@lixom.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 05/14] platform/chrome: chromeos_laptop - stop setting suspend mode for Atmel devices
Date: Thu, 22 Mar 2018 16:34:08 -0700 [thread overview]
Message-ID: <20180322233408.GA29926@decatoncale.mtv.corp.google.com> (raw)
In-Reply-To: <20180320223138.234724-6-dmitry.torokhov@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1508 bytes --]
Hi Dmitry,
On Tue, Mar 20, 2018 at 03:31:29PM -0700, Dmitry Torokhov wrote:
> Atmel touch controller driver no longer respects suspend mode specified in
> platform data, so let's stop setting it.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Applied to my working branch for atmel_mxt_ts + chromeos_laptop.c for
v4.17. Thanks!
> ---
> drivers/platform/chrome/chromeos_laptop.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/platform/chrome/chromeos_laptop.c b/drivers/platform/chrome/chromeos_laptop.c
> index 54a13c70e1d8f..0a43f1833de3f 100644
> --- a/drivers/platform/chrome/chromeos_laptop.c
> +++ b/drivers/platform/chrome/chromeos_laptop.c
> @@ -100,7 +100,6 @@ static struct mxt_platform_data atmel_224s_tp_platform_data = {
> .irqflags = IRQF_TRIGGER_FALLING,
> .t19_num_keys = ARRAY_SIZE(mxt_t19_keys),
> .t19_keymap = mxt_t19_keys,
> - .suspend_mode = MXT_SUSPEND_T9_CTRL,
> };
>
> static struct i2c_board_info atmel_224s_tp_device = {
> @@ -111,7 +110,6 @@ static struct i2c_board_info atmel_224s_tp_device = {
>
> static struct mxt_platform_data atmel_1664s_platform_data = {
> .irqflags = IRQF_TRIGGER_FALLING,
> - .suspend_mode = MXT_SUSPEND_T9_CTRL,
> };
>
> static struct i2c_board_info atmel_1664s_device = {
> --
> 2.16.2.804.g6dcf76e118-goog
>
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-03-22 23:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 22:31 [PATCH v2 00/14] chrome_laptop: stop being a platform driver Dmitry Torokhov
2018-03-20 22:31 ` [PATCH v2 01/14] Input: atmel_mxt_ts - do not pass suspend mode in platform data Dmitry Torokhov
2018-04-10 5:44 ` Benson Leung
2018-03-20 22:31 ` [PATCH v2 02/14] Input: atmel_mxt_ts - switch from OF to generic device properties Dmitry Torokhov
2018-03-20 22:31 ` [PATCH v2 03/14] Input: atmel_mxt_ts - switch ChromeOS ACPI devices to generic props Dmitry Torokhov
2018-03-20 22:31 ` [PATCH v2 04/14] platform/chrome: chromeos_laptop - add SPDX identifier Dmitry Torokhov
2018-03-20 22:31 ` [PATCH v2 05/14] platform/chrome: chromeos_laptop - stop setting suspend mode for Atmel devices Dmitry Torokhov
2018-03-22 23:34 ` Benson Leung [this message]
2018-03-20 22:31 ` [PATCH v2 06/14] platform/chrome: chromeos_laptop - introduce pr_fmt() Dmitry Torokhov
2018-03-20 22:31 ` [PATCH v2 07/14] platform/chrome: chromeos_laptop - factor out getting IRQ from DMI Dmitry Torokhov
2018-03-20 22:31 ` [PATCH v2 08/14] platform/chrome: chromeos_laptop - rework i2c peripherals initialization Dmitry Torokhov
2018-03-20 22:31 ` [PATCH v2 09/14] platform/chrome: chromeos_laptop - parse DMI IRQ data once Dmitry Torokhov
2018-03-20 22:31 ` [PATCH v2 10/14] platform/chrome: chromeos_laptop - use I2C notifier to create devices Dmitry Torokhov
2018-03-20 22:31 ` [PATCH v2 11/14] platform/chrome: chromeos_laptop - rely on I2C to set up interrupt trigger Dmitry Torokhov
2018-03-20 22:31 ` [PATCH v2 12/14] platform/chrome: chromeos_laptop - use device properties for Pixel Dmitry Torokhov
2018-03-20 22:31 ` [PATCH v2 13/14] platform/chrome: chromeos_laptop - discard data for unneeded boards Dmitry Torokhov
2018-03-20 22:31 ` [PATCH v2 14/14] Input: atmel_mxt_ts - remove platform data support Dmitry Torokhov
2018-04-11 5:44 ` [PATCH v2 00/14] chrome_laptop: stop being a platform driver Benson Leung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180322233408.GA29926@decatoncale.mtv.corp.google.com \
--to=bleung@google.com \
--cc=bleung@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nick@shmanahar.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).