Hi Maninder, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc6] [cannot apply to next-20180322] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Maninder-Singh/cover-letter-lz4-Implement-lz4-with-dynamic-offset-length/20180323-064137 config: i386-randconfig-x073-201811 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): fs/pstore/platform.c: In function 'decompress_lz4': >> fs/pstore/platform.c:357:8: error: too few arguments to function 'LZ4_decompress_safe' ret = LZ4_decompress_safe(in, out, inlen, outlen); ^~~~~~~~~~~~~~~~~~~ In file included from fs/pstore/platform.c:38:0: include/linux/lz4.h:301:5: note: declared here int LZ4_decompress_safe(const char *source, char *dest, int compressedSize, ^~~~~~~~~~~~~~~~~~~ vim +/LZ4_decompress_safe +357 fs/pstore/platform.c 8cfc8ddc Geliang Tang 2016-02-18 352 8cfc8ddc Geliang Tang 2016-02-18 353 static int decompress_lz4(void *in, void *out, size_t inlen, size_t outlen) 8cfc8ddc Geliang Tang 2016-02-18 354 { 8cfc8ddc Geliang Tang 2016-02-18 355 int ret; 8cfc8ddc Geliang Tang 2016-02-18 356 d21b5ff1 Sven Schmidt 2017-02-24 @357 ret = LZ4_decompress_safe(in, out, inlen, outlen); d21b5ff1 Sven Schmidt 2017-02-24 358 if (ret < 0) { d21b5ff1 Sven Schmidt 2017-02-24 359 /* d21b5ff1 Sven Schmidt 2017-02-24 360 * LZ4_decompress_safe will return an error code d21b5ff1 Sven Schmidt 2017-02-24 361 * (< 0) if decompression failed d21b5ff1 Sven Schmidt 2017-02-24 362 */ d21b5ff1 Sven Schmidt 2017-02-24 363 pr_err("LZ4_decompress_safe error, ret = %d!\n", ret); 8cfc8ddc Geliang Tang 2016-02-18 364 return -EIO; 8cfc8ddc Geliang Tang 2016-02-18 365 } 8cfc8ddc Geliang Tang 2016-02-18 366 d21b5ff1 Sven Schmidt 2017-02-24 367 return ret; 8cfc8ddc Geliang Tang 2016-02-18 368 } 8cfc8ddc Geliang Tang 2016-02-18 369 :::::: The code at line 357 was first introduced by commit :::::: d21b5ff12df45a65bb220c7e8103a5f0f5609377 fs/pstore: fs/squashfs: change usage of LZ4 to work with new LZ4 version :::::: TO: Sven Schmidt <4sschmid@informatik.uni-hamburg.de> :::::: CC: Linus Torvalds --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation