From: kbuild test robot <lkp@intel.com>
To: Maninder Singh <maninder1.s@samsung.com>
Cc: kbuild-all@01.org, herbert@gondor.apana.org.au,
davem@davemloft.net, minchan@kernel.org, ngupta@vflare.org,
sergey.senozhatsky.work@gmail.com, keescook@chromium.org,
anton@enomsg.org, ccross@android.com, tony.luck@intel.com,
akpm@linux-foundation.org, colin.king@canonical.com,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
pankaj.m@samsung.com, a.sahrawat@samsung.com,
v.narang@samsung.com, Maninder Singh <maninder1.s@samsung.com>
Subject: Re: [PATCH 1/1] lz4: Implement lz4 with dynamic offset length.
Date: Fri, 23 Mar 2018 07:32:32 +0800 [thread overview]
Message-ID: <201803230748.gz1egglK%fengguang.wu@intel.com> (raw)
In-Reply-To: <1521607242-3968-2-git-send-email-maninder1.s@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 4484 bytes --]
Hi Maninder,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.16-rc6]
[cannot apply to next-20180322]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Maninder-Singh/cover-letter-lz4-Implement-lz4-with-dynamic-offset-length/20180323-064137
config: i386-randconfig-s1-03221113 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
fs/squashfs/lz4_wrapper.c: In function 'lz4_uncompress':
>> fs/squashfs/lz4_wrapper.c:110:8: error: too few arguments to function 'LZ4_decompress_safe'
res = LZ4_decompress_safe(stream->input, stream->output,
^~~~~~~~~~~~~~~~~~~
In file included from fs/squashfs/lz4_wrapper.c:13:0:
include/linux/lz4.h:301:5: note: declared here
int LZ4_decompress_safe(const char *source, char *dest, int compressedSize,
^~~~~~~~~~~~~~~~~~~
vim +/LZ4_decompress_safe +110 fs/squashfs/lz4_wrapper.c
9c06a46f Phillip Lougher 2014-11-27 91
9c06a46f Phillip Lougher 2014-11-27 92
9c06a46f Phillip Lougher 2014-11-27 93 static int lz4_uncompress(struct squashfs_sb_info *msblk, void *strm,
9c06a46f Phillip Lougher 2014-11-27 94 struct buffer_head **bh, int b, int offset, int length,
9c06a46f Phillip Lougher 2014-11-27 95 struct squashfs_page_actor *output)
9c06a46f Phillip Lougher 2014-11-27 96 {
9c06a46f Phillip Lougher 2014-11-27 97 struct squashfs_lz4 *stream = strm;
9c06a46f Phillip Lougher 2014-11-27 98 void *buff = stream->input, *data;
9c06a46f Phillip Lougher 2014-11-27 99 int avail, i, bytes = length, res;
9c06a46f Phillip Lougher 2014-11-27 100
9c06a46f Phillip Lougher 2014-11-27 101 for (i = 0; i < b; i++) {
9c06a46f Phillip Lougher 2014-11-27 102 avail = min(bytes, msblk->devblksize - offset);
9c06a46f Phillip Lougher 2014-11-27 103 memcpy(buff, bh[i]->b_data + offset, avail);
9c06a46f Phillip Lougher 2014-11-27 104 buff += avail;
9c06a46f Phillip Lougher 2014-11-27 105 bytes -= avail;
9c06a46f Phillip Lougher 2014-11-27 106 offset = 0;
9c06a46f Phillip Lougher 2014-11-27 107 put_bh(bh[i]);
9c06a46f Phillip Lougher 2014-11-27 108 }
9c06a46f Phillip Lougher 2014-11-27 109
d21b5ff1 Sven Schmidt 2017-02-24 @110 res = LZ4_decompress_safe(stream->input, stream->output,
d21b5ff1 Sven Schmidt 2017-02-24 111 length, output->length);
d21b5ff1 Sven Schmidt 2017-02-24 112
d21b5ff1 Sven Schmidt 2017-02-24 113 if (res < 0)
9c06a46f Phillip Lougher 2014-11-27 114 return -EIO;
9c06a46f Phillip Lougher 2014-11-27 115
d21b5ff1 Sven Schmidt 2017-02-24 116 bytes = res;
9c06a46f Phillip Lougher 2014-11-27 117 data = squashfs_first_page(output);
9c06a46f Phillip Lougher 2014-11-27 118 buff = stream->output;
9c06a46f Phillip Lougher 2014-11-27 119 while (data) {
09cbfeaf Kirill A. Shutemov 2016-04-01 120 if (bytes <= PAGE_SIZE) {
9c06a46f Phillip Lougher 2014-11-27 121 memcpy(data, buff, bytes);
9c06a46f Phillip Lougher 2014-11-27 122 break;
9c06a46f Phillip Lougher 2014-11-27 123 }
09cbfeaf Kirill A. Shutemov 2016-04-01 124 memcpy(data, buff, PAGE_SIZE);
09cbfeaf Kirill A. Shutemov 2016-04-01 125 buff += PAGE_SIZE;
09cbfeaf Kirill A. Shutemov 2016-04-01 126 bytes -= PAGE_SIZE;
9c06a46f Phillip Lougher 2014-11-27 127 data = squashfs_next_page(output);
9c06a46f Phillip Lougher 2014-11-27 128 }
9c06a46f Phillip Lougher 2014-11-27 129 squashfs_finish_page(output);
9c06a46f Phillip Lougher 2014-11-27 130
d21b5ff1 Sven Schmidt 2017-02-24 131 return res;
9c06a46f Phillip Lougher 2014-11-27 132 }
9c06a46f Phillip Lougher 2014-11-27 133
:::::: The code at line 110 was first introduced by commit
:::::: d21b5ff12df45a65bb220c7e8103a5f0f5609377 fs/pstore: fs/squashfs: change usage of LZ4 to work with new LZ4 version
:::::: TO: Sven Schmidt <4sschmid@informatik.uni-hamburg.de>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28546 bytes --]
next prev parent reply other threads:[~2018-03-22 23:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180321044137epcas5p221e7ee4a0b7464eaa00dad8320f0251d@epcas5p2.samsung.com>
2018-03-21 4:40 ` [PATCH 0/1] cover-letter/lz4: Implement lz4 with dynamic offset length Maninder Singh
[not found] ` <CGME20180321044149epcas5p12cba1afa5fc0f493a47fe20c4a7394bd@epcas5p1.samsung.com>
2018-03-21 4:40 ` [PATCH 1/1] lz4: " Maninder Singh
2018-03-21 7:49 ` Sergey Senozhatsky
2018-03-21 19:59 ` Nick Terrell
[not found] ` <CGME20180321195916epcas4p1e89e1cc5fd242ee8c348f92f1d1740b0@epcms5p1>
2018-03-22 4:28 ` Maninder Singh
2018-03-22 23:09 ` kbuild test robot
2018-03-22 23:32 ` kbuild test robot [this message]
[not found] ` <CGME20180321195916epcas4p1e89e1cc5fd242ee8c348f92f1d1740b0@epcms5p8>
2018-03-23 13:21 ` Vaneet Narang
[not found] ` <CGME20180321044149epcas5p12cba1afa5fc0f493a47fe20c4a7394bd@epcms5p5>
2018-04-02 5:51 ` Maninder Singh
2018-04-03 12:26 ` Sergey Senozhatsky
[not found] ` <CGME20180321044149epcas5p12cba1afa5fc0f493a47fe20c4a7394bd@epcms5p7>
2018-04-03 13:43 ` Vaneet Narang
2018-04-04 1:40 ` Sergey Senozhatsky
2018-03-21 6:41 ` [PATCH 0/1] cover-letter/lz4: " Sergey Senozhatsky
2018-03-21 8:26 ` Sergey Senozhatsky
2018-03-21 19:56 ` Nick Terrell
2018-03-22 2:43 ` Sergey Senozhatsky
[not found] ` <CGME20180321044137epcas5p221e7ee4a0b7464eaa00dad8320f0251d@epcms5p6>
2018-03-23 13:43 ` Vaneet Narang
2018-03-29 10:26 ` Maninder Singh
2018-03-30 5:41 ` Sergey Senozhatsky
[not found] ` <CGME20180321044137epcas5p221e7ee4a0b7464eaa00dad8320f0251d@epcms5p4>
2018-04-16 10:21 ` Maninder Singh
2018-04-16 19:34 ` Yann Collet
2018-04-16 20:01 ` Eric Biggers
[not found] ` <CGME20180321044137epcas5p221e7ee4a0b7464eaa00dad8320f0251d@epcms5p3>
2018-04-02 6:03 ` Maninder Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201803230748.gz1egglK%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=a.sahrawat@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kbuild-all@01.org \
--cc=keescook@chromium.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maninder1.s@samsung.com \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=pankaj.m@samsung.com \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=tony.luck@intel.com \
--cc=v.narang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).