From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AG47ELvGoF2Nq0a1A1klWX0RirCvk4TJ0cIrJNgttuQE5Xv6LAnhX9/lUHI34LDJc3nHci6hgYel ARC-Seal: i=1; a=rsa-sha256; t=1521800195; cv=none; d=google.com; s=arc-20160816; b=LAos0KeiGaLPg9McNGwMHPlU6fGCAl4nrYjgRW2OrMcUvgttClm/95lL+3emvj8cQv NkrlNZmYLBN07UYv1mH9QNh1k5jKfo3Q0++i5bu/jC3DgjXr6scQRux+W9VGeYphrscF g+4THSOmPMuT/5VhzYx1hA/MqdtrAkv2mBjQ514/5V1M2uFaN8ORXdKI24BYKiBocmFh MDo1TIP3+xEkXZXfCVm5ukCNaa9oNvBghSTuzNxeehIUnE8Wla6e6rpZf883KJBQImXt roCBhw2E0olWhVGdORM0FCeNQkl2vFnNnZvy0jL5HpfUZQf3MjKw/F3JCIDoJ5YKDI0Z aGIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=OcLhi9NaLEzC6QeciDFLWowXmu12HnNw89Xu5Z1KFcw=; b=jqm5bX4cBsuH+iVUQnqg93uM4D/gmpzmWSbIPoljlD56euft7git12UTj8gNotBypk Q6fMzdMrhudjOZ8jvxYLdP1vKS4nma6PvNPINuYpgCvEUrFDKpJ3eisgc1nSfoBYFLH7 ALY8VqDV8rlaD9hTfj7uwrpkeLtCL7Wvwme6byUkuKH/nuV8RANEK15PaVLl2KdrQeZu tLXHRLmGPmpTw9iQfTzkrZfP+b3bk+/hwuTSYQjGGNCQN1cBL2f0UTluvqzD73tL7DIz b3l4S6AEo2gmRbZbn+LaKW8Cep257zUN/zvzgdtXs1ZsOSIWquowYDZH8GtzxSkejvPa Lmmw== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.61.202 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.61.202 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Maksim Salau , Bernie Thompson , Geert Uytterhoeven , Bartlomiej Zolnierkiewicz , Sasha Levin Subject: [PATCH 4.4 66/97] video: fbdev: udlfb: Fix buffer on stack Date: Fri, 23 Mar 2018 10:54:53 +0100 Message-Id: <20180323094201.332229360@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180323094157.535925724@linuxfoundation.org> References: <20180323094157.535925724@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1595722800036610611?= X-GMAIL-MSGID: =?utf-8?q?1595723162152908601?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Maksim Salau [ Upstream commit 45f580c42e5c125d55dbd8099750a1998de3d917 ] Allocate buffers on HEAP instead of STACK for local array that is to be sent using usb_control_msg(). Signed-off-by: Maksim Salau Cc: Bernie Thompson Cc: Geert Uytterhoeven Signed-off-by: Bartlomiej Zolnierkiewicz Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/video/fbdev/udlfb.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) --- a/drivers/video/fbdev/udlfb.c +++ b/drivers/video/fbdev/udlfb.c @@ -1487,15 +1487,25 @@ static struct device_attribute fb_device static int dlfb_select_std_channel(struct dlfb_data *dev) { int ret; - u8 set_def_chn[] = { 0x57, 0xCD, 0xDC, 0xA7, + void *buf; + static const u8 set_def_chn[] = { + 0x57, 0xCD, 0xDC, 0xA7, 0x1C, 0x88, 0x5E, 0x15, 0x60, 0xFE, 0xC6, 0x97, 0x16, 0x3D, 0x47, 0xF2 }; + buf = kmemdup(set_def_chn, sizeof(set_def_chn), GFP_KERNEL); + + if (!buf) + return -ENOMEM; + ret = usb_control_msg(dev->udev, usb_sndctrlpipe(dev->udev, 0), NR_USB_REQUEST_CHANNEL, (USB_DIR_OUT | USB_TYPE_VENDOR), 0, 0, - set_def_chn, sizeof(set_def_chn), USB_CTRL_SET_TIMEOUT); + buf, sizeof(set_def_chn), USB_CTRL_SET_TIMEOUT); + + kfree(buf); + return ret; }