From: Greg KH <gregkh@linuxfoundation.org>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: laurentiu.tudor@nxp.com, linux-kernel@vger.kernel.org,
stuyoder@gmail.com, ruxandra.radulescu@nxp.com,
razvan.stefanescu@nxp.com, Roy.Pledge@nxp.com, arnd@arndb.de
Subject: Re: [PATCH v2 2/6] bus: fsl-mc: move fsl_mc_command struct in a uapi header
Date: Fri, 23 Mar 2018 15:19:32 +0100 [thread overview]
Message-ID: <20180323141932.GA28906@kroah.com> (raw)
In-Reply-To: <1b6473b17a61f2cea51258a7220c9a1b741c646b.1521132659.git.ioana.ciornei@nxp.com>
On Thu, Mar 15, 2018 at 12:05:32PM -0500, Ioana Ciornei wrote:
> Define "struct fsl_mc_command" as a structure that can cross the
> user/kernel boundary. Also change the variable types used with
> the proper ones.
>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> ---
> Changes in v2:
> - added the patch itself
>
> MAINTAINERS | 1 +
> include/linux/fsl/mc.h | 8 +-------
> include/uapi/linux/fsl_mc.h | 23 +++++++++++++++++++++++
> 3 files changed, 25 insertions(+), 7 deletions(-)
> create mode 100644 include/uapi/linux/fsl_mc.h
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 473ac00..4f54765 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11463,6 +11463,7 @@ S: Maintained
> F: drivers/bus/fsl-mc/
> F: Documentation/devicetree/bindings/misc/fsl,qoriq-mc.txt
> F: Documentation/networking/dpaa2/overview.rst
> +F: include/uapi/linux/fsl_mc.h
>
> QT1010 MEDIA DRIVER
> M: Antti Palosaari <crope@iki.fi>
> diff --git a/include/linux/fsl/mc.h b/include/linux/fsl/mc.h
> index f27cb14..19a352b 100644
> --- a/include/linux/fsl/mc.h
> +++ b/include/linux/fsl/mc.h
> @@ -12,6 +12,7 @@
> #include <linux/device.h>
> #include <linux/mod_devicetable.h>
> #include <linux/interrupt.h>
> +#include <uapi/linux/fsl_mc.h>
>
> #define FSL_MC_VENDOR_FREESCALE 0x1957
>
> @@ -198,8 +199,6 @@ struct fsl_mc_device {
> #define to_fsl_mc_device(_dev) \
> container_of(_dev, struct fsl_mc_device, dev)
>
> -#define MC_CMD_NUM_OF_PARAMS 7
> -
> struct mc_cmd_header {
> u8 src_id;
> u8 flags_hw;
> @@ -209,11 +208,6 @@ struct mc_cmd_header {
> __le16 cmd_id;
> };
>
> -struct fsl_mc_command {
> - u64 header;
> - u64 params[MC_CMD_NUM_OF_PARAMS];
> -};
> -
> enum mc_cmd_status {
> MC_CMD_STATUS_OK = 0x0, /* Completed successfully */
> MC_CMD_STATUS_READY = 0x1, /* Ready to be processed */
> diff --git a/include/uapi/linux/fsl_mc.h b/include/uapi/linux/fsl_mc.h
> new file mode 100644
> index 0000000..90892c4
> --- /dev/null
> +++ b/include/uapi/linux/fsl_mc.h
> @@ -0,0 +1,23 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
UAPI files should have the correct license on them:
/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
thanks,
greg k-h
next prev parent reply other threads:[~2018-03-23 14:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 17:05 [PATCH v2 0/6] bus: fsl-mc: enhance Management Complex userspace support Ioana Ciornei
2018-03-15 17:05 ` [PATCH v2 1/6] bus: fsl-mc: change mc_command in fsl_mc_command Ioana Ciornei
2018-03-15 17:05 ` [PATCH v2 2/6] bus: fsl-mc: move fsl_mc_command struct in a uapi header Ioana Ciornei
2018-03-23 14:19 ` Greg KH [this message]
2018-03-15 17:05 ` [PATCH v2 3/6] bus: fsl-mc: add fsl_mc_allocator cleanup function Ioana Ciornei
2018-03-15 17:05 ` [PATCH v2 4/6] bus: fsl-mc: add restool userspace support Ioana Ciornei
2018-03-15 17:05 ` [PATCH v2 5/6] bus: fsl-mc: add root dprc rescan attribute Ioana Ciornei
2018-03-15 17:05 ` [PATCH v2 6/6] bus: fsl-mc: add bus " Ioana Ciornei
2018-03-23 14:54 ` [PATCH v2 0/6] bus: fsl-mc: enhance Management Complex userspace support Greg KH
2018-03-23 15:09 ` Ioana Ciornei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180323141932.GA28906@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Roy.Pledge@nxp.com \
--cc=arnd@arndb.de \
--cc=ioana.ciornei@nxp.com \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=razvan.stefanescu@nxp.com \
--cc=ruxandra.radulescu@nxp.com \
--cc=stuyoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).