From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joey Pabalinas <joeypabalinas@gmail.com>
Cc: linux-kernel@vger.kernel.org, Frank Seidel <fseidel@suse.de>,
Arnd Bergmann <arnd@arndb.de>, Jiri Slaby <jslaby@suse.cz>
Subject: Re: [PATCH] tty/nozomi: refactor macros and functions
Date: Fri, 23 Mar 2018 16:27:37 +0100 [thread overview]
Message-ID: <20180323152737.GA25972@kroah.com> (raw)
In-Reply-To: <20180321043430.lbvd4fpswl6cy2gq@gmail.com>
On Tue, Mar 20, 2018 at 06:34:30PM -1000, Joey Pabalinas wrote:
> Cleanup a few messy sections of code by replacing constructs
> like `len__ > TMP_BUF_MAX ? TMP_BUF_MAX : len__` with
> `min_t(u32, len__, TMP_BUF_MAX)` and naming identifiers
> more descriptively (where appropriate).
>
> A few sections were nested pretty deeply and have been
> replaced with shallower (but semantically equivalent) logic.
>
> In addition, simplify and coalesce a few of the
> return paths / loop conditionals and correct a few
> pointless Initializations, redundant parentheses/break
> statements, and inconsistently indented line.
That's a lot of different things to do all in a single patch.
Please break this up into a patch series, doing only one logical "thing"
per patch.
thanks,
greg k-h
next prev parent reply other threads:[~2018-03-23 15:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 4:34 [PATCH] tty/nozomi: refactor macros and functions Joey Pabalinas
2018-03-23 15:27 ` Greg Kroah-Hartman [this message]
2018-03-23 20:30 ` Joey Pabalinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180323152737.GA25972@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=fseidel@suse.de \
--cc=joeypabalinas@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).