From: Greg KH <gregkh@linuxfoundation.org>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: laurentiu.tudor@nxp.com, linux-kernel@vger.kernel.org,
stuyoder@gmail.com, ruxandra.radulescu@nxp.com, arnd@arndb.de,
razvan.stefanescu@nxp.com, Roy.Pledge@nxp.com
Subject: Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support
Date: Fri, 23 Mar 2018 16:46:54 +0100 [thread overview]
Message-ID: <20180323154654.GA382@kroah.com> (raw)
In-Reply-To: <d8c243a9ead2fe1375dee242aec26d1276129409.1521818402.git.ioana.ciornei@nxp.com>
On Fri, Mar 23, 2018 at 10:38:56AM -0500, Ioana Ciornei wrote:
> +#include "fsl-mc-private.h"
> +
> +#define FSL_MC_BUS_MAX_MINORS 1
As you only need/want one character device here, why not just use the
misc device api? It's much simpler, and handles all of the housekeeping
for you correctly. It also means I don't have to audit all of your
chardev code to verify it is correct :)
And it will save you lines-of-code, always a good thing.
thanks,
greg k-h
next prev parent reply other threads:[~2018-03-23 15:46 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 15:38 [PATCH v3 0/4] bus: fsl-mc: enhance Management Complex userspace support Ioana Ciornei
2018-03-23 15:38 ` [PATCH v3 1/4] bus: fsl-mc: move fsl_mc_command struct in a uapi header Ioana Ciornei
2018-03-24 20:12 ` kbuild test robot
2018-03-23 15:38 ` [PATCH v3 2/4] bus: fsl-mc: add restool userspace support Ioana Ciornei
2018-03-23 15:46 ` Greg KH [this message]
2018-03-23 15:56 ` Ioana Ciornei
2018-03-23 16:09 ` Greg KH
2018-03-23 20:13 ` Ioana Ciornei
2018-03-24 7:51 ` Arnd Bergmann
2018-03-28 14:27 ` Ioana Ciornei
2018-03-28 15:43 ` Arnd Bergmann
2018-03-28 16:28 ` Andrew Lunn
2018-04-02 13:24 ` Ioana Ciornei
2018-04-02 13:44 ` Andrew Lunn
2018-04-03 11:12 ` Razvan Stefanescu
2018-04-03 13:04 ` Andrew Lunn
2018-04-03 23:57 ` Stuart Yoder
2018-04-04 1:05 ` Andrew Lunn
2018-04-04 3:22 ` Stuart Yoder
2018-04-04 12:42 ` Andrew Lunn
2018-04-05 4:24 ` Stuart Yoder
2018-04-05 10:30 ` Laurentiu Tudor
2018-04-05 11:47 ` Andrew Lunn
2018-04-05 12:16 ` Laurentiu Tudor
2018-04-05 12:48 ` Andrew Lunn
2018-04-05 14:43 ` Laurentiu Tudor
2018-04-05 15:23 ` Andrew Lunn
2018-04-05 15:35 ` Ruxandra Ioana Ciocoi Radulescu
2018-04-05 16:12 ` gregkh
2018-04-05 16:56 ` Andrew Lunn
2018-04-05 12:30 ` gregkh
2018-04-05 14:09 ` Laurentiu Tudor
2018-04-05 14:19 ` gregkh
2018-03-23 15:38 ` [PATCH v3 3/4] bus: fsl-mc: add root dprc rescan attribute Ioana Ciornei
2018-03-23 15:48 ` Greg KH
2018-03-23 16:00 ` Ioana Ciornei
2018-03-23 15:38 ` [PATCH v3 4/4] bus: fsl-mc: add bus " Ioana Ciornei
2018-03-23 15:49 ` Greg KH
2018-04-02 13:46 ` Ioana Ciornei
2018-04-03 7:04 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180323154654.GA382@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Roy.Pledge@nxp.com \
--cc=arnd@arndb.de \
--cc=ioana.ciornei@nxp.com \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=razvan.stefanescu@nxp.com \
--cc=ruxandra.radulescu@nxp.com \
--cc=stuyoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).