archive mirror
 help / color / mirror / Atom feed
From: Herbert Xu <>
To: Leonard Crestez <>
Subject: Re: [PATCH] crypto: arm,arm64 - Fix random regeneration of S_shipped
Date: Sat, 24 Mar 2018 00:03:27 +0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Leonard Crestez <> wrote:
> The decision to rebuild .S_shipped is made based on the relative
> timestamps of .S_shipped and .pl files but git makes this essentially
> random. This means that the perl script might run anyway (usually at
> most once per checkout), defeating the whole purpose of _shipped.
> Fix by skipping the rule unless explicit make variables are provided:
> This can produce nasty occasional build failures downstream, for example
> for toolchains with broken perl. The solution is minimally intrusive to
> make it easier to push into stable.
> Another report on a similar issue here:
> Signed-off-by: Leonard Crestez <>
> Cc: <>

Patch applied.  Thanks.
Email: Herbert Xu <>
Home Page:
PGP Key:

      parent reply	other threads:[~2018-03-23 16:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-13 20:17 Leonard Crestez
2018-03-14  2:31 ` Masahiro Yamada
2018-03-14  7:45   ` Ard Biesheuvel
2018-03-23 16:03 ` Herbert Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] crypto: arm,arm64 - Fix random regeneration of S_shipped' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).