From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752122AbeCYVZw (ORCPT ); Sun, 25 Mar 2018 17:25:52 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:50277 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751208AbeCYVZt (ORCPT ); Sun, 25 Mar 2018 17:25:49 -0400 X-Google-Smtp-Source: AG47ELs8HSUZQcbjHp1+g5mNudyYmnfNfZMnbj/Mew7OQY2kR8/auMIWVBDzsKEiW4bTs3RW8v64+g== Date: Sun, 25 Mar 2018 23:25:41 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Masaki Ota Cc: Dmitry Torokhov , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Aaron Ma Subject: Re: [PATCH] Input: ALPS - fix DualPoint flag for 74 03 28 devices Message-ID: <20180325212541.5wzpvlkcbayfktrz@pali> References: <20171115063404.10066-1-aaron.ma@canonical.com> <20171115083529.jmlpcj4td4evj3xl@pali> <20180129225138.voujq54itw7yblbi@dtor-ws> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hourbr4b45jzelti" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --hourbr4b45jzelti Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tuesday 20 March 2018 11:47:26 Dmitry Torokhov wrote: > On Mon, Jan 29, 2018 at 2:51 PM, dmitry.torokhov@gmail.com > wrote: > > Hi, > > > > On Thu, Nov 16, 2017 at 07:27:02AM +0000, Masaki Ota wrote: > >> Hi, Pali, Aaron, > >> > >> Current code is correct device setting, previous code is wrong. > >> If the trackstick does not work(DUALPOINT flag disable), Device Firmwa= re setting is wrong. > >> > >> But recently I received the same report from Thinkpad L570 user, and I= checked this device and found this device Firmware setting is wrong. Sorry= for our mistake. > >> Is your laptop L570 ? > >> > >> I will add code that supports the trackstick for this device. > > > > Sorry for resurrecting this old thread, I am just trying to understand > > what went wrong here. Is the sequence of "f0 f0 e9" and "ea ea e9" is > > important in getting the correct OTP data and we originally got this > > order wrong? It is not clear from the original patch and discussion that > > this change was intentional. >=20 > Could I please get an answer to my question? >=20 > Thanks! Masaki, this question is for you =E2=86=91=E2=86=91=E2=86=91 > > > > Thanks. > > > >> > >> Best Regards, > >> Masaki Ota > >> -----Original Message----- > >> From: Pali Roh=C3=A1r [mailto:pali.rohar@gmail.com] > >> Sent: Wednesday, November 15, 2017 5:35 PM > >> To: =E5=A4=AA=E7=94=B0 =E7=9C=9F=E5=96=9C Masaki Ota > >> Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; dmitry.= torokhov@gmail.com; Aaron Ma > >> Subject: Re: [PATCH] Input: ALPS - fix DualPoint flag for 74 03 28 dev= ices > >> > >> On Wednesday 15 November 2017 14:34:04 Aaron Ma wrote: > >> > There is a regression of commit 4a646580f793 ("Input: ALPS - fix > >> > two-finger scroll breakage"), ALPS device fails with log: > >> > > >> > psmouse serio1: alps: Rejected trackstick packet from non DualPoint > >> > device > >> > > >> > ALPS device with id "74 03 28" report OTP[0] data 0xCE after commit > >> > 4a646580f793, after restore the OTP reading order, it becomes to 0x10 > >> > as before and reports the right flag. > >> > > >> > Fixes: 4a646580f793 ("Input: ALPS - fix two-finger scroll breakage") > >> > Cc: > >> > Signed-off-by: Aaron Ma > >> > --- > >> > drivers/input/mouse/alps.c | 4 ++-- > >> > 1 file changed, 2 insertions(+), 2 deletions(-) > >> > > >> > diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c > >> > index 579b899add26..c59b8f7ca2fc 100644 > >> > --- a/drivers/input/mouse/alps.c > >> > +++ b/drivers/input/mouse/alps.c > >> > @@ -2562,8 +2562,8 @@ static int alps_set_defaults_ss4_v2(struct > >> > psmouse *psmouse, > >> > > >> > memset(otp, 0, sizeof(otp)); > >> > > >> > - if (alps_get_otp_values_ss4_v2(psmouse, 1, &otp[1][0]) || > >> > - alps_get_otp_values_ss4_v2(psmouse, 0, &otp[0][0])) > >> > + if (alps_get_otp_values_ss4_v2(psmouse, 0, &otp[0][0]) || > >> > + alps_get_otp_values_ss4_v2(psmouse, 1, &otp[1][0])) > >> > return -1; > >> > > >> > alps_update_device_area_ss4_v2(otp, priv); > >> > >> Masaki Ota, please look at this patch as it partially revert your comm= it > >> 4a646580f793 ("Input: ALPS - fix two-finger scroll breakage"). Somethi= ng smells here. > >> > >> -- > >> Pali Roh=C3=A1r > >> pali.rohar@gmail.com > > > > -- > > Dmitry >=20 >=20 >=20 --=20 Pali Roh=C3=A1r pali.rohar@gmail.com --hourbr4b45jzelti Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQS4VrIQdKium2krgIWL8Mk9A+RDUgUCWrgT0wAKCRCL8Mk9A+RD UuaRAJ4p664SWEJfFgtN6lE4jWv+S26AggCfec/0mzYbg27Qd8Bf4d7TousmJtQ= =9V3V -----END PGP SIGNATURE----- --hourbr4b45jzelti--