linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: Nasser Afshin <afshin.nasser@gmail.com>
Cc: p.zabel@pengutronix.de, sakari.ailus@linux.intel.com,
	hans.verkuil@cisco.com, bparrot@ti.com, garsilva@embeddedor.com,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware
Date: Mon, 26 Mar 2018 06:43:53 -0300	[thread overview]
Message-ID: <20180326064353.187f752c@vento.lan> (raw)
In-Reply-To: <20180325225633.5899-1-Afshin.Nasser@gmail.com>

Hi Nasser,

Em Mon, 26 Mar 2018 03:26:33 +0430
Nasser Afshin <afshin.nasser@gmail.com> escreveu:

> According to the datasheet, INTREQ/GPCL/VBLK should have a pull-up/down
> resistor if it's been disabled. On hardware that does not have such
> resistor, we should use the default output enable value.
> This prevents the color burst lock instability problem.

If this is hardware-dependent, you should instead store it at
OF (for SoC) or pass via platform_data (for PCI/USB devices).

> 
> Signed-off-by: Nasser Afshin <Afshin.Nasser@gmail.com>
> ---
>  drivers/media/i2c/tvp5150.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
> index 2476d812f669..0e9713814816 100644
> --- a/drivers/media/i2c/tvp5150.c
> +++ b/drivers/media/i2c/tvp5150.c
> @@ -328,7 +328,7 @@ static const struct i2c_reg_value tvp5150_init_default[] = {
>  		TVP5150_OP_MODE_CTL,0x00
>  	},
>  	{ /* 0x03 */
> -		TVP5150_MISC_CTL,0x01
> +		TVP5150_MISC_CTL,0x21
>  	},
>  	{ /* 0x06 */
>  		TVP5150_COLOR_KIL_THSH_CTL,0x10
> @@ -1072,7 +1072,8 @@ static int tvp5150_s_stream(struct v4l2_subdev *sd, int enable)
>  		 * Enable the YCbCr and clock outputs. In discrete sync mode
>  		 * (non-BT.656) additionally enable the the sync outputs.
>  		 */
> -		val |= TVP5150_MISC_CTL_YCBCR_OE | TVP5150_MISC_CTL_CLOCK_OE;
> +		val |= TVP5150_MISC_CTL_YCBCR_OE | TVP5150_MISC_CTL_CLOCK_OE |
> +			TVP5150_MISC_CTL_INTREQ_OE;
>  		if (decoder->mbus_type == V4L2_MBUS_PARALLEL)
>  			val |= TVP5150_MISC_CTL_SYNC_OE;
>  	}



Thanks,
Mauro

  reply	other threads:[~2018-03-26  9:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-25 22:56 [PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware Nasser Afshin
2018-03-26  9:43 ` Mauro Carvalho Chehab [this message]
2018-03-26 22:29   ` Nasser
2018-03-29 14:34     ` Nasser
2018-03-29 15:02       ` Mauro Carvalho Chehab
2018-03-29 18:07         ` Nasser
2018-03-29 19:19           ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180326064353.187f752c@vento.lan \
    --to=mchehab@kernel.org \
    --cc=afshin.nasser@gmail.com \
    --cc=bparrot@ti.com \
    --cc=garsilva@embeddedor.com \
    --cc=hans.verkuil@cisco.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).