From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Guenter Roeck <linux@roeck-us.net>,
Sebastian Reichel <sre@kernel.org>,
Hans de Goede <hdegoede@redhat.com>, Jun Li <jun.li@nxp.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Support Opensource <Support.Opensource@diasemi.com>
Subject: Re: [PATCH v7 2/6] Documentation: power: Initial effort to document power_supply ABI
Date: Mon, 26 Mar 2018 14:50:19 +0200 [thread overview]
Message-ID: <20180326125019.GA29451@kroah.com> (raw)
In-Reply-To: <2E89032DDAA8B9408CB92943514A0337014C1E2EFD@SW-EX-MBX01.diasemi.com>
On Mon, Mar 26, 2018 at 12:40:06PM +0000, Adam Thomson wrote:
> On 26 March 2018 10:57, Greg Kroah-Hartman wrote:
>
> > On Fri, Mar 23, 2018 at 10:12:21AM +0000, Adam Thomson wrote:
> > > This commit adds generic ABI information regarding power_supply
> > > properties. This is an initial attempt to try and align the usage
> > > of these properties between drivers. As part of this commit,
> > > common Battery and USB related properties have been listed.
> > >
> > > Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
> > > ---
> > > Documentation/ABI/testing/sysfs-class-power | 443
> > ++++++++++++++++++++++++++++
> > > MAINTAINERS | 1 +
> > > 2 files changed, 444 insertions(+)
> >
> > How was this not documented before?
>
> As an FYI, there is some overall documentation under:
>
> Documentation/power/power_supply_class.txt
>
> However, after discussions with Heikki, it was determined something more
> detailed would be useful to help clarify usage.
Oh I agree, it belongs in Documentation/ABI/ like you did here, thank
you so much for that. I was just amazed it wasn't already there...
thanks,
greg k-h
next prev parent reply other threads:[~2018-03-26 12:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 10:12 [PATCH v7 0/6] typec: tcpm: Add sink side support for PPS Adam Thomson
2018-03-23 10:12 ` [PATCH v7 1/6] typec: tcpm: Add core support for sink side PPS Adam Thomson
2018-03-26 3:10 ` Guenter Roeck
2018-04-22 14:05 ` Greg Kroah-Hartman
2018-04-22 20:57 ` Adam Thomson
2018-04-23 7:49 ` Adam Thomson
2018-04-23 8:25 ` Greg Kroah-Hartman
2018-04-23 11:06 ` Adam Thomson
2018-04-23 11:28 ` Greg Kroah-Hartman
2018-04-23 12:47 ` Adam Thomson
2018-04-23 13:20 ` Greg Kroah-Hartman
2018-03-23 10:12 ` [PATCH v7 2/6] Documentation: power: Initial effort to document power_supply ABI Adam Thomson
2018-03-26 9:57 ` Greg Kroah-Hartman
2018-03-26 12:40 ` Adam Thomson
2018-03-26 12:50 ` Greg Kroah-Hartman [this message]
2018-03-23 10:12 ` [PATCH v7 3/6] power: supply: Add error checking of psy desc during registration Adam Thomson
2018-03-23 10:12 ` [PATCH v7 4/6] power: supply: Add 'usb_type' property and supporting code Adam Thomson
2018-03-23 10:12 ` [PATCH v7 5/6] typec: tcpm: Represent source supply through power_supply Adam Thomson
2018-03-26 3:14 ` Guenter Roeck
2018-03-23 10:12 ` [PATCH v7 6/6] typec: tcpm: Add support for sink PPS related messages Adam Thomson
2018-03-26 3:15 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180326125019.GA29451@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jun.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).